It is currently 30 Apr 2025, 10:41
   
Text Size

Shandalar - Program Bugs

Selling cards doesn't work properly (fix completed)

 

Another Deckbuilder bug. Sometimes when you sell a card, the game doesn't register selling it at all. It will vanish only after you exit the interface. In addition, if the card is placed on your inventory, game allow to sell them repeatedly without losing the card.
Last edited by walrus on 09 Aug 2016, 19:54, edited 1 time in total.

Comments

Posted by Rawky » 14 Aug 2016, 18:14

Confirmed.

Just did a fresh install of HS1. Created New game. Tried to sell off junk cards. Receive gold, card is not removed. Am able to repeatedly click sell for gold for the same card. Reloading OS and game did not fix.

Posted by TheKillerNacho » 15 Aug 2016, 13:55

I'm getting the same issue.

To add to what others have said if you sell a card from your deck it seems it sells another card from your deck entirely... specifically whichever card is last in the list.

Posted by Korath » 16 Aug 2016, 00:38

Seems to work when selling a card in your current deck, but it just removes it from the current-deck pane, which is how I missed this. If you swap to a different deck and back, or leave the deckbuilder and re-enter, the card's there again. Doesn't matter if it's the only copy of the card in your deck or not.

I can't reproduce it removing a different card. Do you get that when selling a card from the current-deck pane at the top, or from the cards-not-in-your-deck scroll list at the bottom? Are you at or near the 500-card limit? Are you running in fullscreen or a window? (I sure hope that last part doesn't matter.)

I can't repro it vanishing after you leave the deckbuilder and re-enter, either. Same questions as above, to people who are seeing this variant.
Last edited by Korath on 16 Aug 2016, 00:39, edited 1 time in total.
Reason: +last paragraph

Posted by Korath » 16 Aug 2016, 08:57

It's removing whatever card preceded it in the internal ordering (which I think is unsorted). Leaving the deckbuilder and reentering would only fix it by accident, I think, if you happened to also try to sell whatever card followed it.

Posted by Korath » 16 Aug 2016, 09:02

commit c589840d7ca4248dbbd3c1a4c581e79bf89737ad
Author: Korath <dgk@Dirge.none>
Date: Tue Aug 16 05:01:16 2016 -0400

[DECKDLL] FIX #1149: fix off-by-one error in sold card index

Posted by Korath » 16 Aug 2016, 09:14

Here's a deckdll.dll build. It seems to work for me, so far as I can tell, but then so did the last one. Please confirm so I don't have to go through this again in another couple days.

It won't fix the #1150, the 40-extra-basiclands bug, which needs a Shandalar.dll build. Consider it a temporary difficulty increase, I guess? Or debug a Mana Severance into your hand and cast it first thing each duel.

If nothing else similarly major turns up, I'll package and release in a day or two. (Probably not until I'm ready for a Manalink bugfix release too, if I don't get independent confirmation on this; I'm aiming for the weekend on that.)
Attachments
deckdll-c589840.zip
(125.6 KiB) Downloaded 191 times

Posted by TheKillerNacho » 16 Aug 2016, 20:02

Thanks for addressing these, Korath!

I'll wait for the complete fix if you think it'll be done around this weekend. Either way, thank you for your haste at fixing these game-breaking issues. =D>

Ticket details

  • Ticket ID: 1149
  • Project: Shandalar
  • Status: Fix completed
  • Component: Adventure Mode
  • Project version: Hall of the Sultan 1
  • Priority: Normal
  • Severity: Major
  • Assigned to: Korath
  • Reported by: walrus
  • Reporter's tickets: List all tickets
  • Reported on: 09 Aug 2016, 19:50
  • Last visited by Korath » 07 Dec 2016, 16:46.
 

Login Form