It is currently 04 Sep 2025, 01:34
   
Text Size

Formal Request Thread

Moderator: CCGHQ Admins

Re: Formal Request Thread

Postby Master Necro » 22 Jul 2013, 20:52

thefiremind wrote:
Master Necro wrote:Ouu didn't know that thanks! :)
To be honest, I didn't know either, you made me discover that. But I have always included DURATION blocks on effects that last indefinitely, because even those effects have a duration: when the cards that they affect change zone, they stop doing anything that matters, and keeping useless effects "lingering" on the board would be a waste. :wink:
Glad to inspire. :)

Quick question how do I code the trigger "Whenever a creature attacks you"?
User avatar
Master Necro
 
Posts: 259
Joined: 24 Apr 2013, 18:25
Has thanked: 83 times
Been thanked: 21 times

Re: Formal Request Thread

Postby thefiremind » 22 Jul 2013, 21:03

Master Necro wrote:Quick question how do I code the trigger "Whenever a creature attacks you"?
If a creature attacks you, then you are the attacked player...
Code: Select all
    <TRIGGER value="ATTACKING">
    return TriggerObject():GetPlayerAttacked() == EffectController()
    </TRIGGER>
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Formal Request Thread

Postby Xander9009 » 22 Jul 2013, 21:05

I went back through this thread to see if there were any outstanding requests. I found a few, so here's the list of ones that don't appear to have been done yet. This is just to collect them all in one place. I'll be more than happy to do them, but I'm also wondering if anyone knows if any of them exist in mods already so we can just point them that way. (Or, if they know it was already done and I just missed it.)

(These first few I'm just listing because they were asked for here but never answered here or pointed out.)
Urza's Incubator - Riiak said he might do it if he gets around to it. If I start feeling particularly brave and adventurous, I might give it a shot, but I warn you, if I do, I reserve the right to ask for lots of help :)
Birds of Paradise - Exists in Riiak's mods.
Elesh Norn, Grand Cenobite - Exists in Sumomole's mods.
Rite of Replication - Exists in BloodRyvyn's mods.


Aether Vial
Artillerize
Ashenmoor Liege
Brimstone Volley
Contested War Zone
Darksteel Axe
Darksteel Plate
Darksteel Relic
Goblin Bushwhacker
Goblin Grenade
Goblin Guide
Incinerate
Kuldotha Rebirth
Necroskitter
Phylactery Lich
Shrine of Burning Rage
Signal Pest
Springjack Pasture
Zhur-Taa Druid
All of the above can be found in a three-post section starting here.

Ghostly Prison
Ravenous Demon // Archdemon of Greed - TFM is working on transform cards.
Total War

Corrosive Mentor - thefiremind's mods.
Krasis Incubation - I don't think the working code was ever posted.
Phyrexian Obliterator - I know this was answered, but did it actually work?
Restore the Peace - thefiremind mentioned trying to do this card. I was just curious if you'd ever managed it.

EDIT: Reordered alphabetically and crossed off completed ones.
Last edited by Xander9009 on 05 Aug 2013, 07:33, edited 2 times in total.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Formal Request Thread

Postby Master Necro » 22 Jul 2013, 21:12

thefiremind wrote:
Master Necro wrote:Quick question how do I code the trigger "Whenever a creature attacks you"?
If a creature attacks you, then you are the attacked player...
Code: Select all
    <TRIGGER value="ATTACKING">
    return TriggerObject():GetPlayerAttacked() == EffectController()
    </TRIGGER>
Thanks! :)
User avatar
Master Necro
 
Posts: 259
Joined: 24 Apr 2013, 18:25
Has thanked: 83 times
Been thanked: 21 times

Re: Formal Request Thread

Postby BloodReyvyn » 23 Jul 2013, 09:46

Xander9009 wrote:I went back through this thread to see if there were any outstanding requests. I found a few, so here's the list of ones that don't appear to have been done yet. This is just to collect them all in one place. I'll be more than happy to do them, but I'm also wondering if anyone knows if any of them exist in mods already so we can just point them that way. (Or, if they know it was already done and I just missed it.)

(These first few I'm just listing because they were asked for here but never answered here or pointed out.)
Urza's Incubator - Riiak said he might do it if he gets around to it. If I start feeling particularly brave and adventurous, I might give it a shot, but I warn you, if I do, I reserve the right to ask for lots of help :)
Birds of Paradise - Exists in Riiak's mods.
Elesh Norn, Grand Cenobite - Exists in Sumomole's mods.
Phyrexian Obliterator - I know this was answered, but did it actually work?
Rite of Replication - Exists in BloodRyvyn's mods.


Ghostly Prison
Total War
Ravenous Demon // Archdemon of Greed - Can flip cards even be done?
Ashenmoor Liege
Corrosive Mentor
Necroskitter
Phylactery Lich
Darksteel Axe
Darksteel Relic
Darksteel Plate
Springjack Pasture
Krasis Incubation
Contested War Zone - I've already started this, but it's not working yet.
Shrine of Burning Rage
Signal Pest
Kuldotha Rebirth
Goblin Grenade
Goblin Bushwhacker
Goblin Guide
Artillerize
Incinerate
Brimstone Volley
Aether Vial
Zhur-Taa Druid


Restore the Peace - thefiremind mentioned trying to do this card. I was just curious if you'd ever managed it.
Well I did start on a Phylactery Lich, but I only got this far:

Code: Select all
<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="PHYLACTERY_LICH_271386" />
  <CARDNAME text="PHYLACTERY_LICH" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Phylactery Lich]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Liche aux phylactères]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Liche de la filacteria]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Phylakterion-Lich]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Lich del Filatterio]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[聖句札の死者]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[부적 리치]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Лич с Филактерией]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Lich do Talismã]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="271386" />
  <ARTID value="271386" />
  <ARTIST name="Michael Komarck" />
  <CASTING_COST cost="{B}{B}{B}" />
  <TYPE metaname="Creature" />
  <SUB_TYPE metaname="Zombie" />
  <EXPANSION value="M13" />
  <RARITY metaname="R" />
  <POWER value="5" />
  <TOUGHNESS value="5" />
  <STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Indestructible]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Indestructible]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Indestructible.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Unzerstörbar]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Indistruttibile]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[破壊不能]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[무적]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Неразрушимость]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Indestrutível]]></LOCALISED_TEXT>
    <INTRINSIC characteristic="CHARACTERISTIC_INDESTRUCTIBLE" />
  </STATIC_ABILITY>
  <TRIGGERED_ABILITY pre_trigger="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[As Phylactery Lich enters the battlefield, put a phylactery counter on an artifact you control.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[La Liche aux phylactères est indestructible.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[El Liche de la filacteria es indestructible.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Der Phylakterion-Lich ist unzerstörbar.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Il Lich del Filatterio è indistruttibile.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[聖句札の死者は破壊されない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[부적 리치는 파괴될 수 없다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Лич с Филактерией не может быть уничтожен.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Lich do Talismã é indestrutível.]]></LOCALISED_TEXT>
    <TRIGGER value="ZONECHANGE_BEGIN" simple_qualifier="self" to_zone="ZONE_BATTLEFIELD" />
    <TARGET tag="CARD_QUERY_CHOOSE_ARTIFACT_TO_PUT_PHYLACTERY_COUNTER" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
      if EffectSource():WasKicked() == true then
        local filter = ClearFilter()
      filter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
        filter:Add(FE_CONTROLLER, OP_IS, EffectController() )
      end
    </TARGET_DEFINITION>
    <COUNTER_REGISTRATION name="Phylactery" proliferate="11" />
    <RESOLUTION_TIME_ACTION>
      local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
      if target ~= nil then
       target:AddCounters( MTG():GetCountersType("Phylactery"), 1)
      end
    </RESOLUTION_TIME_ACTION>
    <AUTO_SKIP no_effect_source="1" />
  </TRIGGERED_ABILITY>
  <STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[When you control no permanents with phylactery counters on them, sacrifice Phylactery Lich.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Quand vous ne contrôlez pas de permanents avec des marqueurs « phylactère » sur eux, sacrifiez la Liche aux phylactères.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cuando no controles permanentes con contadores de filacteria sobre ellos, sacrifica el Liche de la filacteria.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Wenn du keine bleibenden Karten mit Phylakterion-Marken kontrollierst, opfere den Phylakterion-Lich.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Quando non controlli permanenti con segnalini filatterio, sacrifica il Lich del Filatterio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[あなたが聖句カウンターが置かれているパーマネントをコントロールしていないとき、聖句札の死者を生け贄に捧げる。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[당신이 부적 카운터를 가진 지속물을 조종하지 않을 때, 부적 리치를 희생한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Когда под вашим контролем нет перманентов с жетонами филактерии на них, пожертвуйте Лича с Филактерией.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Quando você não controlar nenhuma permanente com marcadores de talismã, sacrifique Lich do Talismã.]]></LOCALISED_TEXT>
    <COUNTER_REGISTRATION name="Phylactery" proliferate="11" />
    <CONTINUOUS_ACTION>
      local filter = ClearFilter()
      filter:Add(FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT)
      filter:Add(FE_CONTROLLER, OP_IS, EffectController() )
      local artifacts = filter:EvaluateObjects()
      local counters = 0
      for i = 0, (artifacts - 1) do
        local count = filter:GetNthEvaluatedObject(i):CountCounters(MTG():GetCountersType("Phylactery"))
        if count &gt; 0 then
          counters = (counters + 1)
        end
      end
      if counters == 0 then
        EffectController():Sacrifice(EffectSource())
      end
    </CONTINUOUS_ACTION>
  </STATIC_ABILITY>
  <HELP title="MORE_INFO_BADGE_TITLE_8" body="MORE_INFO_BADGE_BODY_8" zone="ZONE_ANY" />
  <SFX text="COMBAT_BLUNT_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
  <SFX text="COMBAT_BLUNT_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
</CARD_V2>
Unfortunately it goes directly to the grave and it ended up in the cards "I never finished because I didn't need them yet" pile. lol
"There's an experience worse than blindness - it's the certainty that your vision is perfect and the horror that there's no world around you to see."
User avatar
BloodReyvyn
 
Posts: 421
Joined: 19 May 2013, 13:29
Has thanked: 53 times
Been thanked: 40 times

Re: Formal Request Thread

Postby thefiremind » 23 Jul 2013, 11:19

Xander9009 wrote:Phyrexian Obliterator - I know this was answered, but did it actually work?
The requester said that it works.

Xander9009 wrote:Ravenous Demon // Archdemon of Greed - Can flip cards even be done?
I'm working on transform cards at the moment (flip cards - the Kamigawa ones - are a different story).

Xander9009 wrote:Corrosive Mentor
It's in my mod.

Xander9009 wrote:Krasis Incubation
The problem with this card was solved, I'm quite sure that the requester has a working version now, just search through the topic and find who asked for help on it.

Xander9009 wrote:Restore the Peace - thefiremind mentioned trying to do this card. I was just curious if you'd ever managed it.
The limits on interrogations don't allow me to code it, but that doesn't mean that nobody else can find a better idea.

BloodReyvyn wrote:Well I did start on a Phylactery Lich, but I only got this far:
I do still get surprised by looking at some code... :lol: for example, EffectSource():WasKicked()... do you see any mention about kicker on Phylactery Lich? :roll:
The "As <cardname> enters the battlefield" triggers should be coded as ZONECHANGE_TRANSITION triggers, they have always been coded like that.
In DotP2014 pre_trigger="1" needs to be put on TRIGGER rather than on TRIGGERED_ABILITY, but I don't even think it's needed here.
The "When <something is true>" triggers are a bit nasty... I know that DotP2012 used a STATIC_ABILITY for Phylactery Lich, but I don't like that implementation. A STATE_BASED_EFFECTS trigger is closer to the real rules, the only thing to care about is to make it trigger only once. If you look at Opal Avenger in my mod you can see how I solved that problem through a LinkedDC flag. I don't have time to code a Phylactery Lich now because I'm working on transform cards.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Formal Request Thread

Postby Master Necro » 23 Jul 2013, 15:08

I had a problem with Krasis Incubation and I confirm that it was fixed.

Edit: Transform cards?!!!! :D
Last edited by Master Necro on 23 Jul 2013, 17:42, edited 1 time in total.
User avatar
Master Necro
 
Posts: 259
Joined: 24 Apr 2013, 18:25
Has thanked: 83 times
Been thanked: 21 times

Re: Formal Request Thread

Postby Master Necro » 23 Jul 2013, 16:15

And I have a few problems:

My Azorius First-Wing does not have protection form enchantments, the opponent has managed to trap it with the Oblivion ring:

Code: Select all
<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="AZORIUS_FIRSTWING_1797101" />
  <CARDNAME text="AZORIUS_FIRSTWING" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Azorius First-Wing]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="1797101" />
  <ARTID value="A97101" />
  <ARTIST name="Alex Horley-Orlandelli" />
  <CASTING_COST cost="{W}{U}" />
  <FLAVOURTEXT>
      <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
      <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[With a steady diet of lawbreakers, Azorius griffins inevitably develop a resistance to the contraband magic that taints much of their prey.]]></LOCALISED_TEXT>
   </FLAVOURTEXT>
  <TYPE metaname="Creature" />
  <SUB_TYPE metaname="Griffin" />
  <EXPANSION value="RTR" />
  <RARITY metaname="C" />
  <POWER value="2" />
  <TOUGHNESS value="2" />
  <STATIC_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Flying]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Vol]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Vuela.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Fliegend]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Volare]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[飛行]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[비행]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Полет]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Voar]]></LOCALISED_TEXT>
    <INTRINSIC characteristic="CHARACTERISTIC_FLYING" />
  </STATIC_ABILITY>
  <STATIC_ABILITY commaspace="1">
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Protection from enchantments]]></LOCALISED_TEXT>
    <CONTINUOUS_ACTION layer="0">
    if EffectSource() ~= nil then
       local filter = ClearFilter()
       
       local filter = filter:AddFilter_Or()
          filter:Add( FE_TYPE, OP_IS, ENCHANTMENT )
          EffectSource():Protection()
       
    end
    </CONTINUOUS_ACTION>
  </STATIC_ABILITY>
  <SFX text="COMBAT_CLAW_MAGIC_LARGE_ATTACK" power_boundary_min="4" power_boundary_max="-1" />
  <SFX text="COMBAT_CLAW_MAGIC_SMALL_ATTACK" power_boundary_min="1" power_boundary_max="3" />
  <AI_BASE_SCORE score="600" zone="ZONE_BATTLEFIELD" />
</CARD_V2>
And @thefiremnid:

I used some of your Detain cards such as Inaction Injunction , Martial Law etc...

Here is one:

Code: Select all
<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="MARTIAL_LAW_17253598" />
  <CARDNAME text="MARTIAL_LAW" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Martial Law]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Loi martiale]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Ley marcial]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Kriegsrecht]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Legge Marziale]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[戒厳令]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[계엄령]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Военное Положение]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Lei Marcial]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="17253598" />
  <ARTID value="A253598" />
  <ARTIST name="Tyler Jacobson" />
  <CASTING_COST cost="{2}{W}{W}" />
  <FLAVOURTEXT>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[“The good of society matters much more than the inconvenience of a few.”
—Agmand Sarv, Azorius hussar]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[« Le bien commun importe bien plus que l’inconfort de quelques-uns. »
—Agmand Sarv, hussard d’Azorius]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[“El bien de la sociedad importa mucho más que las molestias de unos pocos.”
—Agmand Sarv, húsar azorio]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[„Das Wohl der Gesellschaft ist viel wichtiger als die Unbill einiger weniger.”
—Agmand Sarv, Azorius-Husar]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[“Il disagio di pochi è un piccolo prezzo da pagare per il bene della società intera.”
—Agmand Sarv, ussaro Azorius]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[「一握りの個人の不都合などより、社会の安定のほうがはるかに重要だ。」
――アゾリウスの騎兵、アグマンド・サーヴ]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[“사회 전체의 이익을 위해서라면 소수의 불편은 감수하는 것이 마땅하다.”
—아조리우스 경기병 아그만드 사르브]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[«Во благо общества можно причинить неудобства меньшинству».
— Агманд Сарв, гусар Азориусов]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[“O bem da sociedade é muito mais importante do que a inconveniência de uns poucos.”
— Agmand Sarv, hussardo azorius]]></LOCALISED_TEXT>
  </FLAVOURTEXT>
  <TYPE metaname="Enchantment" />
  <EXPANSION value="RTR" />
  <RARITY metaname="R" />
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of your upkeep, detain target creature an opponent controls.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Au début de votre entretien, détenez une créature ciblée qu’un adversaire contrôle.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Al comienzo de tu mantenimiento, detén la criatura objetivo que controla un oponente.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Inhaftiere zu Beginn deines Versorgungssegments eine Kreatur deiner Wahl, die ein Gegner kontrolliert.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[All’inizio del tuo mantenimento, trattieni una creatura bersaglio controllata da un avversario.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[あなたのアップキープの開始時に、対戦相手1人がコントロールするクリーチャー1体を対象とし、それを留置する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[당신의 유지단 시작에, 상대가 조종하는 생물 한 개를 목표로 정한다. 그 생물을 억류한다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[В начале вашего шага поддержки задержите целевое существо под контролем оппонента.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[No início de sua manutenção, detenha a criatura alvo que um oponente controla.]]></LOCALISED_TEXT>
    <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
    return MTG():GetStep() == STEP_UPKEEP
    </TRIGGER>
    <TARGET tag="CARD_QUERY_CHOOSE_PERMANENT_TO_DETAIN" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add(FE_TYPE, OP_IS, CARD_TYPE_CREATURE)
    filter:Add( FE_TEAM, OP_NOT, EffectController():GetTeam() )
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    EffectDC():Set_Int( 1, MTG():GetTurnNumber() )
    </RESOLUTION_TIME_ACTION>
    <CONTINUOUS_ACTION layer="8">
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if target ~= nil then
       local characteristics = target:GetCurrentCharacteristics()
       characteristics:Bool_Set(CHARACTERISTIC_CANT_ATTACK, 1)
       characteristics:Bool_Set(CHARACTERISTIC_CANT_BLOCK, 1)
       characteristics:Bool_Set(CHARACTERISTIC_CANT_USE_ACTIVATED_ABILITIES, 1)
       characteristics:Badge_Set(BADGE_CANT_BLOCK)
    end
    </CONTINUOUS_ACTION>
    <DURATION>
    return EffectDC():Get_Targets(0):Get_CardPtr(0) == nil or TFM_UntilMyNextTurn( EffectDC():Get_Int(1) )
    </DURATION>
    <AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />
    <SFX text="TARGET_WHITE_MAGIC_PLAY" />
  </TRIGGERED_ABILITY>
  <AI_BASE_SCORE score="750" zone="ZONE_BATTLEFIELD" />
</CARD_V2>
As you see I didn't change anything important.

The problem is detain is permanent it doesn't stop on my next turn it just stays.
User avatar
Master Necro
 
Posts: 259
Joined: 24 Apr 2013, 18:25
Has thanked: 83 times
Been thanked: 21 times

Re: Formal Request Thread

Postby thefiremind » 23 Jul 2013, 18:06

Master Necro wrote:My Azorius First-Wing does not have protection form enchantments, the opponent has managed to trap it with the Oblivion ring:
Code: Select all
local filter = filter:AddFilter_Or()
This doesn't have much sense, first because you are re-using the filter variable for a sub-filter losing the possibility to address the main filter again if needed (you don't need it here, but bad habits should never be followed), and second because adding a sub-filter is useless here since you need to filter only enchantments.
And ENCHANTMENT isn't defined anywhere, it should be CARD_TYPE_ENCHANTMENT. If I were you, I would have copied the filter for enchantments from Auramancer... I never write a filter manually if there's an example to copy from an existing card, and being lazy isn't always bad... :mrgreen:

Master Necro wrote:The problem is detain is permanent it doesn't stop on my next turn it just stays.
Are you aware that all the functions and constants starting with "TFM_" depend on my LOL files? You need to keep at least DATA_DLC_TFM_OTHER installed for TFM_UntilMyNextTurn to work.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3515
Joined: 07 Nov 2011, 10:55
Has thanked: 118 times
Been thanked: 722 times

Re: Formal Request Thread

Postby gorem2k » 24 Jul 2013, 01:26

How to code activated ability with {X} {X} in its cost?

Deepfire Elemental ability | Open
Code: Select all
  <ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{X}{X}{1}: Destroy target artifact or creature with converted mana cost X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{X}{X}{1} : Détruisez l’artefact ciblé ou la créature ciblée dont le coût converti de mana est X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{X}{X}{1}: Destruye el artefacto o criatura objetivo con coste de maná convertido igual a X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{X}{X}{1}: Zerstöre ein Artefakt oder eine Kreatur deiner Wahl mit umgewandelten Manakosten von X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{X}{X}{1}: Distruggi un artefatto o una creatura bersaglio con costo di mana convertito pari a X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{X}{X}{1}:点数で見たマナ・コストがXのアーティファクト1つかクリーチャー1体を対象とし、それを破壊する。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{X}{X}{1}: Destroy target artifact or creature with converted mana cost X.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{X}{X}{1}: Уничтожьте целевой артефакт или существо с общей мановой стоимостью Х.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{X}{X}{1}: Destrua o artefato alvo ou a criatura alvo com custo de mana convertido igual a X.]]></LOCALISED_TEXT>
    <COST mana_cost="{X}{X}{1}" type="Mana" />
    <TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_DESTROY" definition="0" compartment="0" count="1" />
    <TARGET_DEFINITION id="0">
    local filter = ClearFilter()
    filter:Add( FE_CMC, OP_EQUALS, GetEffectX() )
    local subfilter = filter:AddSubFilter_Or()
       subfilter:Add( FE_TYPE, OP_IS, CARD_TYPE_ARTIFACT )
       subfilter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION>
    local target = EffectDC():Get_Targets(0):Get_CardPtr(0)
    if target ~= nil then   
       target:Destroy() 
    end
    </RESOLUTION_TIME_ACTION>
  </ACTIVATED_ABILITY>
I'd like to request:
Jotun Grunt and Jotun Owl Keeper. Braid of Fire too would be nice.
gorem2k
 
Posts: 464
Joined: 01 Apr 2013, 04:21
Has thanked: 48 times
Been thanked: 33 times

Re: Formal Request Thread

Postby drleg3nd » 24 Jul 2013, 04:20

hey someone asked but I don't think anyone answered but can dual cards like "far and away" be made ?
drleg3nd
 
Posts: 528
Joined: 14 May 2012, 20:05
Has thanked: 5 times
Been thanked: 30 times

Re: Formal Request Thread

Postby jacque » 24 Jul 2013, 04:51

Wondering if someone could have these included in their cores?

- Lashwrithe
- Skinrender
- Shadowmage Infiltrator
- Wellwisher
- Joraga Warcaller
- Momentous Fall
- Hero of Bladehold
- Knight Exemplar
- Grafted Wargear
- Master Biomancer

Really appreciate it... Thanks!
Learn making your own cards today!!!

Click on Image if a post/reply helped you.

I stitch old cards together to make new ones...

~ Jacque, the confused
jacque
 
Posts: 217
Joined: 07 Jun 2013, 20:11
Has thanked: 26 times
Been thanked: 44 times

Re: Formal Request Thread

Postby Kieran » 24 Jul 2013, 05:39

Can someone help me make this Land Tax code work?

| Open
Code: Select all
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[All’inizio del tuo mantenimento, se un avversario controlla più terre di te, puoi passare in rassegna il tuo grimorio per un massimo di 3 carte terra base, rivelarle e aggiungerle alla tua in mano. Se lo fai, rimescola il tuo grimorio.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <TRIGGER value="BEGINNING_OF_STEP" simple_qualifier="controller">
    return ( PlayersUpkeep( EffectController() ) and CountCardsInLibrary( EffectController() ) &gt; 199 )
    </TRIGGER>
    <RESOLUTION_TIME_ACTION>
    local num_players = MTG():GetNumberOfPlayers()
    local filter = Object():GetFilter()
    local highest_opp_lands = 0
    local total = 0
    local my_lands = 0
    for i=0,num_players-1 do
   local player = MTG():GetNthPlayer(i)
   if player ~= nil and player:GetTeam() ~= EffectController():GetTeam() then
      filter:Clear()
      filter:AddCardType( CARD_TYPE_LAND )
      filter:SetController( player )
      filter:SetZone( ZONE_IN_PLAY )
      total = filter:Count()
      if total &gt; highest_opp_lands then
             highest_opp_lands = total
      end
   end
    end
    filter:Clear()
    filter:AddCardType( CARD_TYPE_LAND )
    filter:SetController( EffectController() )
    filter:SetZone( ZONE_IN_PLAY )
    mylands = filter:Count()
    if highest_opp_lands &gt; mylands then
   EffectController():MarkSearchedLibrary()
   filter:Clear()
   filter:May()
   filter:NotTargetted()
   filter:AddSubType( LAND_TYPE_PLAINS )
   filter:SetZone( ZONE_LIBRARY )
   filter:SetPlayer( EffectController() )
   EffectController():ChooseTarget( NO_VALIDATION, "CARD_QUERY_CHOOSE_LAND_PLAINS_TO_PUT_ONTO_BATTLEFIELD", EffectDC():Make_Targets(0) )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local targetDC = EffectDC():Get_Targets(0)
    if targetDC ~= nil then
   local target_card = targetDC:Get_CardPtr(0)
   if target_card ~= nil then
      target_card:PutIntoPlay( EffectController() )
   end
    end 
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    EffectController():ShuffleLibrary()
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
Kieran
 
Posts: 232
Joined: 03 Nov 2012, 01:09
Has thanked: 21 times
Been thanked: 16 times

Re: Formal Request Thread

Postby Master Necro » 24 Jul 2013, 05:41

@Kieran:

The great Kev already made that card:

Code: Select all
<?xml version='1.0'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="LAND_TAX_888201153" />
  <CARDNAME text="LAND_TAX" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Land Tax]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Land Tax]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="888201153" />
  <ARTID value="A888201153" />
  <ARTIST name="Chuck Lukacs" />
  <CASTING_COST cost="{W}" />
  <TYPE metaname="Enchantment" />
  <EXPANSION value="DPI" />
  <RARITY metaname="R" />
  <TRIGGERED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[At the beginning of your upkeep, if an opponent controls more lands than you, you may search your library for up to three basic land cards, reveal them, and put them into your hand. If you do, shuffle your library.]]></LOCALISED_TEXT>
    <TRIGGER value="BEGINNING_OF_PLAYERS_STEP" simple_qualifier="controller">
    return MTG():GetStep() == STEP_UPKEEP
    </TRIGGER>
    <INTERVENING_IF>
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
    filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
    local myLand = filter:Count()
    local numPlayer = MTG():GetNumberOfPlayers()
    for i = 0, (numPlayer-1) do
       local player = MTG():GetNthPlayer(i)
       if (player:GetTeam() ~= EffectController():GetTeam()) then
          local filter = ClearFilter()
          filter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
          filter:Add( FE_CONTROLLER, OP_IS, player )
          local oppLand = filter:CountStopAt( myLand+1 )
          if oppLand  &gt; myLand then
             return true
          end
       end
    end
    return false
    </INTERVENING_IF>
    <MAY />
    <RESOLUTION_TIME_ACTION>
    local canBrowse = 0
    local filter = ClearFilter()
    filter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
    filter:Add( FE_CONTROLLER, OP_IS, EffectController() )
    local myLand = filter:Count()
    local numPlayer = MTG():GetNumberOfPlayers()
    for i = 0, (numPlayer-1) do
       local player = MTG():GetNthPlayer(i)
       if (player:GetTeam() ~= EffectController():GetTeam()) then
          local filter = ClearFilter()
          filter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
          filter:Add( FE_CONTROLLER, OP_IS, player )
          local oppLand = filter:CountStopAt( myLand+1 )
          if oppLand  &gt; myLand then
             canBrowse = 1
          end
       end
    end

    if canBrowse &gt; 0 then
       local filter = ClearFilter()
       local effectController = EffectController()
       filter:Add( FE_TYPE, OP_IS, CARD_TYPE_LAND )
       filter:Add( FE_SUPERTYPE, OP_IS, SUPERTYPE_BASIC )
       filter:SetZone( ZONE_LIBRARY, effectController )
       effectController:SetItemCount( 3 )
       for i = 0, (3-1) do
          effectController:SetItemPrompt(i, "CARD_QUERY_CHOOSE_LAND_TO_PUT_INTO_HAND" )
       end
       
       effectController:ChooseItems( EffectDC():Make_Targets(0), QUERY_FLAG_UP_TO )
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    for i = 0, 2 do
    local targetDC = EffectDC():Get_Targets(0)
       if targetDC ~= nil then
          local target = targetDC:Get_CardPtr(i)
          if  target ~= nil then
             target:Reveal()
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local targetDC = EffectDC():Get_Targets(0)
    if targetDC ~= nil then
        for i = 0, (2) do
           local card = targetDC:Get_CardPtr(i)
           if card ~= nil then
              card:PutInHand()
           end
        end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    EffectController():ShuffleLibrary()
    </RESOLUTION_TIME_ACTION>
  </TRIGGERED_ABILITY>
</CARD_V2>
thefiremind wrote:
Code: Select all
local filter = filter:AddFilter_Or()
This doesn't have much sense, first because you are re-using the filter variable for a sub-filter losing the possibility to address the main filter again if needed (you don't need it here, but bad habits should never be followed), and second because adding a sub-filter is useless here since you need to filter only enchantments.
And ENCHANTMENT isn't defined anywhere, it should be CARD_TYPE_ENCHANTMENT. If I were you, I would have copied the filter for enchantments from Auramancer... I never write a filter manually if there's an example to copy from an existing card, and being lazy isn't always bad... :mrgreen:
Yep I will pay more attention to existing codes and not try and come up with my own. But it just made logic to replace CREATURE WITH ENCHANTMENT. :mrgreen:

thefiremind wrote:Are you aware that all the functions and constants starting with "TFM_" depend on my LOL files? You need to keep at least DATA_DLC_TFM_OTHER installed for TFM_UntilMyNextTurn to work.
Yeah now it works but I could have sworn that I've already copied all of your functions in my function folder.

And now I have a problem with Prahv, Spires of Order , it won't let me activate the second ability.

Code: Select all
<ACTIVATED_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
   <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[{4}{W}{U} , {T}: Prevent all damage a source of your choice would deal this turn.]]></LOCALISED_TEXT>
   <COST mana_cost="{4}{W}{U}" type="Mana" />
   <COST type="TapSelf" />
    <TARGET tag="CARD_QUERY_CHOOSE_SOURCE_PREVENT_DAMAGE" definition="1" compartment="0" count="1" />
    <TARGET_DEFINITION id="1">
      local filter = ClearFilter()
      filter:SetFilterType( FILTER_TYPE_CARDS )
      filter:Add( FE_ZONE, OP_IS, ZONE_ANY)
    </TARGET_DEFINITION>
    <RESOLUTION_TIME_ACTION layer="6" mode="3">
      local target = EffectDC():Get_Targets(1):Get_CardPtr(0)
      if target ~= nil then
       local delayDC = EffectDC():Make_Chest(1)
       delayDC:Set_CardPtr(0, target)
       MTG():CreateDelayedTrigger(2, delayDC)
      end
    </RESOLUTION_TIME_ACTION>
    <DURATION simple_duration="UntilEOT" mode="3" />
  <TRIGGERED_ABILITY replacement_effect="1" resource_id="2">
    <TRIGGER value="SOURCE_DEALS_DAMAGE" pre_trigger="1">
      return TriggerObject() == EffectDC():Get_CardPtr(1)   
    </TRIGGER>
    <RESOLUTION_TIME_ACTION>
      if EffectController() ~= nil then
     EffectController(): Damage():PreventAll() )
      end
    </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
  </ACTIVATED_ABILITY>
User avatar
Master Necro
 
Posts: 259
Joined: 24 Apr 2013, 18:25
Has thanked: 83 times
Been thanked: 21 times

Re: Formal Request Thread

Postby Ratava » 24 Jul 2013, 07:14

jacque wrote:Wondering if someone could have these included in their cores?


- Wellwisher
- Momentous Fall
- Hero of Bladehold


Really appreciate it... Thanks!
hi
"Wellwisher" from Scion of Darkness data_dlc_cards_1404.wad viewtopic.php?f=109&t=10917

"Momentous Fall" "Hero of Bladehold" from sumomole DATA_DLC_DotP2013 viewtopic.php?f=109&t=11066
User avatar
Ratava
 
Posts: 79
Joined: 11 Jul 2013, 12:07
Location: Germany
Has thanked: 17 times
Been thanked: 7 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 12 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 12 users online :: 0 registered, 0 hidden and 12 guests (based on users active over the past 10 minutes)
Most users ever online was 7303 on 15 Jul 2025, 20:46

Users browsing this forum: No registered users and 12 guests

Login Form