[greatly improved/closed]AddCard error:No more room in cd

[HarlequinCasts]

Describe the Bug:
Only recently (OoAv1) noticed this error whenever I go a little too deep with storm and/or graveyard recursion with Past in Flames

Error screenshot attached. "AddCard error: No more room in cd to add card" followed by 4 or so memory location type errors I did not screen shot. I believe I was either finishing casting the rest of my Dark Rituals with Past in Flames, or I had just cast Infernal Tutor from the graveyard.

You can reproduce the error with the save game, but you'll need to go deep and storm into hellbent Infernal Tutor for Past in Flames etc etc.

Which card did behave improperly ?
Storm? Possibly Past in Flames

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
OoAv1

What exactly should be the correct behavior/interaction ?
No error

Are any other cards possibly affected by this bug ?
NA

[thanatos01]

I'm getting that error too, but in a dredge deck, so maybe there is something wrong with the memory that is tracking up information for this kind of combos.

[HarlequinCasts]

I'm getting that error too, but in a dredge deck, so maybe there is something wrong with the memory that is tracking up information for this kind of combos.

Yeah I've since seen this exact error in a bunch of situations, including a Small Pox deck that does a lot of land cycling and Life from the Loam ing. It seems like the commonality is just an excess of overly complicated turns with a lot of cards involved.

[Korath]

It's a 150 card per player limit, including cards in hand, cards on the stack, cards in play, effect cards in play, and effect cards on the stack. A new slot doesn't get used up when a card goes from in-hand to on-stack, or on-stack to in-play; but activating a permanent will use one, and so will all of the orange damage and effect cards that attach to permanents.

Most of the problem is that, even when a card or effect is destroyed, its slot isn't available for reuse immediately. This is generally a good thing; it means we don't have to constantly worry about whether the card we're writing data to has been destroyed and is now being used for an entirely different card. Slots only get recycled at the start of each turn. (A card's marked as no-longer-in-use by setting internal_card_id to -1; the slot's marked as reusable by setting original_internal_card_id to -1. The former happens whenever a card leaves play; the latter only in sub_479840(), which is called only by sub_43A370() "Entering Init Turn". The purpose of sub_437400(), which is only called immediately after sub_479840(), is less clear; it may or may not be related.)

There isn't going to be anything we'll be able to do about a battlefield with 30 Bridge from Below zombies each with four Flame-Kin Zealot effect cards attached. Increasing the limit's a major, major undertaking; not as big as the 2000-card limit, but of the same order of magnitude.

We may be able to cut down on the number of cards created, though.

One extreme way would be to only ever have one "This card gets +x/-y and gains a,b,c abilities and loses d,e,f abilites until end of turn" effect card attached to a given permanent. That'd lose genuinely useful data, though - you'd just see that your zombie token has +4/+4 and haste until end of turn from something, not that it's from four FKZs entering the battlefield.

I strongly suspect a significant chunk is checking whether cards in your graveyard could be activated - every time each needs to be checked, the Rules Engine card creates the card, sends it an EVENT_GRAVEYARD_ABILITY, and obliterates it. Since the Rules Engine stops checking as soon as it finds an activateable card (unless you click Rules Engine for a menu), it's not surprising that we're getting more AddCard errors in OoA - this is the first version where sorceries are illegal to flashback except at sorcery speed.

You can generate AddCard errors pretty much at will by putting a handful of flashback cards in your graveyard, getting enough mana so they all appear on the Rules Engine menu, and then clicking on Rules Engine and cancelling a couple times. Ten copies of Chainer's Edict in my graveyard with available and an otherwise empty battlefield is enough that I can't click Rules Engine and cancel four times, nor get all the way through an AI turn. It's... probably... safe to immediately flag the temporary card as reusable instead of just obliterating it normally, which fixes the AddCard errors from this.

Calling sub_479840() more often - say, at the end of each phase, or whenever the stack becomes empty - may or may not be helpful, and may or may not be practical.

First step should probably be to put some logging into our wrapper for add_card_to_hand() to see what's calling it the most, at least from C.

[Aswan jaguar]

increasing the limit's a major, major undertaking; not as big as the 2000-card limit, but of the same order of magnitude.

I am afraid that this solution (the best obviously)is totally up to you and Gargaroz (and to any other coder may pop up-not very likely.The rest of us helped Mok and Gargaroz to break the 2000-limit,(Snacko also was there to contribute with best coding practices) helping to make a new csv and any non coding stuff we were asked but I don't see how we could be of any help with this,unfortunately.

I have seen a lot of those errors "AddCard error: No more room in cd to add card" over the years ,more frequently with new patch.There was 1 case that was very strange as it was on the beginning of the game and AI and me had not played anything but 1 land only or something like that and graveyards were empty,too.If I have something like that again I will try to save or take a screenshot.

EDIT:

this is the first version where sorceries are illegal to flashback except at sorcery speed.

If it comes to cutting down, I don't mind not checking if sorceries are illegal to flashback except at sorcery speed.For human you control to cheat or not as for AI I don't mind if AI will benefit from cheating.

[RanDomino]

(words)

I love you.

[Korath]

Graveyard abilities release their slot as of 20cb7bb, so the situation should be improved next patch.

[BAgate]

New patch has been released, so anyone have any new info?