[fixed/clo]Torrent of Souls & others don't fetch bottom card

[Aswan jaguar]

Describe the Bug:
Cinder ElementalLast card on gy doesn't return if chosen by Torrent of Souls from graveyard or by Reviving Melody. edited

Which card did behave improperly ?
Cinder ElementalTorrent of Souls,Reviving Melody. edited


Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Manalink 2015/3/25: Fate Reforged,duel

What exactly should be the correct behavior/interaction ?
Cinder Elemental
Torrent of Souls,Reviving Melody can fetch last card in gy. edited

Are any other cards possibly affected by this bug ?
-

Savagame same as Torrent of Souls report one.

[BAgate]

Both Torrent of Souls and Reviving Melody worked on Cinder Elemental in a clean game.

[Aswan jaguar]

I did some more testing and like another report we had some timeago with fetch from gy,the problem is that if the creature card you want to fetch is the last card in the gy it wont be fetched.
Please recheck targeting a creature that is the last card on gy.

EDIT: also this bug corrupts for some reason all my savegames

[BAgate]

I can confirm this. But do we want a separate post for it, or should we just amend the prior one to indicate more cards affected?

[Aswan jaguar]

Since no developer can tell us how he likes it,and there is a huge possibility that a global fix won't fix this (as some cards do work correctly and can fetch the last card),I suppose the best way to go is to do separate posts.
I will change the title to correct bug.

[Korath]

"Last card on gy" is unusably vague. It can be validly intepreted as

1. the only card in the graveyard (i.e., the last card left)
2. the top card in the graveyard (the card most recently put there)
3. the bottom card in the graveyard (the card least recently put there)

not to mention variants of A, B, and C where it's the last creature card (or whatever card type the spell is looking for).

The least likely interpretation, C (absolute bottom card in the graveyard) is the only one I can confirm at a glance. Fixed for Reviving Melody, Remember the Fallen, and Grim Discovery in 38cdd37. Also fixed an identical bug in All Suns' Dawn (2fcb8e7) and crash bugs with the same root cause in Empty the Pits (73b6561) and Petrified Field (61a22d8). Commit 9dd39a4 from the Remember the Fallen report actually made things worse; it checked whether an optional position hint was set (and so sometimes caused additional improper failures) and didn't do anything to fix the underlying bug.

Torrent of Souls calls a different function with a similar interface and makes the same error, so there'll be more to come. This stuff is cut and pasted everywhere instead of being done just once, so I'm still looking.

---

Mardu Woe-Reaper: 41cde3f
Ghoulcaller's Chant: d77b598
Endless Obedience: 36152dc
Haunted Crossroads: 99e127a
Salvage Scout: 6b5e5ad
Torrent of Souls: ee6ce2c

The other 317 calls seem ok. Obviously I didn't look very closely at any of them individually. Was this reported for any other cards?

[Aswan jaguar]

Skaab Ruinator maybe has the same underlying problem:
viewtopic.php?f=86&t=16411&p=169679&hilit=doesn%27t+return+graveyard#p169679
Maybe this one for Life from the Loam :
viewtopic.php?f=86&t=15354&p=160886&hilit=doesn%27t+return+graveyard#p160886
I haven't test them if you like me to say so.

[Korath]

Skaab Ruinator is unrelated. I expect it fails iff any of the removed creatures were below it in the graveyard, since it doesn't make any attempt to track its own changed position. The rules engine card is an enormous ball of mud; I'm not about to try to sort through it. (Not even after seeing an internal function named "gather_body_parts()", which made my day.)

I'll investigate Life from the Loam.