Pull Requests: Big or small?

by **Poddo** » 06 Dec 2015, 08:25

Hello,

I'm planning on implementing some cards that are missing, to get familiar with the project. Do you prefer larger pull requests with several cards, or one per card? Are there preferred naming schemes (et cetera) for requests/patches?

by **LevelX** » 06 Dec 2015, 08:45

Hi Poddo,

you can do pull requests with multiple cards, no problem.
There is no fixed naming rules for pull requests/commits. Maybe look at existing commits naming and do it likewise.

by **Poddo** » 06 Dec 2015, 08:57

Thanks!

I'm a little new to using git in netbeans, as well.

I have a fork of the repo through the web UI. Should netbeans be connecting to my fork, and then I can create pull requests through that? Or is there a way to connect the 2 in netbeans?

by **Poddo** » 06 Dec 2015, 09:41

I changed netbeans to look at my fork instead, ( github com/ Poddo/mage) but now I can't figure out how to get netbeans to fetch the upstream version so I can sync my fork which is 9 commits behind.

I found team>remote>fetch from upstream and team>remote>pull from upstream but all I get is:

Code: Select all: git fetch poddo@github com/Poddo/mage.git +refs/heads/*:refs/remotes/origin/* No update ==[IDE]== Dec 6, 2015 3:34:43 AM Pulling - mage cancelled.

Sorry if this is basic git stuff!

(URLS look funky to bypass the URL spam filter.. sorry)

by **Poddo** » 06 Dec 2015, 18:36

Never mind, I figured it out! Commence the contributing!