Unable to work on newest build - various issues clone repo

by **escplan9** » 01 Mar 2016, 17:09

I was trying to fix up the Dread Cacodemon card I was working on and brought in the latest changes but have not been able to successfully rebuild the projects yet. I even created a whole new local directory to clone the repository to to make sure I had a completely clean version to see if that worked. It starts as usual, but when trying to build Mage Root with dependencies, you get an error regarding CastFromHandCondition . There's a conditional statement on there missing a ')' . Don't know if it's just me seeing these issues with the latest changes. Easy enough to fix anyways.

Code: Select all: (watcher != null && watcher.spellWasCastFromHand(source.getSourceId())

is the line missing the ) at the end.

edit: details and see further comments for other issues

by **escplan9** » 01 Mar 2016, 17:19

Other issues with starting fresh with cloning from the repository:

Failed tests:
testEpochrasite(org.mage.test.cards.abilities.keywords.SuspendTest): No such ability=haste, player=PlayerA, cardNameEpochrasite

testScionOfVituGhaziConditionNotTrue(org.mage.test.cards.triggers.EntersTheBattlefieldTriggerTest): (Battlefield) Permanents counts for PlayerA are not equal (Bird) expected:<2> but was:<0>

The Scion of VituGhazi one failing is a bad sign... is something wrong with the current build?

Unable to complete the Build with Dependencies on Mage Root at the moment due to these tests failing: "Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.10:test (default-test) on project mage-tests: There are test failures."

by **escplan9** » 01 Mar 2016, 17:30

errors in mage.server.user.java:

Code: Select all: public static String userStatsToHistory(ResultProtos.UserStatsProto proto)

UserStatsProto symbol cannot be found.

Code: Select all: userData.setMatchHistory(userStatsToMatchHistory(userStats.getProto()));

The type of getProto is erroneous.

Similar errors across the file as well.

errors in mage.server.user.usermanager.java:

Similar issues with UserStatsProto across the file.

errors in mage.server.record...
Various files, all related to issues with TableProto being unrecognized.

by **escplan9** » 01 Mar 2016, 18:11

Let me know when these are patched up and in the master branch so I can try starting with a fresh clone of the repository again.

edit: or what I could possibly be doing wrong when following the guide to clone the repo for a fresh copy again.

by **LevelX** » 01 Mar 2016, 20:40

Errors should be fixed now.

Only about the problems with the server project I couldn't reproduce.
Maybe you "clean and build" the complete projects again and check if you still get any problems.

by **escplan9** » 01 Mar 2016, 22:29

All good now. Thanks. You the man!