Forge Android App: 11-13-2016 Alpha 1.5.58.002
by mtgrares
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Forge Android App: 10-17-2014 Alpha 1.5.29.008
by drdev » 18 Oct 2014, 02:57
jureidinim wrote:I noticed that in an earlier version (.005?) when the AI (I think its the Harry Potter AI quest deck) tried to activate Keening Stone on me which would have wiped my library. Game crashed as well. Haven't seen it since though to see if it happens again.Caostotal wrote:I'm playing a mono blue Mill stone's deck.
Everytime I cast any spell that discard the last cards of library the game crashes.
triskelion wrote:Another problem I just had with clever impersonator. My commander deck used damia (B U G), and my opponent Animar (R U G). He had out the red praetor, urabrask the hidden. I made a copy of it, but it immediately died. Since it's not against the rules to make copies of things not of your color, I'm guessing it's somewhere in the card text that lets this happen?
EDIT my opponent immediately after on his turn played phyrexian metamorph, another clone spell. It died immediately and I couldn't even see what he tried to copy.
I just released 1.5.29.008, which fixes these issues. It also fixes an issue where you could continue to view cards in hidden zones after an effect had temporarily revealed those cards to you (such as searching your library or picking a card from your opponent's hand for discard). Lastly, it removes the ability to see card IDs for cards in hidden zones so you can't jot them down when they're revealed temporarily in order to determine what they are after they're hidden again.5enza wrote:Not sure if this is related to the other land related issues people are having but I am receiving the wrong card art for basic lands when they are scryed.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge Android App: 10-17-2014 Alpha 1.5.29.008
by Caostotal » 18 Oct 2014, 06:58
It works for me, thank you for your work
Re: Forge Android App: 10-16-2014 Alpha 1.5.29.007
by Flameustc » 18 Oct 2014, 10:38
I'm not very sure what I did, and I can't repro the bug either.
So following description may be somehow misleading, sorry for that.
According to my memory, I did following 4 things at least:
1. create a new commander deck
2. type some text in the search box
3. change filter conditions "show only unique cards" true->false
4. tap the search box again
The application crashed just after 4.
So following description may be somehow misleading, sorry for that.
According to my memory, I did following 4 things at least:
1. create a new commander deck
2. type some text in the search box
3. change filter conditions "show only unique cards" true->false
4. tap the search box again
The application crashed just after 4.
drdev wrote:Could you provide more detail about exactly what you were you doing when this happened? I'm not able to reproduce by just creating a new commander deck.Flameustc wrote:Crash when I creating a commander deck.
- ConcurrentModificationException | Open
- Code: Select all
Forge Version: 1.5.29.007
Operating System: Linux 3.10.30-00049-g3d2aa89 armv7l
Java Version: 0 The Android Project
java.util.ConcurrentModificationException
at java.util.LinkedHashMap$LinkedHashIterator.nextEntry(LinkedHashMap.java:347)
at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:376)
at java.util.LinkedHashMap$EntryIterator.next(LinkedHashMap.java:374)
at forge.itemmanager.ItemManagerModel.rebuildOrderedList(ItemManagerModel.java:86)
at forge.itemmanager.ItemManagerModel.getOrderedList(ItemManagerModel.java:78)
at forge.itemmanager.ItemManagerModel.refreshSort(ItemManagerModel.java:176)
at forge.itemmanager.views.ItemView.refresh(ItemView.java:138)
at forge.itemmanager.ItemManager.updateView(ItemManager.java:891)
at forge.itemmanager.ItemManager$4.run(ItemManager.java:801)
at java.lang.Thread.run(Thread.java:841)
Re: Forge Android App: 10-17-2014 Alpha 1.5.29.008
by krishkrush » 18 Oct 2014, 19:20
Since 07 and also in 08 I have very long loading times at startup. It takes up to 5 Minutes for the loading of the cards to finish. It stops at 100% for that time span. Everything else loads at normal speed. Never had this problem before. Reinstalling including deleting all files except pics, decks and saves doesn't help.
- krishkrush
- Posts: 89
- Joined: 13 Oct 2012, 14:18
- Has thanked: 30 times
- Been thanked: 2 times
Re: Forge Android App: 10-17-2014 Alpha 1.5.29.008
by drdev » 18 Oct 2014, 19:33
Out of curiousity, have you downloaded any card images? .007 added a new check to try to find versions of cards that you have the image for, but if you haven't downloaded any images, this check might result in a performance hit on startup as it trys to find a file for every version of every card it loads.krishkrush wrote:Since 07 and also in 08 I have very long loading times at startup. It takes up to 5 Minutes for the loading of the cards to finish. It stops at 100% for that time span. Everything else loads at normal speed. Never had this problem before. Reinstalling including deleting all files except pics, decks and saves doesn't help.
Either way, I'll see if I can optimize this check a bit to improve performance, and maybe add a simple check for whether any card images have been downloaded, avoiding subsequent checks if so.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by drdev » 19 Oct 2014, 01:01
I just released 1.5.29.009, which should improve the startup performance for determining what card editions have images. In addition, it includes the following bug fixes:
EDIT: Please delay taking this update, as I just learned it's broken due to a class that wasn't loaded properly. I'll release a fixed version shortly.
EDIT2: I just released 1.5.29.010 which should fix things.
- Fix so planeswalkers appear with proper base loyalty even when not in play
- Fix so both sides of split card have text displayed when card not on stack
- Fix so only the cast half of a split card has its mana cost displayed when it's on the stack
- Fix concurrent modification exception with Chromatic Lantern
- Fix so cards like Courser of Kruphix allow viewing the top card or your library
- Fix so Prossh, Skyraider of Kher properly has tokens come into play
- Fix so AI respects Annihilator amount
- Fix token doubling effects, like Doubling Season
EDIT: Please delay taking this update, as I just learned it's broken due to a class that wasn't loaded properly. I'll release a fixed version shortly.
EDIT2: I just released 1.5.29.010 which should fix things.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by Krunk42 » 19 Oct 2014, 04:10
Waiting for the end of opponent main phase 1, it wasn't moving so I tried to cancel
- ConcurrentModificationException | Open
- Code: Select all
Forge Version: 1.5.29.006
Operating System: Linux 3.4.0-722276 armv7l
Java Version: 0 The Android Project
java.util.ConcurrentModificationException
at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)
at forge.game.GameAction.checkStaticAbilities(GameAction.java:613)
at forge.game.GameAction.checkStateEffects(GameAction.java:669)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:871)
at forge.game.GameAction.startGame(GameAction.java:1358)
at forge.game.Match.startGame(Match.java:71)
at forge.match.MatchUtil$2.run(MatchUtil.java:200)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
- Krunk42
- Posts: 8
- Joined: 14 Oct 2014, 20:50
- Has thanked: 0 time
- Been thanked: 0 time
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by Agetian » 19 Oct 2014, 04:45
I finally decided to update to 1.5.29 (.010 in this case) on my tablets. For now, updated on my old Galaxy Tab 2 running Android 4.2. I'm not sure if this is normal or not, but the gameplay in this new version is considerably slower than the old 1.5.28 version that was installed before (probably not normal because so much was supposed to be optimized AFAIK). Anyhoo, I only have one Mountain on the battlefield and the game goes through phases (even typical "no action" phases, like EC etc.), like, at least 3x-4x slower than it used to in the old 1.5.28.something build that was installed previously (whichever was the last stable build from the pre-refactoring time). Though I'd report it here... Next I'll try it on a much more powerful device and will report on how things go there.
EDIT: Tried the 1.5.29.010 build on my Samsung Galaxy Tab Pro 2014 with Android 4.4.2. Works much better and smoother on it, I don't think any significant extraordinary slowdown is noticeable on it, the game is fast and playable, so I think the slowdown mostly affects older hardware (perhaps more noticeable on older CPUs?)
- Agetian
EDIT: Tried the 1.5.29.010 build on my Samsung Galaxy Tab Pro 2014 with Android 4.4.2. Works much better and smoother on it, I don't think any significant extraordinary slowdown is noticeable on it, the game is fast and playable, so I think the slowdown mostly affects older hardware (perhaps more noticeable on older CPUs?)
- Agetian
- Agetian
- Programmer
- Posts: 3472
- Joined: 14 Mar 2011, 05:58
- Has thanked: 677 times
- Been thanked: 561 times
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by krishkrush » 19 Oct 2014, 18:25
Yes I do have images on my device. But your last update fixed the issue. Good work! Thank you very much.
- krishkrush
- Posts: 89
- Joined: 13 Oct 2012, 14:18
- Has thanked: 30 times
- Been thanked: 2 times
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by drdev » 19 Oct 2014, 19:31
I think I'm going to look into reducing how often state-based effects are checked. Hopefully that should improve performance of transition between phases significantly.Agetian wrote:I finally decided to update to 1.5.29 (.010 in this case) on my tablets. For now, updated on my old Galaxy Tab 2 running Android 4.2. I'm not sure if this is normal or not, but the gameplay in this new version is considerably slower than the old 1.5.28 version that was installed before (probably not normal because so much was supposed to be optimized AFAIK). Anyhoo, I only have one Mountain on the battlefield and the game goes through phases (even typical "no action" phases, like EC etc.), like, at least 3x-4x slower than it used to in the old 1.5.28.something build that was installed previously (whichever was the last stable build from the pre-refactoring time). Though I'd report it here... Next I'll try it on a much more powerful device and will report on how things go there.
EDIT: Tried the 1.5.29.010 build on my Samsung Galaxy Tab Pro 2014 with Android 4.4.2. Works much better and smoother on it, I don't think any significant extraordinary slowdown is noticeable on it, the game is fast and playable, so I think the slowdown mostly affects older hardware (perhaps more noticeable on older CPUs?)
- Agetian
The reason you might be seeing it as being a bit slower is that you upgraded a version that was before elcnesh did the initial refactoring to create the CardView and other *View classes. Although my refactoring optimized what he did, it's still might be ultimately a bit slower than before his work was done, because we're still needing to spend processing power creating and updating the *View objects.
This is going to be a necessary evil in the end in order to support network play, but I'm still hoping to find opportunities to improve performance in other areas, like state-based effects as mentioned.
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by Flameustc » 20 Oct 2014, 14:43
Description: [Cast Control Magic on Captain Sisay (AI's commander) with Fleetfeather Sandals equipped]
- NotImplementedException | Open
- Code: Select all
Forge Version: 1.5.29.010
Operating System: Linux 3.10.30-00049-g3d2aa89 armv7l
Java Version: 0 The Android Project
org.apache.commons.lang3.NotImplementedException: Not implemented
at forge.game.player.PlayerView.getCommanderInfo(PlayerView.java:133)
at forge.screens.match.views.VPlayers$PlayerInfoPanel.drawBackground(VPlayers.java:92)
at forge.toolbox.FContainer.draw(FContainer.java:44)
at forge.Graphics.draw(Graphics.java:144)
at forge.toolbox.FContainer.draw(FContainer.java:59)
at forge.toolbox.FScrollPane.draw(FScrollPane.java:308)
at forge.Graphics.draw(Graphics.java:144)
at forge.toolbox.FContainer.draw(FContainer.java:59)
at forge.Forge.render(Forge.java:241)
at com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame(AndroidGraphics.java:414)
at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1532)
at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1249)
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by triskelion » 20 Oct 2014, 21:48
I played Enchantress's presence, then this
Description: [describe what you were doing when the crash occurred]
Description: [describe what you were doing when the crash occurred]
- RuntimeException | Open
- Code: Select all
Forge Version: 1.5.29.010
Operating System: Linux 3.4.0-660648 armv7l
Java Version: 0 The Android Project
java.lang.RuntimeException: Cannot remove input InputPayManaOfCostPayment because it's not on top of stack. Stack = []
at forge.match.input.InputQueue.removeInput(InputQueue.java:59)
at forge.match.input.InputSyncronizedBase.stop(InputSyncronizedBase.java:49)
at forge.match.input.InputPayMana.onStateChanged(InputPayMana.java:415)
at forge.match.input.InputPayMana$3.run(InputPayMana.java:368)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
- triskelion
- Posts: 44
- Joined: 24 Jul 2014, 05:35
- Has thanked: 3 times
- Been thanked: 0 time
Re: Forge Android App: 10-18-2014 Alpha 1.5.29.010
by Krunk42 » 20 Oct 2014, 22:25
AI opponent took control of my creature with an enchantment, creature p/t set by number of swamps which AI had none.
Description: [describe what you were doing when the crash occurred]
Description: [describe what you were doing when the crash occurred]
- ConcurrentModificationException | Open
- Code: Select all
Forge Version: 1.5.29.010
Operating System: Linux 3.4.0-722276 armv7l
Java Version: 0 The Android Project
java.util.ConcurrentModificationException
at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)
at forge.game.GameAction.checkStaticAbilities(GameAction.java:613)
at forge.game.GameAction.checkStateEffects(GameAction.java:669)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:871)
at forge.game.GameAction.startGame(GameAction.java:1358)
at forge.game.Match.startGame(Match.java:71)
at forge.match.MatchUtil$2.run(MatchUtil.java:200)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
- Krunk42
- Posts: 8
- Joined: 14 Oct 2014, 20:50
- Has thanked: 0 time
- Been thanked: 0 time
Re: Forge Android App: 10-20-2014 Alpha 1.5.29.011
by drdev » 21 Oct 2014, 02:31
Krunk42 wrote:Waiting for the end of opponent main phase 1, it wasn't moving so I tried to cancel
- ConcurrentModificationException | Open
- Code: Select all
Forge Version: 1.5.29.006
Operating System: Linux 3.4.0-722276 armv7l
Java Version: 0 The Android Project
java.util.ConcurrentModificationException
at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)
at forge.game.GameAction.checkStaticAbilities(GameAction.java:613)
at forge.game.GameAction.checkStateEffects(GameAction.java:669)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:871)
at forge.game.GameAction.startGame(GameAction.java:1358)
at forge.game.Match.startGame(Match.java:71)
at forge.match.MatchUtil$2.run(MatchUtil.java:200)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
Flameustc wrote:Description: [Cast Control Magic on Captain Sisay (AI's commander) with Fleetfeather Sandals equipped]
- NotImplementedException | Open
- Code: Select all
Forge Version: 1.5.29.010
Operating System: Linux 3.10.30-00049-g3d2aa89 armv7l
Java Version: 0 The Android Project
org.apache.commons.lang3.NotImplementedException: Not implemented
at forge.game.player.PlayerView.getCommanderInfo(PlayerView.java:133)
at forge.screens.match.views.VPlayers$PlayerInfoPanel.drawBackground(VPlayers.java:92)
at forge.toolbox.FContainer.draw(FContainer.java:44)
at forge.Graphics.draw(Graphics.java:144)
at forge.toolbox.FContainer.draw(FContainer.java:59)
at forge.toolbox.FScrollPane.draw(FScrollPane.java:308)
at forge.Graphics.draw(Graphics.java:144)
at forge.toolbox.FContainer.draw(FContainer.java:59)
at forge.Forge.render(Forge.java:241)
at com.badlogic.gdx.backends.android.AndroidGraphics.onDrawFrame(AndroidGraphics.java:414)
at android.opengl.GLSurfaceView$GLThread.guardedRun(GLSurfaceView.java:1532)
at android.opengl.GLSurfaceView$GLThread.run(GLSurfaceView.java:1249)
I just released 1.5.29.011, which should fix these issues. It also includes the following fixes:Krunk42 wrote:AI opponent took control of my creature with an enchantment, creature p/t set by number of swamps which AI had none.
Description: [describe what you were doing when the crash occurred]
- ConcurrentModificationException | Open
- Code: Select all
Forge Version: 1.5.29.010
Operating System: Linux 3.4.0-722276 armv7l
Java Version: 0 The Android Project
java.util.ConcurrentModificationException
at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)
at forge.game.GameAction.checkStaticAbilities(GameAction.java:613)
at forge.game.GameAction.checkStateEffects(GameAction.java:669)
at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:871)
at forge.game.GameAction.startGame(GameAction.java:1358)
at forge.game.Match.startGame(Match.java:71)
at forge.match.MatchUtil$2.run(MatchUtil.java:200)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
at java.lang.Thread.run(Thread.java:841)
- Fix display of fake cards, such as for pile choose effects like Fact or Fiction
- Fix so tokens have name displayed in detail view
- Fix player name in message for Vendilion Clique
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Forge Android App: 10-20-2014 Alpha 1.5.29.011
by beank » 22 Oct 2014, 04:45
Couple of things after updating to .11
1. Marath, Will of the Wild dies instantly after casting.... other cards with 0/0 that enter with counters work properly.....
2. I can see my opponents hand as well as both libraries even with Developer mode off....
1. Marath, Will of the Wild dies instantly after casting.... other cards with 0/0 that enter with counters work properly.....
2. I can see my opponents hand as well as both libraries even with Developer mode off....
- beank
- Posts: 6
- Joined: 02 Oct 2014, 02:05
- Has thanked: 0 time
- Been thanked: 0 time
Who is online
Users browsing this forum: No registered users and 167 guests