HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2018/01/29)
by Nate and Snacko
Moderators: Snacko, CCGHQ Admins
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 31 Jan 2016, 22:07
For the reminder text, I could probably do something like
- Code: Select all
if ($card->flavor != '') preg_replace('/#(\(.*?\))#/su', '', $card->legal)
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 31 Jan 2016, 22:22
Cool but not realy usefull because lots of modern extension have reminder for one or two rules + flavor, so it's needing a card by extension method ^^ (but it's not a obligation, it's a proposition)
Or better, an adjustable font size detection > if card text font size < xx then remove reminder ^^, i think it's not too hard to code and automatise the process for anyone text size taste (and set the adjustable font size with an option in the config file, would be great !)
thanks
Or better, an adjustable font size detection > if card text font size < xx then remove reminder ^^, i think it's not too hard to code and automatise the process for anyone text size taste (and set the adjustable font size with an option in the config file, would be great !)
thanks
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 31 Jan 2016, 23:06
Font size is already adjustable in config-* under font.*
I can look into something that removes reminder text is the font size is greater than a certain number.
I can look into something that removes reminder text is the font size is greater than a certain number.
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 31 Jan 2016, 23:20
Yes but i wanted to say "if font size is smaller than value x then remove reminder" so it can heavily limit the impact of too small text if reminder is present.ahkren wrote:Font size is already adjustable in config-* under font.*
You wanted to say "the font size isahkren wrote:I can look into something that removes reminder text is the font size is greater than a certain number.
Thanks for looking about it, and for your great works, it's realy starting to looks great on most of the cards
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by Tons » 01 Feb 2016, 23:08
Hi again. Akhren, the images of the new eldrazis are superb, but, it would be possible a little more transparency at the text box (looking for perfection!)?
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 02 Feb 2016, 02:54
I'll see what I can do to get the transparency more in line with the originals.
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 02 Feb 2016, 10:13
Hello i've done a summary of the difference between the preheight extension (so if there is a way to adapt the renderer, only if it's not need big amount of works because it's only fine tuning ^^).
I only reported difference between real card and the actual generator.
Cards with grey font title/type/artist + bigger text + centered text if not much text (even in multiline) + no date + no copyright + no card number + left ajusted artist:
Alpha
Beta
Unlimited
Arabian Nights
Antiquities
Revised
Cards with bigger text + centered text if not much text (even in multiline) + no date + no copyright + no card number + left ajusted artist:
Legends
The Dark
Cards with centered text if not much text (even in multiline) + no card number + left ajusted artist:
Fourth Edition
Fallen Empires
Cards with no card number + left ajusted artist:
Homelands
Ice Age
Alliances
Mirage
Fifth Edition
Mirage
Fifth Edition
Visions
Weatherlight
Tempest
Stronghold
Bold text + flavor separator + no card number + left ajusted artist:
Portal
Portal Second Age
Portal Three Kingdoms
And by the way a last bug a found in the machination title, it's too width
I think so far (i the differents post i writed) i reported to you all the limitations / bug / suggestion i found, so if you need betatesting feel free to ask ^^
Thanks
I only reported difference between real card and the actual generator.
Cards with grey font title/type/artist + bigger text + centered text if not much text (even in multiline) + no date + no copyright + no card number + left ajusted artist:
Alpha
Beta
Unlimited
Arabian Nights
Antiquities
Revised
Cards with bigger text + centered text if not much text (even in multiline) + no date + no copyright + no card number + left ajusted artist:
Legends
The Dark
Cards with centered text if not much text (even in multiline) + no card number + left ajusted artist:
Fourth Edition
Fallen Empires
Cards with no card number + left ajusted artist:
Homelands
Ice Age
Alliances
Mirage
Fifth Edition
Mirage
Fifth Edition
Visions
Weatherlight
Tempest
Stronghold
Bold text + flavor separator + no card number + left ajusted artist:
Portal
Portal Second Age
Portal Three Kingdoms
And by the way a last bug a found in the machination title, it's too width
I think so far (i the differents post i writed) i reported to you all the limitations / bug / suggestion i found, so if you need betatesting feel free to ask ^^
Thanks
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 02 Feb 2016, 14:03
I've done a more acurate Conspiracy frame (i think):
>render exemple (need some tweaking in cns logo but not bad i think):
>render exemple (need some tweaking in cns logo but not bad i think):
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by rodolmedo » 02 Feb 2016, 15:04
hello, the black part in this card should be red, how can i fix it?
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 02 Feb 2016, 15:57
In \data\titleToLandColors.csv
replace line "Swiftwater Cliffs,UB" with "Swiftwater Cliffs,UR" (line 510)
replace line "Swiftwater Cliffs,UB" with "Swiftwater Cliffs,UR" (line 510)
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 02 Feb 2016, 16:12
Found a bug with Garruk, Apex Predator
The m15 version is ok but the cvp isn't
m15:
cvp:
Also the DKA transform card text is too big:
Seems the DTK text font too (maybe is it a M15 render issue witch doesn't set a max text font size ?)
The m15 version is ok but the cvp isn't
m15:
cvp:
Also the DKA transform card text is too big:
Seems the DTK text font too (maybe is it a M15 render issue witch doesn't set a max text font size ?)
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 02 Feb 2016, 19:16
I've added your Conspiracy frame, looks much better than the mock up that I had.
Changed 'Swiftwater Cliffs' to UR in titleToLandColors
I'm looking into Garruk's CVP version
I'll see what I can do about the text size.
Changed 'Swiftwater Cliffs' to UR in titleToLandColors
I'm looking into Garruk's CVP version
I'll see what I can do about the text size.
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by satsuki » 02 Feb 2016, 19:41
Thanks a lot
ps: have you found a way to add and option to disable reminder if card text is too small or will it be to much works.
ps: have you found a way to add and option to disable reminder if card text is too small or will it be to much works.
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 02 Feb 2016, 19:42
Ok, found the problem with Garruk.
ImageWriter.php line 174 change
ImageWriter.php line 174 change
- Code: Select all
else if(array_key_exists(strtolower($card->title), $this->titleToPlaneswalker4) && $this->setDB->isM15($card->set) && $config['render.planeswalker'] && $config['render.m15']) {
- Code: Select all
else if(array_key_exists(strtolower($card->title), $this->titleToPlaneswalker4) && $this->setDB->isM15($card->getDisplaySet()) && $config['render.planeswalker'] && $config['render.m15']) {
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Re: HQ Cardgen M15/8th/Pre8th/Tokens (Updated 2016/01/30)
by ahkren » 02 Feb 2016, 19:59
Scheme title length fix
SchemeRenderer.php line 59 change from
SchemeRenderer.php line 59 change from
- Code: Select all
$this->drawText($canvas, $settings['title.x'], $settings['title.y'], null, $card->getDisplayTitle(), $this->font("title$languageFont"));
- Code: Select all
$this->drawText($canvas, $settings['title.x'], $settings['title.y'], 518, $card->getDisplayTitle(), $this->font("title$languageFont"));
-
ahkren - Programmer
- Posts: 316
- Joined: 18 Jan 2012, 20:43
- Has thanked: 50 times
- Been thanked: 201 times
Who is online
Users browsing this forum: No registered users and 20 guests