Page 18 of 25

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 14 Oct 2016, 20:57
by ahkren
I've corrected the vehicle PT box. Noticed that today.
Some of the frames are older renders, at some point I'm going to have to re-render all the frames so that they all match up.
Just corrected the Conspiracy PT boxes. I'll have the Timeshifted ones fixed soon.
I'll have to see what they do in the next block with the Masterpieces. It is possible that new frames and directories will have to be added for each block.
I'll look into the coloring, see if I can get the green to be closer to accurate.

I'd be happy for any assistance you can offer. Shoot me a PM and we'll figure something out.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 15 Oct 2016, 23:19
by eddrix
Hey this program is really awesome. One minor issue I've noticed is modal cards don't format quite right. The spacing between the choose and each option should be single spaced rather than the 1.5 or so that is the default after newlines and for lines that wrap, the second and beyond lines should be indented past the bullet to the same justification as the first letter of the first line. See Modern Masters 15 Cryptic Command for an example.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 16 Oct 2016, 08:29
by simisays
I'm creating cards from Vintage Masters and Tempest Remastered to use them in "Forge". However the created images' borders are smaller than the XLHQ cards in forge. Any way to make the border langer without messing up the generator?

It should look like this
Border.jpg


Thanks

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 17 Oct 2016, 19:36
by ahkren
Right now I don't have anything set up for the full borders. I'm looking into remaking all the frames as full bordered cards, but that's a ways out yet.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 12 Nov 2016, 13:54
by Tirsh
Hello,

First, thanks for the good work !

I am getting this error when generating :

Code: Select all
ERROR : Story Spotlight image not found for:
and PHP crashing.

Any ideas ? Seems to happen only with recent cards

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 23 Nov 2016, 04:57
by charlequin
I've been giving this a shot and I'm seeing a consistent issue where spacing in costs is incorrect -- commas and colons, especially, will have huge spaces after them that don't match up to printed text. For example:
Adun Oakenshield.full.jpg

Any thoughts on why this happens? I know I've seen several other people encounter the same issue.

EDIT: It looks like this is actually the result of two unrelated issues in the renderer.

First, there's one at the word splitting level. The renderer takes text and splits it into "chunks" that it assembles back together to fit within the designated space. Right now, that splitter is returning chunks whose whole contents is a single space in certain cases, in particular after a comma before a tap symbol. Adding text to Renderer.php after line 160 to skip over these extra space characters fixes the first gap:

Code: Select all
      $belowBaseline = 0;
      for ($i=0, $n=count($chunks); $i < $n; $i++) {
         $chunk = $chunks[$i];
         if ($chunk->value == " ") continue;[/b] // <---- ADD THIS LINE
The second is at the word recombining level. When the strings are put back together, the renderer makes sure spaces are inserted where necessary to join up the pieces. However, the way it is right now, it's putting two spaces after each colon, rather than just the one it should. This can be fixed with a change to line 269 (previously 268 before the other change):

Code: Select all
               if ($word == null || $word == '') continue;
               $testLine = $text;
               if ($text != '') $testLine = rtrim($testLine) . ' '; // Space between words. <--- CHANGE THIS LINE
               $testLine .= $word;
Making both changes results in the spaces in these costs being restored to their expected size:

Adun Oakenshield2.full.jpg


EDIT 2: There's also a bug in at least the PreEighth renderer (didn't check the others) where it'll correctly identify that the art is XLHQ, but then overwrite it with the file used as if it was a normal format image afterwards. It's basically just missing an "else" on like 44.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/10

PostPosted: 28 Nov 2016, 21:18
by ahkren
Now that I'm back from vacation, I'll have some more time to work on this.
@charlequin I noticed the spacing problem as well and have a fix in for it. I'm also checking the other renderers to see if I missed the else on them. Hopefully should have an update in the next few days.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/11

PostPosted: 29 Nov 2016, 00:49
by ahkren
Version 9.0.18 has been uploaded.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/11

PostPosted: 05 Dec 2016, 21:23
by ahkren
In the works: Proper copyright dates on non-promo cards. The code I have seems to work, just working on compiling a complete list of release dates for sets.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2016/11

PostPosted: 14 Jan 2017, 00:40
by proud
I noticed that the gold multicolor planeswalkers with 4 abilities do not have gold title and type bars (whereas the two and three ability ones do).

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2017/01

PostPosted: 14 Jan 2017, 19:01
by ahkren
Updated to 9.0.19

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2017/01

PostPosted: 16 Jan 2017, 18:47
by ahkren
@proud I'll see what I can do to fix that.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2017/01

PostPosted: 16 Jan 2017, 23:51
by ahkren
Quick fix for the 4 ability gold planeswalker frames is attached.

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2017/01

PostPosted: 10 Feb 2017, 22:01
by ahkren
Working on a large update for Japanese text support and updating php version to 5.5.0

Re: HQ Cardgen M15/8th/Pre8th/Tokens/Emblem (Updated 2017/01

PostPosted: 24 Mar 2017, 18:22
by ahkren
I should have an update this weekend, been exceptionally busy at my day job the last few weeks.