myk's code contributions

[myk]

Ok, I've sorted and re-prioritized my list based on the above posts. If anyone wants ownership of any of the following tasks, or has further requests/suggestions, please speak up : )

Bugs to fix:

1. correct tab label text when switching deck sections
2. size How To Play and License Details overlay panels correctly
3. add newly created scheme/planar decks to selection lists
4. ensure challenges are available when they are supposed to be could not repro (and neither can original reporter)
5. only play sound event once at a time (stutter in untap phase when many cards are getting untapped, for example)
6. don't propagate changes to current deck when you select 'no' at the save prompt
7. reevaluate cursor position when activating a card so tabbing off the application window then clicking back onto it doesn't tap the last highlighted card
8. Report Bug dialog doesn't work (do we want it to go to cardforge, or just format a post template for the forum?)
9. refresh screen on attack phase so auto-attacking creatures show their sword badges
10. ensure Play or Draw? dialog has focus when it comes up

Improvement shortlist:

1. combine Duels and Challenges into one page, with challenges taking up the top slots in the duels menu (visually differentiate from duel opponents)
2. for each screen/dialog:
   
   • set useful default widget focus on show
   • ensure correct tab-focus order
   • attach keylisteners for useful enter/space/arrow hotkeys
3. remove Command, use existing Runnable
4. delete decks from in-game
5. in the custom deck selection list for AI, visually mark decks that contain cards flagged with RemAIDeck
6. show preview of skin when selecting
7. fire off events for Foreroes new sounds
8. r-click menu for restriction widgets (edit, change options, temporarily disable, invert)
9. indicate how many cards are being hidden by the current filter (should alleviate "where did my cards go?" syndrome)
10. sort battlefield card lists by name for effects that ask you to choose a card from the battlefield
11. add dragtab panels to default place if they're missing in the editor_preferred.xml file
12. move Import deck functionality to a button on the Current Deck tab
13. keep remaining items selected in tables when some items disappear due to a move operation
14. sort indicator for table columns with highest sort priority
15. support for setting foiled cards in deck editor
16. save filters per mode(deck/sideboard share a filter set, scheme gets its own, etc.)
17. user-editable notes per deck
18. add ManaCost widget to deck list, six symbols in the ratio of their use in the deck
19. remove old, unused, custom localization infrastructure
20. make it configurable whether cards are shown on hover and used on click or shown on click and used on double-click
21. allow double-click on duel/challenge to start the duel
22. achievements and more level names (see this feature request)
23. don't replace catalog with current deck in sideboard mode now that we have a way to move cards between decks and sideboards
24. make quest AI starting life configurable
25. implement hotkeys for selecting self/opponents see here
26. official/unofficial world split (see this post)
27. add r-click options to deck editor: add/remove card (opposite direction -- add one more of an existing card in the deck, for example)
28. make deck lists searchable
29. show previews of the pet and plant on the duels page
30. upload html file with a meta redirect with the build to point to latest directory
31. disable travel button for a few duels after traveling
32. make number of wins necessary to unlock new set configurable

Longer-term improvements | Open

1. enable tabbing through cards in match, activating them with space, enter from anywhere activates default button (ok, usually)
2. save deck editor filter settings per deck
3. remember column order per editor
4. remember column sizes per editor
5. allow column addition/removal via r-click menu on header
6. make deck generation restricted by current filter
7. quest deck generation
8. tag support for decks, use for better organization in custom deck listbox
9. configuration dialog for sound. can play each sound, turn it on/off, configure global volume
10. apply new skin without restart
11. consolidate sideboard listview items so multiple copies of cards don't take up an extra line, just show [qty] name
12. show related card when hovering over the stack item for a target effect
13. move user preferences and downloadable content out of program directory so they are persisted across upgrades when users decompress to a different path (no more "pic import" steps or copying over of preferences)
14. cards labeled NEW compared to last time deck was edited (cards get a lastAcquired timestamp (only updated for first four copies, probably ok not to special case lands and relentless rats), decks get lastModified, compare on display)
15. configuration options for number of cards/lands/relentless rats kept when selling extras

thoughts on a new quest mode | Open

mode targeted at getting players out of their comfort zones, putting them in new situations, and stretching their flexibility.

achievement-focused. bazaar replaced with perks tree. accomplishing achievements grants perk points. new Perks submenu, two tabs: global, world. global perks are always active, world perks only for the current world.

or..winning battles grants perk points. perk points have color, perks require a certain number of points in specific colors, just like mana costs. winning a duel grants 1/N perk points for each color in an N-color deck.

perk branches by color. pets for that color available once color branch is unlocked.

perk ideas (mostly stolen from current bazaar):
- white: life (levels 1-20, assuming player starts with 10 life)
- more money per duel (levels 1-5)
- better luck getting rares
- challenges more often

buy potions at spell shop: gives you a 10-life boost for the next duel. start with a few potions so players aren't faced with life issues until they have a chance to get some better decks together.

achievement ideas:
- win with every color mono deck
- win with a colorless deck
- win by milling
- win by poison
- win X battles with a certain color combination
- win in 10/5/1 turns

perk points given for:
- winning a duel
- completing a set
- achieving achievements

unlock an expansion by fighting in a world that includes that expansion in its format


adventure mode ideas:
tournaments: use one deck to battle through a series of opponents
Quest mechanics
When starting a quest, the player chooses a home world. A random expansion used by that world is immediately unlocked.
Further expansions from that world are unlocked after a pre-determined number of wins +/- x% in that world.
When you complete a set (4 of everything), you can unlock a set of your choice from any unlocked world
Only cards from sets available in a world are allowed in decks played in that world. Reprints are not allowed. This will force players to get core booster/starter/fat packs in the main world or spell shop for a world they are planning on playing in.
Booster packs are awarded for winning a duel. The booster pack awarded is from the choices available in the current world that the player has unlocked
In the first world the player enters, the player can choose to unlock the main world instead of an expansion during one of the unlock prompts
Dueling in the main world has an x% chance of unlocking a world of the player's choice
All Core sets start unlocked, so players play in the main world to get enough cards to travel to a destination world and play there effectively
Some worlds do not have any core sets enabled. These necessarily would allow expansion sets that include lands. They can only be played in by first unlocking the land-containing set from some other world that includes that set.
Spell shop only carries packs and decks valid in the current world
Diminishing returns for using the same cards/colors all the time. Every time a card/color is in a winning deck, its "win count" increases. A deck with cards/colors with a lower win count produces more rewards. This will encourage players to try out new cards and different styles and not just play particular cards all the time. Rewards are greatest when the average win count for the currently used cards is less than avg win count (plus x -- we don't want to start penalizing them right away) for all owned cards overall.
All games played for ante at first to increase the stakes (and therefore the fun, hopefully); a bazaar item can be purchased that allows the player to opt to pay 10 times the cost of the card instead of losing the card if a duel is lost. Challenges don't require ante, but are only available periodically, as is the case now.
Bazaar items:
allow (x) ante re-rolls (highest level of this item is the money-instead-of-ante perk described above)
more free mulligans
most bazaar items should cost more than they do now
different worlds have different items available? can be used in only that world? perhaps pets should be per-world so each world start is more difficult. or maybe there is a global set of weaker pets that always stay with you but world-specific pets are more powerful but cannot leave that world.
winning in your home world brings in twice as many booster pack rewards as winning elsewhere so quest starts are accelerated
duel opponents of all difficulties should always be available. Perhaps the three now displayed could be from differing levels (at various fractions of your current level, times some random factor). This would allow new decks to be tested out on easier opponents before trying them against hard ones.
you have a separate level attained for each world that determines the opponents (and reward multiplier) available in that world
UI
Deck editor world filters would not show reprints from other sets.
Opening the deck editor while in a particular world would have an unremovable world filter for that world. cards in the current deck that do not match the filter would be highlighted in red
The quest decks page would have two tabs, Decks valid in current world and All decks
viewtopic.php?f=26&t=1516&p=107768&hilit=vision#p107768

[Max mtg]

bugs #3 - there was a quote of code on previous page with some hints
bugs #5 - look at forge.sound.SoundEffectType - I hope, it will be enough to switch the tap/untap sounds to sync-ed.
bugs #6 - Older version of deck editor copied the deck on load. On 'save' event editor called forge.util.storage.IStorage.add(T) with the changed deck as parameter. The reference to deck's storage was saved along with the deck. The storage at the moment returns decks without copying them... should i add that feature?
bugs #8 - It would be great to drop support of mantis. A lot of dependencies would be removed in pom.xml/

Shortlist
#12 - strongly approved (#3 not approved that much anymore)
#4 - forge.util.storage.IStorage.delete(String key) // deckname
#5 - see predicate on prev. page
#7 - Please use the events system (the existing one - when an event is fired from server and gui client decides what to do about it, like play a sound)

long-term
#2 - anywhere but in the deck file & folder.
#8 - I'll implement the underlying model, that is tag fields in the Deck class and IStorage methods filtering items by tag.
#11 - would be great is they return consolidated models as well (that is use ItemPool to manage collections). Honestly, sidboarding interface deserves a special dedicated window, unlike being a guest of 'order' routines.
#13 - strongly approved
#14 - changing forge.quest.data.QuestAssets.newCardList to Map<CardPrinted, YourTimeStampType> would do the job. (that is: don't even think of adding fields to cardprinted)

[myk]

bugs #6 - Older version of deck editor copied the deck on load. On 'save' event editor called forge.util.storage.IStorage.add(T) with the changed deck as parameter. The reference to deck's storage was saved along with the deck. The storage at the moment returns decks without copying them... should i add that feature?

That would be great, then I'd just add the code to explicitly save (it might already be there, but I'll have to check all the code paths)

bugs #8 - It would be great to drop support of mantis. A lot of dependencies would be removed in pom.xml

Is that a vote for just formatting a forum post template and giving them a clickable link to the appropriate thread (or forum in the case of releases, since the thread changes)

#8 - I'll implement the underlying model, that is tag fields in the Deck class and IStorage methods filtering items by tag.

awesome, thanks -- I can bump it up the priority list.

#11 - would be great is they return consolidated models as well (that is use ItemPool to manage collections). Honestly, sidboarding interface deserves a special dedicated window, unlike being a guest of 'order' routines.

I agree -- a mini deck editor would be nice, methinks. The singleton system makes it somewhat difficult to reuse the code for this without doing a fullscreen switch to the deck editor, tho..

[friarsol]

Edit: fixed. whew! it turned out to be components that were getting continually overwritten in SResizingUtil.

I had a similar issue just right now. First game everything was fine, space bar and "A" shortcut working. Didn't sideboard anything, space bar working in the beginning of the second game (i'm pretty sure). I cast Ravenous Rats, but with the Rats ETB trigger on the stack my space bar and A button are now non-functional. I did also notice that my up-down arrows didn't work in the sideboard, but I'm not sure that's related. If I goto Dev Mode, act like I'm adding a card to my hand and cancel, space bar is restored to the input panel.

Edit: I can't seem to reproduce this, although it was my first game since launching Forge, so perhaps that has something to do with it. Oh well, hopefully it'll get fully ironed out at some point.

[myk]

Sol: I haven't been able to repro the focus loss since I fixed the component readd-on-resize problem. Please keep me appraised if it continues to happen to you.

Re: bug #5 above, there are a few sounds that seem like they could apply to multiple cards simultaneously, but you'd only want to hear about once. Would it be ok to change the following to synced:

• AddCounter
• Poison
• RemoveCounter
• Sacrifice
• Token
• Untap

[moomarc]

Re: bug #5 above, there are a few sounds that seem like they could apply to multiple cards simultaneously, but you'd only want to hear about once. Would it be ok to change the following to synced:

• AddCounter
• Poison
• RemoveCounter
• Sacrifice
• Token
• Untap

Definitely! Basically any event that has an {API}All variant should probably also be included.

[Max mtg]

Sound is played as a reaction to an event passing from game via a special bus (to avoid hardcoding sound into game classes), so it is unknown to sound system which method of api originated the event, so it is not possible at the moment to distinguish "events that has an {API}All variant".

For the rest I agree with the suggestion above.

[friarsol]

Sol: I haven't been able to repro the focus loss since I fixed the component readd-on-resize problem. Please keep me appraised if it continues to happen to you.

Yea, I tried repro-ing it myself without any luck. Hopefully there's something specific I can point at to being the culprit. I play very quickly, and tend to notice as soon as I can't use the spacebar.

[Max mtg]

#3 - about removing Command - I think you should a bit delay that process to be able to refactor that commands in future. I found out that it is quite easy now to find all those Commands that may be passed to InputPayManaExecuteCommands. Once you delete the Command class, such instances will become undistinguishable from UI Runnables and any threads the game may start.
So, I suggest you just rename execute() into run() so that the Command class implements Runnable.

[myk]

good suggestion. will do.

[Chris H.]

size How To Play and License Details overlay panels correctly fixed in r19727

 
I am using the Marble skin and these two windows look a wee bit strange:
 

[myk]

Hrm.. I'll see if it looks better with the standard "dialog" background instead of a transparent one Edit: fixed in r19757. I also let the how to play scroll area span the height of the screen so more is visible at once. Is this better, or did anyone prefer the smaller viewport?

[Max mtg]

a possible feature for deck editor = viewtopic.php?f=26&t=9646 That is support for foiled cards. The data model is ready.

[Chris H.]

Hrm.. I'll see if it looks better with the standard "dialog" background instead of a transparent one Edit: fixed in r19757. I also let the how to play scroll area span the height of the screen so more is visible at once. Is this better, or did anyone prefer the smaller viewport?

 
I like having more info displayed at one time.

Is it possible to add a gap of 10% above and below the how to play scroll area?

[myk]

support for foiled cards. The data model is ready.

Nice. I'll add it to the list.

Is it possible to add a gap of 10% above and below the how to play scroll area? :wink:

I added in a margin -- it looks much better now. Keep the suggestions coming!

I added a new error viewer/bug reporter dialog. I could use some feedback on that as well. Does the browser interaction work for everybody? Is the forum post template good? Does the hyperlink work in the help text in the upper portion? If everything looks good, I'll go purge the mantis dependencies from the pom.

One note, the code there used some localized strings and constants. I noticed the localization system isn't exactly maintained, and the constants aren't exactly centralized. I put the URLs and strings directly in the code for now, but where should they be moved? See the _showDialog() method in r19764 to see what I mean.

One more thing, could someone close issue 654 at cardforge?