Ability Factory

[friarsol]

Ahh. I thought you had enough done for others to play with it. I'll go in and fix the changes.

Are you done with your changes so my work won't just be overridden again in the SVN?

[Rob Cashwalker]

Yeah, I think I've gotten far enough with it.

[Rob Cashwalker]

Now, my question to you, is isCurse "universal"? Or is it really specific to just pumps and counters?

[friarsol]

I don't see why it wouldn't be. It's an easy way to tell the AI that he should be targeting Opposing cards instead of his own. I think it would be short-sighted to say "well this only applies to two types of keywords we have now, let's make it more difficult for other keywords in the future to take use of it."

However, we probably don't need a variable for it. We could just have a getter in AbilityFactory that says:

Code: Select all

public boolean isCurse(){
   return mapParams.containsKey("IsCurse");
}


If your goal is to keep the getAbility() function as generic as possible, I think the above solution would be the cleanest way to accomplish that and not gunk up extra code in the sub-functions.

Oh and we should probably also delete DealDamage from the SVN, now that you renamed the file.

[Rob Cashwalker]

Hmmm... I get your point... and yet I still feel like that sort of check is better handled in the specific API code.

Here's one way to look at a similar thing:
Discard and DrawCards will both be expecting a parameter like "NumCards" (and/or "NumCardsX"). As might some other effects. However, I would not expect this to be a significant enough parameter to make it part of the AbilityFactory public methods.
I would parse it in the API matching code block, then pass it as a parameter to the AbilityFactory_{API}.getAbility.
At the same rate, why should getAbility or getSpell have to take parameters at all? As of last night, it was because getAbility was static, and DealDamage wasn't being instantiated. Now it is, so I should move the NumDmg parsing to the AbilityFactory_DealDamage constructor. Same would apply for NumCards, and IMHO, isCurse.

It doesn't show up in my local archive, since I renamed it. I don't see a way to delete it on the Google code site. If you can do it, go ahead.