Dragon's Maze Spoiler Season

[swordshine]

Commit and i fix the AI.

Committed in r21140.

[friarsol]

I haven't had a chance to look through the full spoiler yet. What's the top 5 cards that seem to be the hardest to script? (Or possibly impossible in today's scripting environment)

I see someone already listed Trait Doctoring which definitely isn't scriptable yet.

[swordshine]

I haven't had a chance to look through the full spoiler yet. What's the top 5 cards that seem to be the hardest to script? (Or possibly impossible in today's scripting environment)

I see someone already listed Trait Doctoring which definitely isn't scriptable yet.

Catch // Release: controllerChangeZoneCorrection is currently running in checkStateEffects, we cannot Release the permanent that obtained by Catch currently. I think we should do something to correct zone during resolving.
Pyrewild Shaman: We have discussed this one. I haven't committed it. I saw PowerClaws wanted to script it
Reap Intellect: It did not work last night , I'll do some debug today.
Dragonshift: I think "RemoveAllAbilities" would overwrite the new keyword.
Showstopper: may have some LTB issues (I haven't tried yet, PowerClaws haven't post his script yet)

[swordshine]

Boros Battleshaper | Open

Code: Select all

Name:Boros Battleshaper
ManaCost:5 R W
Types:Creature Minotaur Soldier
PT:5/5
T:Mode$ Phase | Phase$ BeginCombat | TriggerZones$ Battlefield | Execute$ TrigMustAttackBlock | TriggerDescription$ At the beginning of each combat, up to one target creature attacks or blocks this combat if able and up to one target creature can't attack or block this combat.
SVar:TrigMustAttackBlock:AB$ Pump | Cost$ 0 | ValidTgts$ Creature | TargetMin$ 0 | TargetMax$ 1 | TgtPrompt$ Choose target creature to attack or block if able | KW$ HIDDEN CARDNAME attacks each turn if able. & HIDDEN CARDNAME blocks each turn if able. | IsCurse$ True | UntilEndOfCombat$ True | SubAbility$ DBCantAttackBlock
SVar:DBCantAttackBlock:DB$ Pump | ValidTgts$ Creature | TargetMin$ 0 | TargetMax$ 1 | TgtPrompt$ Choose target creature that cannot attack or block this combat | KW$ HIDDEN CARDNAME can't attack or block. | IsCurse$ True | UntilEndOfCombat$ True
SVar:RemAIDeck:True
SVar:Picture:http://www.wizards.com/global/images/magic/general/boros_battleshaper.jpg


Sometimes I got:

RuntimeException | Open

Code: Select all

Forge Version:    SVN
Operating System: Windows XP 5.1 x86
Java Version:     1.7.0_17 Oracle Corporation

java.lang.RuntimeException: Trying to unlock input which is not locked! Do check when your threads terminate!
   at forge.control.input.InputControl.unlock(InputControl.java:208)
   at forge.FThreads$1.run(FThreads.java:114)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
   at java.lang.Thread.run(Thread.java:722)


[PowerClaws]

I haven't had a chance to look through the full spoiler yet. What's the top 5 cards that seem to be the hardest to script? (Or possibly impossible in today's scripting environment)

I see someone already listed Trait Doctoring which definitely isn't scriptable yet.

Catch // Release: controllerChangeZoneCorrection is currently running in checkStateEffects, we cannot Release the permanent that obtained by Catch currently. I think we should do something to correct zone during resolving.
Pyrewild Shaman: We have discussed this one. I haven't committed it. I saw PowerClaws wanted to script it
Reap Intellect: It did not work last night , I'll do some debug today.
Dragonshift: I think "RemoveAllAbilities" would overwrite the new keyword.
Showstopper: may have some LTB issues (I haven't tried yet, PowerClaws haven't post his script yet)

I got Pyrewild Shaman working... the others are scripted, but crashing, so its just a little beyond me

Worked for me

Profit & Loss | Open

Name:Profit
ManaCost:1 W
AlternateMode: Split
Types:Instant
K:Fuse
A:SP$ PumpAll | Cost$ 1 W | ValidCards$ Creature.YouCtrl | NumAtt$ +1 | NumDef$ +1 | SpellDescription$ Creatures you control get +1/+1 until end of turn.

ALTERNATE

Name:Loss
ManaCost:2 B
Types:Instant
A:SP$ PumpAll | Cost$ 2 B | ValidCards$ Creature.OppCtrl | NumAtt$ -1 | NumDef$ -1 | IsCurse$ True | SpellDescription$ Creatures your opponents control get -1/-1 until end of turn.

Protect & Serve | Open

Name:Protect
ManaCost:2 W
AlternateMode: Split
Types:Instant
K:Fuse
A:SP$ Pump | Cost$ 2 W | ValidTgts$ Creature | TgtPrompt$ Select target creature to get +2/+4 | NumAtt$ +2 | NumDef$ +4 | SpellDescription$ Target creature you control gets +2/+4 until end of turn.

ALTERNATE

Name:Serve
ManaCost:1 U
Types:Instant
A:SP$ Pump | Cost$ 1 U | ValidTgts$ Creature | TgtPrompt$ Select target creature to get -6/-0 | NumAtt$ -6 | IsCurse$ True | SpellDescription$ Target creature gets -6/-0 until end of turn.

Pyrewild Shaman | Open

Name:Pyrewild Shaman
ManaCost:2 R
Types:Creature Goblin Shaman
PT:3/1
A:AB$ Pump | Cost$ 1 R Discard<1/CARDNAME> | ActivationZone$ Hand | PrecostDesc$ Bloodrush | ValidTgts$ Creature.attacking | TgtPrompt$ Select target attacking creature | NumAtt$ +3 | NumDef$ +1 | SpellDescription$ Target attacking creature gets +3/+1 until end of turn.
T:Mode$ DamageDone | ValidSource$ Creature.YouCtrl | TriggerZones$ Graveyard | ValidTarget$ Player | CombatDamage$ True | Execute$ TrigChange | TriggerDescription$ Whenever one or more creatures you control deal combat damage to a player, you may pay 3. If you do, return CARDNAME from your graveyard to your hand.
SVar:TrigChange:AB$ChangeZone | Cost$ 3 | Origin$ Graveyard | Destination$ Hand

Savageborn Hydra | Open

Name:Savageborn Hydra
ManaCost:X R G
Types:Creature Hydra
PT:0/0
K:Double Strike
K:etbCounter:P1P1:X
A:AB$ PutCounter | Cost$ 1 RG | SorcerySpeed$ True | CounterType$ P1P1 | CounterNum$ 1 | SpellDescription$ Put a +1/+1 counter on CARDNAME. Activate this ability only any time you could cast a sorcery.
SVar:X:Count$xPaid

Trostani's Summoner | Open

Name:Trostani's Summoner
ManaCost:5 G W
Types:Creature Elf Shaman
PT:1/1
T:Mode$ ChangesZone | Origin$ Any | Destination$ Battlefield | ValidCard$ Card.Self | Execute$ TrigToken | TriggerDescription$ When CARDNAME enters the battlefield, put a 2/2 white Knight creature token with vigilance, a 3/3 green Centaur creature token, and a 4/4 green Rhino creature token with trample onto the battlefield.
SVar:TrigToken:AB$ Token | Cost$ 0 | TokenAmount$ 1 | TokenName$ Knight | TokenTypes$ Creature,Knight | TokenOwner$ You | TokenColors$ White | TokenPower$ 2 | TokenToughness$ 2 | TokenKeywords$ Vigilance | TokenImage$ W 2 2 Knight vigilance | TokenImage$ w 2 2 knight rtr | SubAbility$ DBCentaurToken |
SVar:DBCentaurToken:DB$Token | TokenAmount$ 1 | TokenName$ Centaur | TokenTypes$ Creature,Centaur | TokenOwner$ You | TokenColors$ Green | TokenPower$ 3 | TokenToughness$ 3 | TokenImage$ g 3 3 centaur rtr | SubAbility$ DBRhinoToken
SVar:DBRhinoToken:DB$Token | TokenAmount$ 1 | TokenName$ Rhino | TokenTypes$ Creature,Rhino | TokenOwner$ You | TokenColors$ Green | TokenPower$ 4 | TokenToughness$ 4 | TokenKeywords$ Trample | TokenImage$ g 4 4 rhino rtr

Unflinching Courage | Open

Name:Unflinching Courage
ManaCost:1 G W
Types:Enchantment Aura
K:Enchant creature
A:SP$ Attach | Cost$ 1 G W | ValidTgts$ Creature | AILogic$ Pump
S:Mode$ Continuous | Affected$ Creature.EnchantedBy | AddPower$ 2 | AddToughness$ 2 | AddKeyword$ Trample, Lifelink | Description$ Enchanted creature gets +2/+2 and has trample and lifelink.

Warped Physique | Open

Name:Warped Physique
ManaCost:U B
Types:Instant
A:SP$ Pump | Cost$ U B | ValidTgts$ Creature | TgtPrompt$ Select target creature | NumAtt$ +X | NumDef$ -X | References$ X | SpellDescription$ Target creature gets +X/-X until end of turn, where X is the number of cards in your hand.
SVar:X:Count$CardsInYourHand

Gave crashes when tried to play

Dragonshift | Open

Name:Dragonshift
ManaCost:1 U R
Types:Instant
A:SP$ Animate | Cost$ 1 U R | ValidTgts$ Creature.YouCtrl | TgtPrompt$ Select target creature | Power$ 4 | Toughness$ 4 | KW$ Flying | RemoveAllAbilities$ True | Colors$ Blue, Red | OverwriteColors$ True | Types$ Dragon | RemoveCreatureTypes$ True | SpellDescription$ Until end of turn, target creature you control becomes a 4/4 blue and red Dragon, loses all abilites, and gains flying.
A:SP$ AnimateAll | Cost$ 3 U U R R | ValidCards$ Creature.YouCtrl | Power$ 4 | Toughness$ 4 | KW$ Flying | RemoveAllAbilities$ True | Colors$ Blue, Red | OverwriteColors$ True | Types$ Dragon | RemoveCreatureTypes$ True | PrecostDesc$ Overload | CostDesc$ 3 U U R R | NonBasicSpell$ True | SpellDescription$ Until end of turn, each creature you control becomes a 4/4 blue and red Dragon, loses all abilites, and gains flying.

Give & Take | Open

Name:Give
ManaCost:2 G
AlternateMode: Split
Types:Sorcery
K:Fuse
A:SP$ PutCounter | Cost$ 2 G | ValidTgts$ Creature | TgtPrompt$ Select target creature | CounterType$ P1P1 | CounterNum$ 3 | SpellDescription$ Put three +1/+1 counters on target creature.

ALTERNATE

Name:Take
ManaCost:2 U
Types:Sorcery
A:SP$ Draw | Cost$ 2 U SubCounter<All/P1P1/Creature.YouCtrl> | ValidTgts$ Creature | TgtPrompt$ Select target creature | NumCards$ X | References$ X | SpellDescription$ Remove all +1/+1 counters from target creature you control. Draw that many cards.
SVar:X:SVar$CostCountersRemoved

Ready & Willing | Open

Name:Ready
ManaCost:1 G W
AlternateMode: Split
Types:Instant
K:Fuse
A:SP$ UntapAll | Cost$ 1 G W | ValidCards$ Creature.YouCtrl | SubAbility$ PumpAll | SpellDescription$ Creatures you conttrol are indestructible this turn. Untap each creature you control.
SVar:PumpAll:DB$ PumpAll | ValidCards$ Creature.YouCtrl | KW$ HIDDEN Indestructible

ALTERNATE

Name:Willing
ManaCost:1 W B
Types:Instant
A:AB$ PumpAll | Cost$ 1 W B | ValidCards$ Creature.YouCtrl | KW$ Deathtouch & Lifelink | SpellDescription$ Creatures you control gain deathtouch and lifelink until end of turn.

Showstopper | Open

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ AnimateAll | Cost$ 1 B R | ValidCards$ Creature.YouCtrl | Triggers$ Dies | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:Dies:AB$ ChangeZone | ValidTgts$ Card.Self | Origin$ Battlefield | Destination$ Graveyard | SubAbility$ TrigDamage | TriggerDescription$ When CARDNAME dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$DealDamage | Cost$ 0 | ValidTgts$ Creature | TgtPrompt$ Select target creature | NumDmg$ 2

[friarsol]

Showstopper looks wrong. You should be animating a full trigger, but the svar you animate is an Ability. Take a look at Skirk Ridge Exhumer

[friarsol]

Did anyone ever take a look at DGM Booster specifications? I'm not sure who did these for TSP and Transforms, but we'll need something similar here.

Booster packs for Dragon's Maze do not contain basic lands. Instead each booster contains either a "Guild Gate" - a common dual land with the type "Gate"; a "Shockland" - a rare dual land with two basic land types, from the original Ravnica block; or a mythic rare land from Dragon's Maze in the appropriate ratio of their rarities.

http://www.wizards.com/Magic/Magazine/A ... rcana/1156

So the 15th card will be either a Guildgate, a Shockland, or Maze's End. It seems that these non-basics will not appear in the other 14 cards of the pack (they only appear on the "Land Card Sheet") and technically Shocklands aren't part of the set, even though they will appear in Boosters in the set. (I think this was an art/small set issue more than anything else) I'll see if I can dig up some more info but it seems like the Land sheet is 121 cards, and the ratio of Common:Rare:Mystic may be 100:20:1

So each Guildgate has a 10/121 chance of being pulled, each Shockland has a 2/121 chance of being pulled, and Maze's End has a 1/121 chance of being pulled.

[Max mtg]

I'm not sure who did these for TSP and Transforms, but we'll need something similar here.

http://svn.slightlymagic.net/websvn/log ... rData.java
http://svn.slightlymagic.net/websvn/log ... rator.java

TSP was not a problem - all those card have a dedicated rarity and equal chance to get into a booster.

For DGM we'll have to implement a new slot type, backed by a hardcoded printsheet with relative chance for each card. There's nothing pleasant about that.

[PowerClaws]

Showstopper looks wrong. You should be animating a full trigger, but the svar you animate is an Ability. Take a look at Skirk Ridge Exhumer

Thanks, so i tried again and got the following script, but when i play it, i get the following crash, any ideas what the problem in my script is?

Showstopper | Open

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ AnimateAll | Cost$ 1 B R | ValidCards$ Creature.YouCtrl | Abilities$ DiesTrigger | SVars$ TrigDamage | References$ DiesTrigger,TrigDamage | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:DiesTrigger:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.Self | Execute$ TrigDamage | TriggerController$ TriggeredCardController | TriggerDescription$ When CARDNAME dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$DealDamage | Cost$ 0 | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls | NumDmg$ 2

Showstopper Crash | Open

Description: [describe what you were doing when the crash occurred]

[spoiler=RuntimeException]

Code: Select all

Forge Version:    1.3.13-SNAPSHOT-r21148
Operating System: Windows 7 6.1 amd64
Java Version:     1.7.0_11 Oracle Corporation

java.lang.RuntimeException: AbilityFactory : getAbility -- no API in Abuna Acolyte
   at forge.card.ability.AbilityFactory.getAbility(AbilityFactory.java:108)
   at forge.card.ability.effects.AnimateAllEffect.resolve(AnimateAllEffect.java:154)
   at forge.card.ability.SpellApiBased.resolve(SpellApiBased.java:55)
   at forge.card.ability.AbilityUtils.resolveApiAbility(AbilityUtils.java:1082)
   at forge.card.ability.AbilityUtils.resolve(AbilityUtils.java:1061)
   at forge.game.zone.MagicStack.resolveStack(MagicStack.java:615)
   at forge.game.phase.PhaseHandler$1.run(PhaseHandler.java:743)
   at forge.game.phase.PhaseHandler.passPriority(PhaseHandler.java:751)
   at forge.game.player.PlayerController.passPriority(PlayerController.java:77)
   at forge.game.ai.AiController.onPriorityRecieved(AiController.java:829)
   at forge.game.ai.AiInputCommon$1.run(AiInputCommon.java:74)
   at forge.FThreads$1.run(FThreads.java:113)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)


[/spoiler]

[swordshine]

@PowerClaws
I've got Give // Take and Ready // Willing worked, see http://svn.slightlymagic.net/websvn/listing.php?repname=forge&rev=21159

[friarsol]

Thanks, so i tried again and got the following script, but when i play it, i get the following crash, any ideas what the problem in my script is?

I think the Animate also needs to be placing the SVar onto the animated card. Skirk Ridge Exhumer does exactly that (just through token creation instead of card animating)

[swordshine]

Thanks, so i tried again and got the following script, but when i play it, i get the following crash, any ideas what the problem in my script is?

Showstopper | Open

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ AnimateAll | Cost$ 1 B R | ValidCards$ Creature.YouCtrl | Abilities$ DiesTrigger | SVars$ TrigDamage | References$ DiesTrigger,TrigDamage | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:DiesTrigger:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.Self | Execute$ TrigDamage | TriggerController$ TriggeredCardController | TriggerDescription$ When CARDNAME dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$DealDamage | Cost$ 0 | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls | NumDmg$ 2

[/spoiler]

"A:SP$ AnimateAll | Cost$ 1 B R | ValidCards$ Creature.YouCtrl | Abilities$ DiesTrigger | SVars$ TrigDamage " should be "A:SP$ AnimateAll | Cost$ 1 B R | ValidCards$ Creature.YouCtrl | Triggers$ DiesTrigger | sVars$ TrigDamage ".
I've tried it, and this script didn't work as I thought because of some current LTB issues. I think all the static abilities and animate effects that grant permanents LTB effects are not working (That's why Reborn Hero are not scripted).

[swordshine]

A possible script of Showstopper is:

Showstopper | Open

Code: Select all

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ Effect | Cost$ 1 B R | RememberObjects$ Valid Creature.YouCtrl | Triggers$ DiesTrigger | SVars$ TrigDamage,ForgetRemember | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:DiesTrigger:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.IsRemembered | Execute$ TrigDamage | TriggerController$ TriggeredCardController | TriggerDescription$ When a creature you control dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$ DealDamage | Cost$ 0 | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls | NumDmg$ 2 | DamageSource$ TriggeredCard | SubAbility$ ForgetRemember
SVar:ForgetRemember:DB$ Pump | ForgetObjects$ TriggeredCard
SVar:Picture:http://www.wizards.com/global/images/magic/general/showstopper.jpg


The LTB trigger works, thought it does not actually grant creatures the LTB triggers in their card characteristics. May I commit this script?

[Sloth]

A possible script of Showstopper is:

Showstopper | Open

Code: Select all

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ Effect | Cost$ 1 B R | RememberObjects$ Valid Creature.YouCtrl | Triggers$ DiesTrigger | SVars$ TrigDamage,ForgetRemember | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:DiesTrigger:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.IsRemembered | Execute$ TrigDamage | TriggerController$ TriggeredCardController | TriggerDescription$ When a creature you control dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$ DealDamage | Cost$ 0 | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls | NumDmg$ 2 | DamageSource$ TriggeredCard | SubAbility$ ForgetRemember
SVar:ForgetRemember:DB$ Pump | ForgetObjects$ TriggeredCard
SVar:Picture:http://www.wizards.com/global/images/magic/general/showstopper.jpg


The LTB trigger works, thought it does not actually grant creatures the LTB triggers in their card characteristics. May I commit this script?

This script will not act correctly with cards like Turn to Frog, Dragonshift, Humble, Muraganda Petroglyphs, Ovinize, Snakeform, Turn (Turn//Burn) and Soul Sculptor. I think we should try to fix this issue with LTB triggers and not commit wrong scripts.

[swordshine]

A possible script of Showstopper is:

Showstopper | Open

Code: Select all

Name:Showstopper
ManaCost:1 B R
Types:Instant
A:SP$ Effect | Cost$ 1 B R | RememberObjects$ Valid Creature.YouCtrl | Triggers$ DiesTrigger | SVars$ TrigDamage,ForgetRemember | SpellDescription$ Until end of turn, creatures you control gain "When this creature dies, it deals 2 damage to target creature an opponent controls."
SVar:DiesTrigger:Mode$ ChangesZone | Origin$ Battlefield | Destination$ Graveyard | ValidCard$ Card.IsRemembered | Execute$ TrigDamage | TriggerController$ TriggeredCardController | TriggerDescription$ When a creature you control dies, it deals 2 damage to target creature an opponent controls.
SVar:TrigDamage:AB$ DealDamage | Cost$ 0 | ValidTgts$ Creature.OppCtrl | TgtPrompt$ Select target creature an opponent controls | NumDmg$ 2 | DamageSource$ TriggeredCard | SubAbility$ ForgetRemember
SVar:ForgetRemember:DB$ Pump | ForgetObjects$ TriggeredCard
SVar:Picture:http://www.wizards.com/global/images/magic/general/showstopper.jpg


The LTB trigger works, thought it does not actually grant creatures the LTB triggers in their card characteristics. May I commit this script?

This script will not act correctly with cards like Turn to Frog, Dragonshift, Humble, Muraganda Petroglyphs, Ovinize, Snakeform, Turn (Turn//Burn) and Soul Sculptor. I think we should try to fix this issue with LTB triggers and not commit wrong scripts.

That's true. After I took a look at Dragonshift, I found this script did not work with it. By the way, all these cards with "RemoveAllAbilities" would prevent the animated cards from getting new keywords. I did not add Dragonshift because of this bug.
Edit: Cast Dragonshift, then cast some cards with pump keywords effect, nothing happened to the animated dragons.