General UI support

[Doublestrike]

Hmm, that's a good clue right there.

The repaint is up (r14008), probably won't work. I've got work in the morning so can't continue this excellent repartee but it's given me a new place to start looking - that button problem. Shooting in the dark over here, maybe will hit something :/

I think when the UI state is changed in the frame, perhaps things aren't validating correctly - could someone perhaps try various combinations of the following, in FControl, at the end of the "changeState" method:

Singletons.getView().validate();
Singletons.getView().pack();
Singletons.getView().repaint();

...which will be faster than if I commit/error/commit/error etc...then I'll cross that stuff off my suspects.

[Doublestrike]

Jiminy Christmas. OK back to it then. I did the debugging on a 64 bit (with 1.7 JDK I think, lazy to check)

`
Before we get too far into other hypotheticals, would it be worth the effort to see which version of java you are using?

Several issues in recent months appear to have been caused by a few people using an early version of java 7 and there may be incompatibilities. Many of us are still at java 6 and us Mac folks have no other option at this time but java 6.

Pretty sure that machine is 1.7. This one I'm on now is...JDK SE 6.27.

===

Incidentally, known bug - quest pets don't have summoning sickness currently. This is a result of r14000 and I'll fix soon.

[Chris H.]

Hmm, that's a good clue right there.

The repaint is up (r14008), probably won't work. I've got work in the morning so can't continue this excellent repartee but it's given me a new place to start looking - that button problem. Shooting in the dark over here, maybe will hit something :/

I think when the UI state is changed in the frame, perhaps things aren't validating correctly - could someone perhaps try various combinations of the following, in FControl, at the end of the "changeState" method:

Singletons.getView().validate();
Singletons.getView().pack();
Singletons.getView().repaint();

...which will be faster than if I commit/error/commit/error etc...then I'll cross that stuff off my suspects.

`
r14008 did not fix the problem.

The UI state change may be a good lead as I see things appearing and disappearing when I move the mouse pointer and/or click on components.

I see that we have these two lines at the end of FControl:

Singletons.getView().validate();
Singletons.getView().repaint();

[Sloth]

Jiminy Christmas. OK back to it then. I did the debugging on a 64 bit (with 1.7 JDK I think, lazy to check)

`
Before we get too far into other hypotheticals, would it be worth the effort to see which version of java you are using?

Several issues in recent months appear to have been caused by a few people using an early version of java 7 and there may be incompatibilities. Many of us are still at java 6 and us Mac folks have no other option at this time but java 6.

I'm using r14008 with Windows XP and Java 1.6 and those artifacts are still there (exactly like Chris describes).

[Chris H.]

Singletons.getView().validate();
Singletons.getView().pack();
Singletons.getView().repaint();

`
Same graphics issues but now the window is resized to the min 800 x 600 size.

[Chris H.]

Singletons.getView().validate();
Singletons.getView().pack();
Singletons.getView().repaint();

`
Same graphics issues but now the window is resized to the min 800 x 600 size.

`
I tried a number of combinations and not just the three together. The results do not appear to change anything except that the .pack() command resizes the window.

[friarsol]

Incidentally, known bug - quest pets don't have summoning sickness currently. This is a result of r14000 and I'll fix soon.

Sloth changed this so cards like Sleeper Agent would lose summoning sickness appropriately. I think there needs to be a way that cards starting on the Battlefield via Forge Rules don't lose summoning sickness on their first turn.

[Doublestrike]

@sol - ok great thanks, one less "oh no".

@Chris - thanks, those were the expected results ("pack" forces the minimum size on everything). Crossed off.

Next attempt is up.

Had a look at the old button problem and nothing of interest showed itself. Will have to install a virtual machine and develop on that to fix this. Does anyone have any suggestions? Sort of at the end of my rope, mostly because I can't repro :/

The boxes I'm currently testing on are Win7x64 JRE 1.7.0 and Win7x86 JRE 1.6.27.

[Doublestrike]

OK, I assume that last attempt (r14025) did not take?

I'm going to at least provide some functionality, a little at a time, and we'll see where it breaks. This way, afflicted users can still work in the meantime.

So, r14026 is the panel with only background color drawn.

There should be:
- rounded panels
- no border
- theme background color visible
- hover effects enabled
- no visual artifacts on resize
- no visual artifacts after deck editor open/close

Is everyone ok?

[Chris H.]

OK, I assume that last attempt (r14025) did not take?

I'm going to at least provide some functionality, a little at a time, and we'll see where it breaks. This way, afflicted users can still work in the meantime.

So, r14026 is the panel with only background color drawn.

There should be:
- rounded panels
- no border
- theme background color visible
- hover effects enabled
- no visual artifacts on resize
- no visual artifacts after deck editor open/close

Is everyone ok?

`
I updated to rev 14025 and Bugfix attempt #6 does not appear to make much of a difference. I think that everyone else is seeing the same sort of graphic artifact issues that I am seeing. I fear that the rest of us are kind of at a loss.

I then updated to 14026 and things look just like what you are now seeing.

[Doublestrike]

Yeah, apparently some see the visual artifacts, and some don't...

OK well that's good then about 14026. Bumping up to the next level.

14027: Same as before, but now with a background texture.

[Chris H.]

OK well that's good then about 14026. Bumping up to the next level.

14027: Same as before, but now with a background texture.

`
14027 has brought back the problem again:


Edit:


It is getting late in my time zone and my wife says that it is time to get some sleep.

I will check back in tomorrow when I get up.

`

[Doublestrike]

Ah HAH - it's the clip then. Like a breath of fresh air. Thanks Chris.

[Doublestrike]

I think I've got it now. How does r14030 look?

[slapshot5]

Not good:

Exception | Open

This is a Crash Report. An error has occurred. Please save this message to a file.
Please follow the instructions at this address to submit this Crash Report, plus what you were doing at the time:
http://tinyurl.com/3zzrnyb
Reporting bugs in Forge is very important. We thank you for your time.

null


Version:
Forge version SVN

OS: Mac OS X Version: 10.6.8 Architecture: x86_64

Java Version: 1.6.0_29 Vendor: Apple Inc.

Detailed error trace:
java.lang.NullPointerException
at forge.view.bazaar.ViewStall.updateStall(ViewStall.java:147)
at forge.view.ViewBazaarUI$2.run(ViewBazaarUI.java:77)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:677)
at java.awt.EventQueue.access$000(EventQueue.java:85)
at java.awt.EventQueue$1.run(EventQueue.java:638)
at java.awt.EventQueue$1.run(EventQueue.java:636)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.AccessControlContext$1.doIntersectionPrivilege(AccessControlContext.java:87)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:647)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:296)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:211)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:196)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:188)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:122)

-slapshot5