It is currently 23 May 2024, 16:12
   
Text Size

r22979 : New Forge Menubar

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

r22979 : New Forge Menubar

Postby spr » 21 Aug 2013, 01:21

Introducing the new Forge menu bar (update 1 of 2).
- This update contains two common menus that will always be displayed regardless of the active view/screen.
- Forge menu contains Exit and Restart options.
- Help menu contains links to online articles and the local TXT files.

Part 2 will include new menus for the duel/match screen and enable any view to add its own menus to the menubar.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby Max mtg » 21 Aug 2013, 04:24

To my opinion, a menubar makes Forge (or just any game) look less like a game and more like an application to perform some job duties.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: r22979 : New Forge Menubar

Postby spr » 21 Aug 2013, 05:24

Max mtg wrote:To my opinion, a menubar makes Forge (or just any game) look less like a game and more like an application to perform some job duties.
I wanted an option to hide the tabs on the game screen and a menu mechanism was the easiest to implement. Personally, I find it works well and I think it opens up the opportunity to declutter, certainly the game screen, but probably other views as well. But I can add a GUI setting to toggle the menubar on or off easily enough. In the meantime, you can set UI_HIDE_MENUBAR to true in forge.preferences to turn it off.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby LordHelmchen » 21 Aug 2013, 11:42

My two cents, in case anyone cares:
A Menu bar is a tried and working way to quickly access a number of actions that are used seldomly, leaving more screen estate for the core functions.
We're dealing with two layers of abstration already: a computer prgramm that simulates a card game that simulates epic wizard battles. I would think breaking immersion only a secondary concern here...
LordHelmchen
 
Posts: 125
Joined: 21 Aug 2012, 16:06
Has thanked: 21 times
Been thanked: 32 times

Re: r22979 : New Forge Menubar

Postby moomarc » 21 Aug 2013, 20:31

Perhaps the solution would be to have the menu hidden until a hotkey is pressed? Alt in most programs would give focus to the menu bar and isn't tied to any other shortcuts by default so maybe it would work?
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: r22979 : New Forge Menubar

Postby spr » 21 Aug 2013, 20:39

moomarc wrote:Perhaps the solution would be to have the menu hidden until a hotkey is pressed? Alt in most programs would give focus to the menu bar and isn't tied to any other shortcuts by default so maybe it would work?
That's a good idea.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby moomarc » 21 Aug 2013, 20:42

If we go that route then F1 might also be a good option and fairly intuitive.
-Marc
User avatar
moomarc
Pixel Commander
 
Posts: 2091
Joined: 04 Jun 2010, 15:22
Location: Johannesburg, South Africa
Has thanked: 371 times
Been thanked: 372 times

Re: r22979 : New Forge Menubar

Postby spr » 21 Aug 2013, 21:53

moomarc wrote:If we go that route then F1 might also be a good option and fairly intuitive.
Lets go with F1 initially and see how that is received. On Windows, F1 tends to be used to show help but I think this fits nicely with idea of the menu bar offering additional help and options. Since this F1 solution is so convenient we can use this instead of creating a user setting to toggle visibility. I intend to include this as part of the next update which should be released in the next day or so.

Thanks moomarc - that was a great idea! Sometimes as a developer I can't see the wood for the trees.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby Max mtg » 22 Aug 2013, 06:16

Most games have a menu that is shown at the center of your screen when ESC is pressed.
Besides that menu, most commonly used screens have shortcuts represented by icons docked to an edge of window.
Single class for single responsibility.
Max mtg
Programmer
 
Posts: 1997
Joined: 02 Jul 2011, 14:26
Has thanked: 173 times
Been thanked: 334 times

Re: r22979 : New Forge Menubar

Postby spr » 22 Aug 2013, 07:53

r22995
- Menu bar visibility can be toggled using F1 key.
- Hints or status info can be displayed on the right-hand side of the menu bar.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby Marek14 » 22 Aug 2013, 10:01

Will it allow toggling sound on/off from within a duel?
Marek14
Tester
 
Posts: 2763
Joined: 07 Jun 2008, 07:54
Has thanked: 0 time
Been thanked: 297 times

Re: r22979 : New Forge Menubar

Postby spr » 22 Aug 2013, 10:47

r22997
- New menus added to the match screen menu bar. All options that are in the Dock and DevMode panels are implemented.
- - Game = Dock panel options.
- - Layout = Dock panel options.
- - Dev = DevMode panel options.

The menu bar can now be updated by any screen/view with its own menus by calling
"Singletons.getControl().getMenuBar().setupMenuBar(<IMenuProvider>)". You need to supply a class that implements the very simple IMenuProvider interface.

You can also display progress status, hints and tips at the right hand side of the menu bar by calling Singletons.getControl().getMenuBar().setStatusText().

Still to come :
- Removal of Dock and DevMode panels from the match screen.
- Option to hide tabs.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby spr » 22 Aug 2013, 10:54

Marek14 wrote:Will it allow toggling sound on/off from within a duel?
No reason why not. I would imagine their are quite a few settings that could be migrated from the preferences page to the menu bar - for example, I have already moved the the "Toggle Background" option into the Layout menu.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Re: r22979 : New Forge Menubar

Postby Diogenes » 22 Aug 2013, 13:57

Looks great so far, Steve. :)

I disagree strongly with the removal of the dock panel, however. It's incredibly useful, and places frequently used options in the middle of the screen right where the cursor wants to be. Its location is customizable, so users can already hide it if they feel it's cluttering their space. I, personally, very much want it to stay.

Also, not all users use keyboard shortcuts, and those on tablets might not have a physical keyboard at all; the large buttons in the dock probably help them out a lot. I think the dock can even be a useful aid to the menu bar, it's a good place to put a button to hide/expand it for users without keyboards.

I'm looking forward to seeing things incorporated into the new bar (can the card overlay settings go under the targeting arc options?) Thanks for doing all this work!
Diogenes
 
Posts: 201
Joined: 12 Jul 2012, 00:54
Has thanked: 39 times
Been thanked: 23 times

Re: r22979 : New Forge Menubar

Postby spr » 22 Aug 2013, 16:40

r23000
- Added option to hide panel tabs to Layout menu.

Please note in the case of a multi-tab panel then only the active panel will be displayed. However, if the Combat and Stack tabs are in the same panel then whichever is active will be displayed which is quite a nice side effect.

Cheers,
Steve
User avatar
spr
 
Posts: 213
Joined: 06 Jul 2013, 19:31
Has thanked: 28 times
Been thanked: 60 times

Next

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 26 guests


Who is online

In total there are 26 users online :: 0 registered, 0 hidden and 26 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 26 guests

Login Form