Max mtg wrote:This padding looks better
I agree. Looking good, Dan. Also, thanks for little bits of refactoring you did, in particular the change to the scroll pane, and then for fixing up my listeners and adapters. I tried, but I could only work out so much. Hope the file wasn't too difficult to navigate. I did try to keep related things near each other to make it easier for anyone else to look through.
Max mtg wrote:Remove messages like "Focus changed to player 3" from console.
I've removed the last two console messages that were still left in there from early work.
Max mtg wrote:See what it looks like on brighter skins, and in minimal window size.
I'm having a look at the inactive player tab colors and came across some other configurations that work quite well across almost all the skins:
- CLR_BORDER @ 70-80 alpha, CLR_INACTIVE @ 80-110 alpha, CLR_TEXT @ 70 alpha. The text colour is actually the best for contrast across the most themes, but it isn't always the best looking. Try them out in line 68 of VSubmenuConstructed, and let me know. I think the current colour is probably still the best, so maybe just adjust alpha to 100 from 120?
As for half the panel being hidden on smaller screens, I'll have a look too. I'll post here if I fix it before Dan gets to it.
Max mtg wrote:Filters -> Add -> Quest World - does make any sense for custom user decks?
I think it still has a place. Some people like to build decks outside of quest mode to try out in usual constructed before they risk their win/loss record in the actual quest. It basically acts as additional format filters, so in my opinion it can be left in there.