Forge version 1.5.13

[Hellfish]

Oops, the new TriggerReplacementBase wasn't properly added, it seems.
Sorry about that, does it work now?

[Max mtg]

24775:

1 error remains:

Code: Select all

 
Description   Resource   Path   Location   Type
Type mismatch: cannot convert from element type ReplacementEffect to CardTraitBase   StaticEffects.java   /forge-game/src/main/java/forge/game   line 226   Java Problem


[Hellfish]

I'm not sure why you should be getting that since ReplacementEffect extends TriggerReplacementBase which extends CardTraitBase.. Does it conflict with your local changes somehow?
Still, I changed that line since I think IDEA was a little overzealous with refactoring.

[Agetian]

Stock r24776 compiles for me now.

- Agetian

[Max mtg]

My local changes are fine now,
I'm able to fix that error myself (by adjusting the type of iterable element)

Stock r24776 passes compilation.

[Hellfish]

Great, thanks for notifying me.

[Agetian]

Am I correct assuming that Modern Masters should have 1 foil in every booster?
http://wiki.mtgsalvation.com/article/Modern_Masters
(I updated the chance representation so that it correctly corresponds to a 100% chance of getting a foil in MMA, just need a confirmation that the fact that every MMA booster has a foil in it is indeed correct).

- Agetian

[Max mtg]

Just commmited ai's desicionmaking moved away from SpellAbilities - that is no more methods like canPlayAi or doTrigger in purely game classes

[Agetian]

Ok, I'm a bit confused with the standard chance of a foil appearing in a booster... Please take a look here:
http://wiki.mtgsalvation.com/article/Foil_card
It says that "on the average there is a 1 in 70 chance of getting a foil in a booster pack". And then it says that it approximates to roughly "one in every six or seven booster packs". I don't get why the first equates to the second, to be honest, and I'm not sure what would be the closer approximation of foil generation in boosters for Forge:
1) either 1:6 (one in six chance of appearing) is 16.67%, which is the current Forge default (or 1:7, or whatever),
2) or 1:70 (one in seventy as in the first statement on MTG wiki) is much less - roughly 1.43%.

I understand that statistically 1:6 is probably more often than once in six or seven booster packs, but it feels like 1:70 is definitely much less than once in six or seven booster packs... Rolling 99 or 100 on a 100-sided die (which would represent a 2% chance) does not happen every six or seven rolls on the average, that's for sure. As of right now, 1:6 feels a bit like "too often", while 1:70 would most probably feel "too rare". :\

So, what should we do here? What would be a closer and sane approximation of the foil generation chance for Forge, does anyone know?

P.S. will probably switch to 1:70 for the default (per MTG wiki) for a while and see how that goes.

- Agetian

[Max mtg]

1:70 - means if you rip all boosters, every 70th card will be foiled. It evaluates to 0,2(142857) chance to have a foil per booster. Pretty matches my unboxing experience - 6-8 foils found in a booster box, with 1 rare, 2 uncommons, 4 commons, 1 basic land

[Agetian]

Ohh so it's 1:70 as far as cards go, not as far as boosters go (every 70th card). 0.2142857 per booster (21.4% chance of a foil in booster) would stand for approximately 1:5 then as far as boosters go if I understand correctly... Thanks for the clarification!

EDIT: r24792 now uses 21.43% as a chance of a foil appearing in a booster pack. Had to revert back to the original (uglier) representation of the chance in edition files for now though (since, for example, 21.43% is neither 1:5 [20%] nor 1:6 [16.7%]. So, for now, foil chance in edition files is represented as a fraction of 10000).

- Agetian

[Agetian]

Ok, there's still something odd going on in the booster generation that I can't solve, I would really welcome your assistance here... For some reason, sometimes two normal (non-foil) rares will be generated in Modern Masters boosters when a foil card (non-rare) is present (easily enough reproduced on booster drafts). Not sure how this happens, I'm yet unable to find the cause why this is happening. Here's an example:

Vivid Grove is an uncommon foil generated in this booster pack. There are two rares to the left of it, which is odd. Please help if possible, thanks in advance!

P.S. This doesn't always happen. In many cases, only one rare will be generated (if it's a non-foil rare and the foil is non-rare). In many other cases, two rares will be generated, one foil and one non-foil. Both of these cases are correct. However, sometimes there will be two non-foil rares *and* a foil card (not rare) in a booster :\

- Agetian

[Max mtg]

There's a wrong booster specification

Code: Select all

Booster=10 Common, 3 Uncommon, 1 RareMythic, 1 Any


Remove "1 Any", change it to just 11 commons. with 100% chance to get a foil in COMMON slot this definition will work as intended

And there arises a question: which editions do not use FoilAlwaysInCommonSlot=True ? Can we just hardcode that foil always takes the common slot?

[Agetian]

Umm I wonder what that 1 Any was for... Anyhow, will remove it then.

And no, there were indeed two ways foils were printed (historically). According to MTG wiki:

Code: Select all

Prior to Time Spiral, if a booster pack contained a foil card it used to replace the card normally found in that rarity. (i.e. the card Shared Triumph is rare, if there was a foil version in a pack it would replace the card found in the rare slot). In every set starting with Time Spiral, a foil card replaces a common card regardless of the rarity of the foil card. [3] This means there is a chance of getting two (or three in the Innistrad or Dark Ascension packs due to the double sided card slot) rares (even mythics] in a single booster pack: one foil, and one regular (as well as one double sided in the aforementioned sets).


So, there are quite a few editions that work a different way from a foil always taking the common slot, so hardcoding it to always be in the common slot would not be correct...

- Agetian

[Max mtg]

"1 Any" used to replace that foil of random rarity.

Then - if there are only a few editions where foil card replaces a card of the same rarity, then it is _that_ setting which should become non-default. The line "FoilAlwaysInCommonSlot=True" found in new edition files looks somewhat ugly. Also it turns out that the current foil insertion algorithm is wrong for those editions.