Keyword enhancement
Post MTG Forge Related Programming Questions Here
Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins
Re: Keyword enhancement
by Hellfish » 19 Apr 2014, 10:02
*Necromancy*
I had to duplicate a little work to get back to a better state, but actually having a branch should mitigate that in the future. As noted it does not build because it is not quite yet at the point I last reported again.I think the CardKeywords system should work with the new stuff now though, and besides that it's mostly a copy-paste slog to move from strings to the (monolithic, I know) enum and instance class. The enum and Instance class may need a little bit of fat trimmed as well (having multiples of any parameter type is only necessary rarely, for instance) but I thought it better to be inclusive.
Also, I had to add a small hack to be able to launch in the first place, as the res folder can't be found otherwise.
ALSO, thanks to swordshine (and anyone else I might've missed :S ) for helping remove excess keywords.
I had to duplicate a little work to get back to a better state, but actually having a branch should mitigate that in the future. As noted it does not build because it is not quite yet at the point I last reported again.I think the CardKeywords system should work with the new stuff now though, and besides that it's mostly a copy-paste slog to move from strings to the (monolithic, I know) enum and instance class. The enum and Instance class may need a little bit of fat trimmed as well (having multiples of any parameter type is only necessary rarely, for instance) but I thought it better to be inclusive.
Also, I had to add a small hack to be able to launch in the first place, as the res folder can't be found otherwise.
ALSO, thanks to swordshine (and anyone else I might've missed :S ) for helping remove excess keywords.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Keyword enhancement
by drdev » 19 Apr 2014, 12:47
What hack are you referring to? You shouldn't be hard-coding "res/" anywhere anymore. You should use ForgeConstants. And if this code is not in the GUI code, you should pass the path from forge-gui.Hellfish wrote:*Necromancy*
...
Also, I had to add a small hack to be able to launch in the first place, as the res folder can't be found otherwise.
...
- drdev
- Programmer
- Posts: 1958
- Joined: 27 Jul 2013, 02:07
- Has thanked: 189 times
- Been thanked: 565 times
Re: Keyword enhancement
by Hellfish » 19 Apr 2014, 15:40
I had to trim out the first "../" from ForgeConstants.INSTALL_ROOT to be able to run from idea. I'm running the Main in forge-gui-desktop.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
Re: Keyword enhancement
by friarsol » 19 Apr 2014, 17:35
I use IntelliJ IDEA too and didn't need to do this.Hellfish wrote:I had to trim out the first "../" from ForgeConstants.INSTALL_ROOT to be able to run from idea. I'm running the Main in forge-gui-desktop.
My main class is forge.view.Main
My working dir is: <forgeParent>\forge\forge-gui-desktop
My classpath is forge-gui-desktop
- friarsol
- Global Moderator
- Posts: 7593
- Joined: 15 May 2010, 04:20
- Has thanked: 243 times
- Been thanked: 965 times
Re: Keyword enhancement
by Hellfish » 28 Apr 2014, 06:14
Well, crashing svn, that's a first. Not error message -> no commit, a full on stack dump crash to commandline.
I'll have to grab the branch from scratch again when I have time, I guess.
I'll have to grab the branch from scratch again when I have time, I guess.
So now you're
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
Screaming for the blood of the cookie monster
Evil puppet demon of obesity
Time to change the tune of his fearful ballad
C is for "Lettuce," that's good enough for me
-
Hellfish - Programmer
- Posts: 1297
- Joined: 07 Jun 2009, 10:41
- Location: South of the Pumphouse
- Has thanked: 110 times
- Been thanked: 169 times
20 posts
• Page 2 of 2 • 1, 2
Who is online
Users browsing this forum: No registered users and 65 guests