(mostly nonfunctional) GUI changes

[silly freak]

it's really not much:

-changed show() in Display to setVisible(boolean), so that no deprecated code is used
-changed the sizing code in the GuiDisplays to use the full screen (setExtendedState)
-reworked the downloading GUI. It now uses a progress bar, and is a little shorter

[mtgrares]

Thanks.

-changed show() in Display to setVisible(boolean), so that no deprecated code is used

I had to name the method in Display that showed things on the screen so I named it show() but if an object extends JFrame and implements Display the compiler will incorrectly say that you are using a depreciated method, which you aren't. The old show() method in GuiDisplay2 and GuiDisplay3 will have to be updated unless I'm wrong.

[Rob Cashwalker]

A rare Saturday appearance for rares....

[mtgrares]

Yeah, I keep a pretty regular schedule, . I love the Monday night show The Big Bang Theory, I'm afraid I'm half Sheldon and half Leonard.

[silly freak]

little update:

I added a standardized error reporting feature in the class ErrorViewer, which can save an error message to a file, including the stack trace.
I included it everywhere where it seemed meaningful - in existing catch blocks with explicit JOptionPane code, or just printStackTrace calls.
It's not included, for example, in the mana code, where a NumberFormatException is raised, intended to differentiate between colored and colorless mana.

the rar contains also all of my old changes, but it doesn't include the quick fix changes. I wouldn't mind to adapt them too if you point me to the source code

[DennisBergkamp]

Thanks for these, silly freak No worries, I'm just merging your changes right now.

[DennisBergkamp]

After merging these changes, I'm getting two errors:

in Gui_NewGame, line 553:

Code: Select all

AllZone.Display.show();

(the method show is undefined for the type Display)


in ErrorViewer.java, line 90 :

Code: Select all

 public void actionPerformed(ActionEvent e) {

(the actionPerformed(ActionEvent) of type new ActionListener(){} must override a superclass method)

Help!

[silly freak]

show() is replaced with setVisible(boolean) in my version, all classes using it are changed accordingly (that's the main reason why there are so many changed classes )

for ErrorViewer, i think this must be a missing import, though i don't get any errors. The @Override fails as long as the parameter classes aren't imported.

I hope this fixes the errors

[mtgrares]

I added a standardized error reporting feature in the class ErrorViewer, which can save an error message to a file, including the stack trace.

That sounds very good. Feel free to setup some sort of source code control like CVS or SVN. I know that manually making changes is very hard.

[DennisBergkamp]

show() is replaced with setVisible(boolean) in my version, all classes using it are changed accordingly (that's the main reason why there are so many changed classes )

for ErrorViewer, i think this must be a missing import, though i don't get any errors. The @Override fails as long as the parameter classes aren't imported.

I hope this fixes the errors

Oops, it seems I completely forgot to merge your changes in Gui_NewGame Either that, or I forgot to save the file.
But I'm still getting the @Override error in ErrorViewer.java... I just removed it for now, to prevent my eclipse from complaining.

[DennisBergkamp]

There's a few other things I've noticed:

- A lot of errors apparently get generated during my test matches, when getConvertedManaCost is called on manacosts that contain characters (try catch block with parseInt(cost) is called everytime). Anyway, it's always done this but the error was just never shown I've fixed this with a regular expression in CardUtil, it shouldn't try the parseInt anymore if there's a character in the manacost.
I do like the error viewer though, this should really help in the future and errors can just be saved + uploaded
- The look and feel of the GUI has changed ? I'm not sure I like the changes... is there a way to use the previous look?
- I still had quite a few pictures to download (Chris had sent me a bunch which I hadn't downloaded yet), but I'm not seeing a progress bar as I'm downloading them...

[silly freak]

- A lot of errors apparently get generated during my test matches, when getConvertedManaCost is called on manacosts that contain characters (try catch block with parseInt(cost) is called everytime). Anyway, it's always done this but the error was just never shown I've fixed this with a regular expression in CardUtil, it shouldn't try the parseInt anymore if there's a character in the manacost.
I do like the error viewer though, this should really help in the future and errors can just be saved + uploaded

Sorry, i have overseen that. The catch block below was commented that it is acceptable for an exception to be thrown, and so I have thought i'm on the save side. well, so goes life.

- The look and feel of the GUI has changed ? I'm not sure I like the changes... is there a way to use the previous look?

that was a very stupid mistake of mine. it's
Gui_NewGame, line 85

Code: Select all

old: UIManager.put(properties, background);
new: UIManager.put(properties[i], background);


it happens more often to me than it should...

- I still had quite a few pictures to download (Chris had sent me a bunch which I hadn't downloaded yet), but I'm not seeing a progress bar as I'm downloading them...

i can't explain that... for me, it looks like this:

Download.png

is it just the progress bar, or the whole window?

[DennisBergkamp]

Silly Freak,

That progress bar looks awesome!!!! No, for me it just looks like the regular window. I might have missed another thing from your merge
Anyway, I'm flying back to the US tomorrow, I'll play around with this while I'm on the plane.

[silly freak]

i have an idea...
Gui_DownloadPictures has a main method in my version. it should work relatively independent from the rest of the application, so at least that should work. otherwise there is something very weird going on...

[DennisBergkamp]

Ah, yes I messed up. It works now! Looks awesome, great great job silly freak

I did also have to remove some of the @Override in that file though to shut up my Eclipse, but at least it's working now