It is currently 19 Apr 2024, 18:29
   
Text Size

[Patch] Forge inline card image acquirer

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: [Patch] Forge inline card image acquirer

Postby ShoujoQ » 13 Apr 2015, 09:54

Doesn't work with JOU and KTK cards for some reason, eg. Battlefield Thaumaturge and Icy Blast.

Running 1.5.38 on Windows 7.
The idol in the mirror is reflected with certainty...
User avatar
ShoujoQ
 
Posts: 14
Joined: 09 Mar 2015, 09:15
Location: The Meta Board
Has thanked: 3 times
Been thanked: 1 time

Re: [Patch] Forge inline card image acquirer

Postby jkarlsson » 13 Apr 2015, 16:11

Sadly, since mtgimage was shutdown this patch does not work at all. I gave in and downloaded all images and moved on.
jkarlsson
 
Posts: 3
Joined: 07 Nov 2014, 23:39
Has thanked: 0 time
Been thanked: 0 time

Re: [Patch] Forge inline card image acquirer

Postby ShoujoQ » 13 Apr 2015, 16:27

jkarlsson wrote:Sadly, since mtgimage was shutdown this patch does not work at all. I gave in and downloaded all images and moved on.
I did that too and it still didn't download anything from these sets.

A shame you can't just scrape them from Gatherer.
The idol in the mirror is reflected with certainty...
User avatar
ShoujoQ
 
Posts: 14
Joined: 09 Mar 2015, 09:15
Location: The Meta Board
Has thanked: 3 times
Been thanked: 1 time

Re: [Patch] Forge inline card image acquirer

Postby Myrd » 26 Dec 2015, 04:21

I just landed a patch that implements auto card fetching in a way that avoids some of the problems of the original patch.

It uses the card picture URL that's in Forge's card DB, e.g.:

SVar:Picture:http://www.wizards.com/global/images/magic/general/sun_titan.jpg

It's the same parameter that's used by Forge's LQ card downloader. If a card does not work, it's possible it's a problem with the URL in the text file for the card.
Myrd
 
Posts: 87
Joined: 24 Nov 2014, 05:58
Has thanked: 4 times
Been thanked: 32 times

Re: [Patch] Forge inline card image acquirer

Postby friarsol » 26 Jan 2016, 13:44

Hey Myrd,

I've temporarily disabled the Fetcher for this upcoming release, just so we can get some more structure around it. I've seen a few people concerned about it's "always on" state, so we probably want it to be settable as a preference. For now I'd recommend it as opt-in, but maybe you can convince me it should be opt-out.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: [Patch] Forge inline card image acquirer

Postby friarsol » 11 Feb 2016, 02:39

This looks like it isn't working anymore. Magiccards.info is sending a "file closed unexpectedly" or "reached end of file" or something like that.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Previous

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 45 guests


Who is online

In total there are 45 users online :: 0 registered, 0 hidden and 45 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 45 guests

Login Form