It is currently 18 Apr 2024, 21:32
   
Text Size

Forge version 1.5.33

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Forge version 1.5.33

Postby Chris H. » 06 Jan 2015, 15:04

Tentative target release date: I need to fix my new dev system before I can give an estimate.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Forge version 1.5.33

Postby Agetian » 13 Jan 2015, 19:09

A rather serious visual issue that interferes with gameplay and largely breaks it (when encountered) was reported here:
viewtopic.php?f=52&t=6333&p=171245#p171245

Just a heads-up here because I think it's something that is worth resolving before the next beta if anybody knows what's up (there aren't too many Phasing cards out there but playing with older sets potentially makes running into this bug a risk).

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Forge version 1.5.33

Postby Agetian » 15 Jan 2015, 17:42

In continuation of my reports of the Phasing issue, it looks like something is even more majorly up than I originally imagined - it's not purely a visual issue, but the game state itself becomes broken beyond broken when a card with Phasing comes into the picture. It looks like all the cards save one disappear not only from the UI but from the game state as well when e.g. a land is played with a phased out card present on the battlefield, for instance, I'm not able to auto-tap the lands that I know should be present on the battlefield but are not visualized.

Still can't find the possible source of this... can anyone more knowledgeable about this part of the code please help?

EDIT: I figured out that this was broken by r27845 by Dan (drdev). It's a huge commit that has no direct references to phasing, so I have little idea what exactly broke it... Assistance needed. Thanks in advance.

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Forge version 1.5.33

Postby drdev » 16 Jan 2015, 02:57

I will investigate the Phasing issue as soon as I can. Thanks for narrowing it down to that revision.

EDIT: Turned out to be a pretty easy fix in the end. Fixed in r28626.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Forge version 1.5.33

Postby elcnesh » 18 Jan 2015, 21:33

Maybe it's a bit off-schedule, but can we go for a release ASAP? Some critical bugs were fixed + FRF was released :) And I have a ton of semi-experimental changes staged that I'm waiting to commit until a stable version is released that includes the new set.

PS @ Dan: if you can find the time, could you take a look at this? http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=5035&start=375#p171247
It's an issue related to the (un)freezing of trackable objects.

Edit: typo
elcnesh
 
Posts: 290
Joined: 16 May 2014, 15:11
Location: Netherlands
Has thanked: 34 times
Been thanked: 92 times

Re: Forge version 1.5.33

Postby drdev » 18 Jan 2015, 22:36

elcnesh wrote:Maybe it's a bit off-schedule, but can we go for a release ASAP? Some critical bugs were fixed + FRF was released :) And I have a ton of semi-experimental changes staged that I'm waiting to commit until a stable version is released that includes the new set.

PS @ Dan: if you can find the time, could you take a look at this? http://www.slightlymagic.net/forum/viewtopic.php?f=52&t=5035&start=375#p171247
It's an issue related to the (un)freezing of trackable objects.

Edit: typo
Sure, I can take a look. Have you been able to properly fix the CopyPermanent issue so it uses the controller rather than the activator?
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Forge version 1.5.33

Postby Agetian » 19 Jan 2015, 05:19

elcnesh wrote:Maybe it's a bit off-schedule, but can we go for a release ASAP? Some critical bugs were fixed + FRF was released :) And I have a ton of semi-experimental changes staged that I'm waiting to commit until a stable version is released that includes the new set.
I agree. Also, if we can squeeze in a solution for freezing/unfreezing trackable objects it would be nice, and overall a lot was fixed (including whole modes, such as Momir, and whole game mechanics that used to break the entire game, such as Phasing and Devour).

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Forge version 1.5.33

Postby elcnesh » 19 Jan 2015, 09:00

drdev wrote:Have you been able to properly fix the CopyPermanent issue so it uses the controller rather than the activator?
Yup, r28663.
elcnesh
 
Posts: 290
Joined: 16 May 2014, 15:11
Location: Netherlands
Has thanked: 34 times
Been thanked: 92 times

Re: Forge version 1.5.33

Postby drdev » 20 Jan 2015, 02:16

Agetian wrote:
elcnesh wrote:Maybe it's a bit off-schedule, but can we go for a release ASAP? Some critical bugs were fixed + FRF was released :) And I have a ton of semi-experimental changes staged that I'm waiting to commit until a stable version is released that includes the new set.
I agree. Also, if we can squeeze in a solution for freezing/unfreezing trackable objects it would be nice, and overall a lot was fixed (including whole modes, such as Momir, and whole game mechanics that used to break the entire game, such as Phasing and Devour).

- Agetian
Solution squeezed in with r28666. Are we ready to release a new Beta then? I'll update the mobile app once that's done.
drdev
Programmer
 
Posts: 1958
Joined: 27 Jul 2013, 02:07
Has thanked: 189 times
Been thanked: 565 times

Re: Forge version 1.5.33

Postby Agetian » 20 Jan 2015, 05:57

I think that we are. :) Since Chris may not be able to release at this time, should we just link the hotfix snapshot (e.g. r28668) in the release thread or something? Or can anybody else take care of the release?


- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Forge version 1.5.33

Postby KrazyTheFox » 21 Jan 2015, 04:40

Hey guys,

I've just fixed a bug that was preventing printsheets from working correctly. Boosters for DGM and FRF (among others) should now be able to include cards from other sets as they're supposed to. This should also fix mana fixing for these sets in limited. I'm fairly confident that this fix didn't break anything, but if you all could open up a bunch of boosters for me to make sure I'd appreciate it. ;)

FRF also now contains the correct (until someone does the research on the real numbers) distribution of lands including some of the rare duals from KTK. See: http://magic.wizards.com/en/articles/archive/feature/fetching-look-fate-reforged-2014-12-24
User avatar
KrazyTheFox
Programmer
 
Posts: 725
Joined: 18 Mar 2014, 23:51
Has thanked: 66 times
Been thanked: 226 times

Re: Forge version 1.5.33

Postby Chris H. » 21 Jan 2015, 22:06

Agetian wrote:I think that we are. :) Since Chris may not be able to release at this time, should we just link the hotfix snapshot (e.g. r28668) in the release thread or something? Or can anybody else take care of the release?


- Agetian
 
Unfortunately, I have not yet been able to fix the problem on my end. At first I thought that it might have been a credentials problem but I now suspect that it is some sort of a JavaHL library problem.

If someone can run the Maven command for beta build and deploys on their computer I can then handle the beta release message.
User avatar
Chris H.
Forge Moderator
 
Posts: 6320
Joined: 04 Nov 2008, 12:11
Location: Mac OS X Yosemite
Has thanked: 644 times
Been thanked: 643 times

Re: Forge version 1.5.33

Postby Agetian » 22 Jan 2015, 16:41

Does anybody know the correct invocation for the beta build publish and release?

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Re: Forge version 1.5.33

Postby KrazyTheFox » 22 Jan 2015, 16:58

Agetian wrote:Does anybody know the correct invocation for the beta build publish and release?

- Agetian
I sent it to elcnesh a little while ago and Chris would also know. If you don't get it by the time I get home I can either run it myself or send it your way.
User avatar
KrazyTheFox
Programmer
 
Posts: 725
Joined: 18 Mar 2014, 23:51
Has thanked: 66 times
Been thanked: 226 times

Re: Forge version 1.5.33

Postby Agetian » 22 Jan 2015, 17:20

KrazyTheFox wrote:
Agetian wrote:Does anybody know the correct invocation for the beta build publish and release?

- Agetian
I sent it to elcnesh a little while ago and Chris would also know. If you don't get it by the time I get home I can either run it myself or send it your way.
Okie doke, thanks a lot and feel free to run it! :) (and I'd also like to know just in case ;))

- Agetian
Agetian
Programmer
 
Posts: 3471
Joined: 14 Mar 2011, 05:58
Has thanked: 676 times
Been thanked: 561 times

Next

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 43 guests


Who is online

In total there are 43 users online :: 0 registered, 0 hidden and 43 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 43 guests

Login Form