Page 2 of 4

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 02 Oct 2016, 00:44
by Xitax
I also tried and failed. I might have to take pictures of packs again...

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 02 Oct 2016, 05:08
by Agetian
Would be nice if you could do it, Xitax! :)

- Agetian

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 06 Oct 2016, 12:50
by friarsol
Krazy, any chance you'll be able to roll another release this weekend? I'm not going to be around, but between everyone we should be able to fire it off and post the new version.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 08 Oct 2016, 07:04
by Agetian
In r32301 I updated Kaya, Ghost Assassin to get rid of the somewhat counterintuitive targeting mechanism where first you target a creature and then decide whether to exile the creature of Kaya herself. Things seem to work correctly according to my testing, but I'm not sure if maybe there was a bigger reason to implement it the way it was implemented. If there was a reason for that, let me know and I'll revert that part.

EDIT: Reverted it since apparently Kaya does not target herself (which is odd and tbh I would never have guessed that it has to work the way it has to work, lol).

- Agetian

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 08 Oct 2016, 09:25
by Hanmac
I am currently doing some tweaking of her first ability. Hope to get it finish before next release.
Need three four different way for:
  • Without Target: exile herself if she is still on the battlefield. (Do Check StrictlySelf)
  • With Target: if she does choose herself (StrictlySelf check too)
  • with Target: choose Target
  • Without Target: but no exile.

after reading some post I found the last in the list is possible too. Hm maybe I don't need to rewrite as much as I thought.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 08 Oct 2016, 13:49
by friarsol
Hanmac wrote:I am currently doing some tweaking of her first ability. Hope to get it finish before next release.
Need three four different way for:
  • Without Target: exile herself if she is still on the battlefield. (Do Check StrictlySelf)
  • With Target: if she does choose herself (StrictlySelf check too)
  • with Target: choose Target
  • Without Target: but no exile.

after reading some post I found the last in the list is possible too. Hm maybe I don't need to rewrite as much as I thought.
#2 doesn't matter. If she targets herself, and she's not on the battlefield the ability will fizzle

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 08 Oct 2016, 15:40
by Hanmac
@friarsol: no its like that:
if you do target a creature, and THEN choose that Kaya should exile herself she needs to be on the battlefield for that.

(Kaya does not target herself which is the main reason for that problem)

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 09 Oct 2016, 13:36
by KrazyTheFox
I can definitely get a new release out tomorrow.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 12 Oct 2016, 01:06
by friarsol
KrazyTheFox wrote:I can definitely get a new release out tomorrow.
Any luck?

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 14 Oct 2016, 14:25
by KrazyTheFox
Sorry, no. Plans unexpectedly changed and I ended up being busy for the past few days. I'll make another attempt today.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 14 Oct 2016, 15:06
by Agetian
Important: As of r32344, Forge for Android no longer compiles with the following error message:

Code: Select all
forge.game.card.Card: can't find referenced method 'void sort(java.util.Comparator)' in class java.util.List
[INFO]       You should check if you need to specify additional program jars.
This may be related to a change in Card.java implemented in r32344?.. The method in question is possibly missing in the Android SDK we're targeting.

- Agetian

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 14 Oct 2016, 15:07
by friarsol
Agetian wrote:Important: As of r32344, Forge for Android no longer compiles with the following error message:

Code: Select all
forge.game.card.Card: can't find referenced method 'void sort(java.util.Comparator)' in class java.util.List
[INFO]       You should check if you need to specify additional program jars.
This may be related to a change in Card.java implemented in r32344?.. The method in question is possibly missing in the Android SDK we're targeting.

- Agetian
Ah I'll check it out.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 14 Oct 2016, 15:24
by Agetian
Works now, thanks for the prompt resolution, Sol!

- Agetian

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 14 Oct 2016, 15:51
by friarsol
Agetian wrote:Works now, thanks for the prompt resolution, Sol!
Been doing a lot of Python lately, totally wasn't thinking that Java was finicky about how you have to sort.

Re: Upcoming Release: Forge version 1.5.57

PostPosted: 15 Oct 2016, 03:54
by KrazyTheFox
Before I do the release, is there anything notable that needs to be in the changes file?