by friarsol » 03 Jan 2017, 14:16
Are you sure that's new? I know the AI should do those things but I'm not sure if enough AI code was setup to make sure M2 wasn't passed if +Loyalty abilities were still available.Agetian wrote:I noticed rather recently that the AI sometimes "forgets" to use the + ability on a planeswalker even though there is no drawback to doing so, and will instead do nothing at all. For example, a common place to see it is AI casting Saheeli Rai and not doing anything at all with it on the first turn (though there is no drawback to +1'ing her). I've seen the same happen with at least several other planeswalkers that are all marked AI playable. Does anyone know what's going on?
by Agetian » 03 Jan 2017, 15:19
by Hanmac » 03 Jan 2017, 15:24
(Maybe some general case for PW (+) abilitites? )
by Hanmac » 05 Jan 2017, 08:15
The logic behind that is that damage can only be redirected or split if the other target is a creature or planeswalker in play or a Player in play.
My non commited tests does pass for my non commited card changes. I hope i got it finish until weekend.
by Hanmac » 05 Jan 2017, 18:12
by Agetian » 05 Jan 2017, 18:30
Yep, sounds like a plan! I'll go ahead and do that
EDIT: Done. Thanks for the suggestion, Hanmac! As a side note, sadly, haven't found a way to get a list of valid cards as CardCollection other than calling .threadSafeIterable() inside a call to CardsList.filter, is there a better way of handling that? :/
I mean this call:
- Code: Select all
Card donateTarget = ComputerUtil.getCardPreference(ai, sa.getHostCard(), "DonateMe", CardLists.filter(ai.getCardsIn(ZoneType.Battlefield).threadSafeIterable(), CardPredicates.hasSVar("DonateMe")));
by Hanmac » 05 Jan 2017, 19:57
i committed some changes for PumpAI. it does improve your changes for DonateAI more. now working with multiple opponents.
i also commited my changes for MoveCounter AI ... but i didnt commited the cards yet which should use that because its not finish yet. (guys feel free to extend it)
by Hanmac » 06 Jan 2017, 17:50
by Xitax » 07 Jan 2017, 03:55
- (273.45 KiB) Downloaded 10 times
by Agetian » 07 Jan 2017, 04:47
These look really good, Xitax! Should we maybe set their type to Online though (instead of Reprint) since they are MTGO only? (both Vintage Masters and Tempest Remastered are Type=Online)Xitax wrote:Here are Masters Editions edition files and booster pics. Please let me know if I goofed anything up!
I'll commit them unless there are objections from anyone else and once this is discussed.
by Hanmac » 07 Jan 2017, 10:30
moved preventDamage to GameEntity and refactor it a bit.
no need to have the same code in Card and Player.
i added TriggerDamagePrevented, with that Selfless Squire can be coded.
currently i didn't updated the cards yet on that place like i need to for Ajani Steadfast, but the tests does all pass and the cards should work like before.
PS: i did changed the order in preventDamage how the different parts are applied. i thought it now makes more sense (ShieldEffect after Static and ReplacementEffects)
by Agetian » 09 Jan 2017, 05:03
Who is online
Users browsing this forum: No registered users and 8 guests