Developing Bugs

[RumbleBBU]

I think I've found the commit that broke Fireball. It seems to be this one (17116):
http://svn.slightlymagic.net/websvn/dif ... &peg=17116

I tried replacing InputPayManaCostAbility.java with an earlier version, and presto, Fireball works again, no infinite recursion/stack overflow anymore.

Unfortunately, that disables the Phyrexian mana code in this commit.

Here's hoping that Sloth (who seems to have committed version 17116) chimes in and fixes it so that it behaves like he intended it to behave.

[Sloth]

I think I've found the commit that broke Fireball. It seems to be this one (17116):
http://svn.slightlymagic.net/websvn/dif ... &peg=17116

I tried replacing InputPayManaCostAbility.java with an earlier version, and presto, Fireball works again, no infinite recursion/stack overflow anymore.

Unfortunately, that disables the Phyrexian mana code in this commit.

Here's hoping that Sloth (who seems to have committed version 17116) chimes in and fixes it so that it behaves like he intended it to behave.

Fixed! Thanks RumbleBBU.

Oh these filthy hard-coded cards.

[RumbleBBU]

Good work, Sloth! Fireball works nicely again!

...and that was the last major SVN issue I've come across. Things are looking good for the next beta.

[friarsol]

Oh these filthy hard-coded cards.

Challenge accepted.

[Max mtg]

Oh these filthy hard-coded cards.

Challenge accepted.

Let me just commit the CardFactorySorceries where each spell is returned from its own function

... I'm done.

[Max mtg]

Broken everything

17274 has eliminated CardList but unfortuntelly along with playability. I am sorry.
Shall return to this problem in the morning

Upd: (in the monring) strange, it works. Why didn't it work yesterday's night?

[Sloth]

Broken everything

17274 has eliminated CardList but unfortuntelly along with playability. I am sorry.
Shall return to this problem in the morning

Upd: (in the monring) stragnge, it works. Why didn't it work yesterday's night?

I also thought the code was broken. Using the Project -> Clean... command did the trick for me.

[Hellfish]

There appears to be a problem with the Deck Editor filters, still. Searching for Bolt does not include Lightning Bolt for instance. Also, trying to clear the filters afterwards (by clearing the Contains field and pressing enter) only shows 1000 cards, with what rhyme or reason I do not know.

[Max mtg]

There appears to be a problem with the Deck Editor filters, still. Searching for Bolt does not include Lightning Bolt for instance. Also, trying to clear the filters afterwards (by clearing the Contains field and pressing enter) only shows 1000 cards, with what rhyme or reason I do not know.

Speaking of you -
http://svn.slightlymagic.net/websvn/dif ... &peg=17327
There you have removed any chance to get cards from any other player's zone besides stack

[Hellfish]

Yeah, sorry about that. I realised at about the same time I read your commit message

[Sloth]

There appears to be a problem with the Deck Editor filters, still. Searching for Bolt does not include Lightning Bolt for instance. Also, trying to clear the filters afterwards (by clearing the Contains field and pressing enter) only shows 1000 cards, with what rhyme or reason I do not know.

The filter is working fine. You have to uncheck the multicolor checkbox. The logic must have changed somehow.

[Max mtg]

There appears to be a problem with the Deck Editor filters, still. Searching for Bolt does not include Lightning Bolt for instance. Also, trying to clear the filters afterwards (by clearing the Contains field and pressing enter) only shows 1000 cards, with what rhyme or reason I do not know.

They were doing it wrong.
I have to fix that by myself =(.
Filtering by set just clears the list of cards

Look at r17335 - seems way better now, besides SFilterUtil.java is now 100 lines shorter

[Sloth]

Using 17364, i can't start a game. Clicking Start with a random deck, fixed deck or quest mode will always return to the home screen after the loading window appears briefly.

[ArsenalNut]

Using 17364, i can't start a game. Clicking Start with a random deck, fixed deck or quest mode will always return to the home screen after the loading window appears briefly.

Max Mtg's r17360 is the culprit. Max could you please at least try to start a game and play a little before you check in code.

[Max mtg]

Using 17364, i can't start a game. Clicking Start with a random deck, fixed deck or quest mode will always return to the home screen after the loading window appears briefly.

Max Mtg's r17360 is the culprit. Max could you please at least try to start a game and play a little before you check in code.

I gave up yesterday because r17364 by friarsol contained compilation errors.

Code: Select all

The method getOrderChoices(String, String, int, Object[], Object[]) in the type GuiChoose is not applicable for the arguments (String, String, int, Object[], null, Card)   AbilityFactoryClash.java   /Forge-devel/src/main/java/forge/card/abilityfactory   line 770   Java Problem
The method getOrderChoices(String, String, int, Object[], Object[]) in the type GuiChoose is not applicable for the arguments (String, String, int, Object[], null, Card)   AbilityFactoryReveal.java   /Forge-devel/src/main/java/forge/card/abilityfactory   line 2053   Java Problem
The method getOrderChoices(String, String, int, Object[], Object[]) in the type GuiChoose is not applicable for the arguments (String, String, int, Object[], null, null)   AbilityFactoryReveal.java   /Forge-devel/src/main/java/forge/card/abilityfactory   line 2417   Java Problem



The line with problem is:

Code: Select all

final List<Object> firstPile = GuiChoose.getOrderChoices("Place into two piles", "Pile 1", -1, pool.toArray(), null, card);