Developing Bugs

[ArsenalNut]

Some recent change has broken CardUtil.getThisTurnEntered. I tried a new Morbid card and it didn't work. Then I tried one that worked before and it didn't work either.

[Hellfish]

I'm guessing somewhere around r10528. I'll take a look and see if I can figure it out.

EDIT:Figured it out, the error may have been present earlier. Comparing a string and an Enum using .equals() is not the way to go.

[ArsenalNut]

While digging through the ManaPool code for issue #83 & #306, I found there is no reference in the rest of Forge to "removeManaFromFloating". This method is also the only caller of "removeManaFrom(final ArrayList<Mana> pool, final ManaCost mc, Card c)". As far as I can tell, these methods have been around since the change over from Git back to Subversion. Is there an etiquette for unused methods like these? Is it alright if I blow them away?

[friarsol]

I probably added those originally because I was planning on changing around how the ManaPool worked, but may not have actually changed it. If they don't seem useful in the future feel free to remove them.

[friarsol]

Edit: Nevermind. I hate Eclipse.

[friarsol]

Since cardforge is still down I'm going to post this here.

It looks like the AI is targeting himself with Keldon Marauders for both of it's triggers. Not sure what might have changed in these files, and I have no idea how long it has been like that.

[Sloth]

It looks like the AI is targeting himself with Keldon Marauders for both of it's triggers. Not sure what might have changed in these files, and I have no idea how long it has been like that.

Fixed! Thanks Sol.

[friarsol]

I don't have a chance to look into this, but I got this crash when I tried to Suspend Festering March

java.lang.NullPointerException
at forge.card.trigger.TriggerSpellAbilityCast.performTest(TriggerSpellAbilityCast.java:101)
at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:417)
at forge.card.trigger.TriggerHandler.runTrigger(TriggerHandler.java:340)
at forge.MagicStack.add(MagicStack.java:683)
at forge.gui.input.InputPayManaCost.done(InputPayManaCost.java:229)

[Sloth]

I don't have a chance to look into this, but I got this crash when I tried to Suspend Festering March

java.lang.NullPointerException
at forge.card.trigger.TriggerSpellAbilityCast.performTest(TriggerSpellAbilityCast.java:101)
at forge.card.trigger.TriggerHandler.runSingleTrigger(TriggerHandler.java:417)
at forge.card.trigger.TriggerHandler.runTrigger(TriggerHandler.java:340)
at forge.MagicStack.add(MagicStack.java:683)
at forge.gui.input.InputPayManaCost.done(InputPayManaCost.java:229)

Fixed! Thanks Sol!

[Doublestrike]

On my Windows x64 box I've got this red exclamation point over my whole project (see pic) in Eclipse. And of course, it won't compile.

I've tried checking the build path, tried updating Maven dependencies (with force), and even removed and checked out the whole project again from the SVN - no dice. I've tried a few google searches too.

Has anyone seen this or fixed it in the past? I'm running Windows x64 with Tortoise SVN and Eclipse IDE. Tortoise reports everything is OK (see pic).

[EDIT - Eclipse reports no other problems throughout the file structure ]

[Chris H.]

On my Windows x64 box I've got this red exclamation point over my whole project (see pic) in Eclipse. And of course, it won't compile.

I've tried checking the build path, tried updating Maven dependencies (with force), and even removed and checked out the whole project again from the SVN - no dice. I've tried a few google searches too.

Has anyone seen this or fixed it in the past? I'm running Windows x64 with Tortoise SVN and Eclipse IDE. Tortoise reports everything is OK (see pic).

[EDIT - Eclipse reports no other problems throughout the file structure ]

`
I was able to update to rev 13142 this morning and the project built and ran.

Have you tried a

Maven -> Update Project Configuration...

[silly freak]

look into the Problems tab. it means that there is a project error, not a code error. e.g. a jar file is missing, artifact not resolved etc.

[Doublestrike]

Thanks fellas, the "Problems" tab led me in the right direction, and what actually solved the problem was selecting the "Offline" checkbox in the "update configuration", which I hadn't been doing before. Don't know why that worked but it did, so I'm off and running.

[silly freak]

one thing I have now and then with maven is corrupt artifacts in the local repository. so, if maven/eclipse suggests that an artifact is missing or something, but you're sure it shouldn't be, what I do is to go into ~/.m2/repository/org/groupId/artifactId/1.0.0 and check the files. if they're not alright, just delete the 1.0.0 directory so that it's re-downloaded. i've found that "force update of releases/snapshots" doesn't work in some cases; manual deleting does.

[Doublestrike]

Funny that you mention that, I did notice that the fresh SVN copy would be OK, then I'd open Eclipse, which would be fine for a few moments, then it would turn evil on me.

It looked like Eclipse was changing the file, but I thought no, couldn't be that, right, I can trust the IDE not to screw with source files?!!!

We really need a "doggone Eclipse" smiley...