It is currently 23 Apr 2024, 13:14
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby Xyx » 16 Feb 2017, 00:12

Multiple Metallic Mimics choosing the same creature type do not affect each other (but they should.) I copied a Metallic Mimic with Kiki-Jiki, Mirror Breaker and chose Goblin just like for the first one, but the second one did not enter the battlefield with a counter (which it should have.)

There's some complicated layers magic at the root of this that I "only" understand for about 90% but fortunately you don't have to take my word for it: there's also a Gatherer ruling that backs this up.

EDIT: It worked as it should for a hardcast Metallic Mimic. So I guess it's just copies that are bugged.
User avatar
Xyx
Tester
 
Posts: 524
Joined: 23 Feb 2014, 23:01
Has thanked: 38 times
Been thanked: 32 times

Re: Bug Reports (snapshot builds)

Postby Xyx » 16 Feb 2017, 00:34

Here's a game state dump that reproduces the Kiki-Jiki, Mirror Breaker + Metallic Mimic bug.

Choose "Goblin" for the two mimics already there (just click OK), then use Kiki-Jiki on one of the mimics and choose "Goblin" again. The copy will enter the battlefield without counters but it should have two (one for each of the mimics already there.)
Attachments
201702160130 Metallic Mimic.txt
(2.52 KiB) Downloaded 185 times
User avatar
Xyx
Tester
 
Posts: 524
Joined: 23 Feb 2014, 23:01
Has thanked: 38 times
Been thanked: 32 times

Re: Bug Reports (snapshot builds)

Postby Xyx » 16 Feb 2017, 00:55

Here's a game dump that reproduces the rather fleeting "button focus missing" bug. To reproduce, Setup Game State via the Dev menu, then...
  1. Click End Turn. The AI will begin activating Scavenging Ooze EOT. Press the Y key to auto-yield to that.
  2. The AI will take its turn. Its Dark Confidant will trigger. Press Y to yield to that as well. It will reveal Verdant Catacombs. Hit OK/Enter to continue.
  3. The AI will play and crack Verdant Catacombs. Normally you should be able to pass priority by pressing Enter, but this time the focus won't be on either the OK or End Turn button.
Perhaps it depends on which stops you have set. I have all of them set to red except for my M1 and opponent's ET.

I tried a variant where I killed the Scavenging Ooze and dumped/setup the game state again, and from there the OK button would be focused. So, for some reason, that extra yield seems to matter.

Hopefully this bug is related to the "accidental skip through turn" bug that I can't replicate reliably.
Attachments
201702160147 No button focus.txt
(2.51 KiB) Downloaded 194 times
User avatar
Xyx
Tester
 
Posts: 524
Joined: 23 Feb 2014, 23:01
Has thanked: 38 times
Been thanked: 32 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 16 Feb 2017, 04:24

ClassCastExceptions reported above should be fixed upstream (that particular bug was tracked, explored and should be solved). Rule interaction bugs are, sadly, too time-demanding for me at the moment (the work amount has really "exploded" beyond proportion lately :/ ), I really hope someone else can take some of them for fixing...

- Agetian
Agetian
Programmer
 
Posts: 3472
Joined: 14 Mar 2011, 05:58
Has thanked: 677 times
Been thanked: 561 times

Re: Bug Reports (snapshot builds)

Postby fmartel » 16 Feb 2017, 16:57

Sometimes Forge will "AutoYeild" until next turn even if I did asked to "end Turn". I have my M2 action lit
fmartel
 
Posts: 281
Joined: 31 Dec 2013, 19:27
Location: Québec City
Has thanked: 8 times
Been thanked: 4 times

Re: Bug Reports (snapshot builds)

Postby Xyx » 16 Feb 2017, 21:07

I started paying attention to the OK/End Turn button focus and did notice that the End Turn buttons sometimes gets focus. I don't think that should ever get focus automatically. It makes you skip your turn if you press Enter at the wrong time.
User avatar
Xyx
Tester
 
Posts: 524
Joined: 23 Feb 2014, 23:01
Has thanked: 38 times
Been thanked: 32 times

Re: Bug Reports (snapshot builds)

Postby Xyx » 19 Feb 2017, 23:43

Description: Drew for the turn, then just clicked End Turn. Game crashed in my Cleanup.

ClassCastException | Open
Code: Select all
Forge Version:    1.5.60-SNAPSHOT-r-1
Operating System: Windows 10 10.0 x86
Java Version:     1.8.0_121 Oracle Corporation

java.lang.ClassCastException
   at javax.swing.LayoutComparator.compare(Unknown Source)
   at javax.swing.LayoutComparator.compare(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.legacyMergeSort(Unknown Source)
   at java.util.Arrays.sort(Unknown Source)
   at java.util.ArrayList.sort(Unknown Source)
   at java.util.Collections.sort(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.enumerateAndSortCycle(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getFocusTraversalCycle(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.LayoutFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getDefaultComponent(Unknown Source)
   at java.awt.Component.getNextFocusCandidate(Unknown Source)
   at java.awt.Component.transferFocus(Unknown Source)
   at java.awt.Component.setFocusable(Unknown Source)
   at forge.screens.match.CMatchUI.updateButtons(CMatchUI.java:575)
   at forge.match.AbstractGuiGame.updateButtons(AbstractGuiGame.java:266)
   at forge.match.AbstractGuiGame.autoPassCancel(AbstractGuiGame.java:292)
   at forge.player.PlayerControllerHuman.autoPassCancel(PlayerControllerHuman.java:2138)
   at forge.game.phase.PhaseHandler.onPhaseBegin(PhaseHandler.java:355)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:978)
   at forge.game.GameAction.startGame(GameAction.java:1472)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:221)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
User avatar
Xyx
Tester
 
Posts: 524
Joined: 23 Feb 2014, 23:01
Has thanked: 38 times
Been thanked: 32 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 20 Feb 2017, 04:08

Xyx wrote:Description: Drew for the turn, then just clicked End Turn. Game crashed in my Cleanup.

ClassCastException | Open
Code: Select all
Forge Version:    1.5.60-SNAPSHOT-r-1
Operating System: Windows 10 10.0 x86
Java Version:     1.8.0_121 Oracle Corporation

java.lang.ClassCastException
   at javax.swing.LayoutComparator.compare(Unknown Source)
   at javax.swing.LayoutComparator.compare(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.mergeSort(Unknown Source)
   at java.util.Arrays.legacyMergeSort(Unknown Source)
   at java.util.Arrays.sort(Unknown Source)
   at java.util.ArrayList.sort(Unknown Source)
   at java.util.Collections.sort(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.enumerateAndSortCycle(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getFocusTraversalCycle(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.LayoutFocusTraversalPolicy.getFirstComponent(Unknown Source)
   at javax.swing.SortingFocusTraversalPolicy.getDefaultComponent(Unknown Source)
   at java.awt.Component.getNextFocusCandidate(Unknown Source)
   at java.awt.Component.transferFocus(Unknown Source)
   at java.awt.Component.setFocusable(Unknown Source)
   at forge.screens.match.CMatchUI.updateButtons(CMatchUI.java:575)
   at forge.match.AbstractGuiGame.updateButtons(AbstractGuiGame.java:266)
   at forge.match.AbstractGuiGame.autoPassCancel(AbstractGuiGame.java:292)
   at forge.player.PlayerControllerHuman.autoPassCancel(PlayerControllerHuman.java:2138)
   at forge.game.phase.PhaseHandler.onPhaseBegin(PhaseHandler.java:355)
   at forge.game.phase.PhaseHandler.startFirstTurn(PhaseHandler.java:978)
   at forge.game.GameAction.startGame(GameAction.java:1472)
   at forge.game.Match.startGame(Match.java:95)
   at forge.match.HostedMatch$2.run(HostedMatch.java:221)
   at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
   at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
   at java.lang.Thread.run(Unknown Source)
This and other similar ClassCastException crashes on phase changes and turn changes have been addressed upstream.

- Agetian
Agetian
Programmer
 
Posts: 3472
Joined: 14 Mar 2011, 05:58
Has thanked: 677 times
Been thanked: 561 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 21 Feb 2017, 00:47

r33637

AI fails to target with Springjack Knight's trigger. Since this is a trigger that targets, it's required.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Bog Wraith » 21 Feb 2017, 03:10

friarsol wrote:r33637
With Krazy's server offline to us for now, is there somewhere I can download the above mentioned snapshot build, or can someone post a link in the forum? The latest build I have is r33583.
'Twas in the bogs of Cannelbrae
My mate did meet an early grave
'Twas nothing left for us to save
In the peat-filled bogs of Cannelbrae.
User avatar
Bog Wraith
Global Mod 1 (Ret)
 
Posts: 1108
Joined: 28 May 2008, 22:40
Location: Shandalar
Has thanked: 425 times
Been thanked: 153 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 21 Feb 2017, 03:48

Bog Wraith wrote:
friarsol wrote:r33637
With Krazy's server offline to us for now, is there somewhere I can download the above mentioned snapshot build, or can someone post a link in the forum? The latest build I have is r33583.
We're still trying to figure out how to get a snapshot server back online. We might try to do something like, just have a daily job push a snapshot at the same time everyday (assuming there has been changes since the previous snapshot), but haven't got all the details worked out yet.

Additionally, we were trying to get a release out this weekend but apparently life got in the way. Hopefully we'll have one out soon.

Until then, the only way to be on the latest and greatest is having a direct link to the code repo and have local syncing.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby Bog Wraith » 21 Feb 2017, 05:09

Ok, understood.

Thanks, as always, my friend! 8)
'Twas in the bogs of Cannelbrae
My mate did meet an early grave
'Twas nothing left for us to save
In the peat-filled bogs of Cannelbrae.
User avatar
Bog Wraith
Global Mod 1 (Ret)
 
Posts: 1108
Joined: 28 May 2008, 22:40
Location: Shandalar
Has thanked: 425 times
Been thanked: 153 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 22 Feb 2017, 03:02

Bog Wraith wrote:Ok, understood.

Thanks, as always, my friend! 8)
Did you see the beta release from last night?
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby fmartel » 22 Feb 2017, 15:23

friarsol wrote:
Bog Wraith wrote:Ok, understood.

Thanks, as always, my friend! 8)
Did you see the beta release from last night?
can the public, also have this release ?
fmartel
 
Posts: 281
Joined: 31 Dec 2013, 19:27
Location: Québec City
Has thanked: 8 times
Been thanked: 4 times

Re: Bug Reports (snapshot builds)

Postby stormcat » 22 Feb 2017, 18:40

:forge-gui-desktop-1.5.60
Armory Automation is not working.
The triggered ability can targeting equipments, but it is not equipped.
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 51 guests

cron

Who is online

In total there are 51 users online :: 0 registered, 0 hidden and 51 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 51 guests

Login Form