It is currently 15 May 2024, 04:57
   
Text Size

Bug Reports (snapshot builds)

Post MTG Forge Related Programming Questions Here

Moderators: timmermac, Blacksmith, KrazyTheFox, Agetian, friarsol, CCGHQ Admins

Re: Bug Reports (snapshot builds)

Postby stormcat » 22 Jul 2016, 08:08

:r31629
Details of my previous report.
Gavony Unhallowed has bug.
+1/+1 counter was put on it in the graveyard.
Attachments
capture_003_22072016_165759.jpg
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby Hanmac » 22 Jul 2016, 09:08

stormcat: i can reproduce it with other creatures too like Algae Gharial.
is has something to do when it dies with another creature at the same time.

how to fix that:
the best way would be to add checks to all cards that the Creature is still present on the Battlefield (that should be the easy way with "IsPresent$ Card.StrictlySelf")

5/1/2009: If Deathbringer Thoctar and another creature are dealt lethal damage at the same time, Deathbringer Thoctar will be put into a graveyard before it would receive any counters. Its ability will still trigger, but it will do nothing when it resolves.
Ruling says the Trigger should still happen, but it should do nothing when it resolves.

cards that should be fixed that way:

Edit: @stormcat: i fixed this cards, now i did find some more that also need to be fixed too.

Cards that does work not only for another, but for any creature like Blood Cultist.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Bug Reports (snapshot builds)

Postby stormcat » 23 Jul 2016, 02:31

:r31647
Tireless Tracker in graveyard triggered by play a land.

↓Copy of log.

Code: Select all
Resolve stack: Whenever a land enters the battlefield under your control, investigate. (Put a colorless Clue artifact token onto the battlefield with "{2}, Sacrifice this artifact: Draw a card.") [Zone Changer: Mountain (90)]
Add to stack: Kylee triggered Tireless Tracker (61).
Land: Kylee played Mountain (90)
Phase: Kylee's Main, precombat
Phase: Kylee's Draw
Phase: Kylee's Upkeep
Phase: Kylee's Untap
Turn: Turn 8 (Kylee)
Phase: stormcat's Cleanup
Phase: stormcat's End of Turn
Phase: stormcat's Main, postcombat
Phase: stormcat's End Combat
Damage: Guardian of Pilgrims (5) deals 3 combat damage to Kylee.
Phase: stormcat's Combat Damage
Phase: stormcat's First Strike Damage
Combat: Kylee didn't block Guardian of Pilgrims (5).
Phase: stormcat's Declare Blockers
Combat: stormcat assigned Guardian of Pilgrims (5) to attack Kylee.
Phase: stormcat's Declare Attackers
Phase: stormcat's Begin Combat
Resolve stack: Boon of Emrakul (21) -  Attach to Tireless Tracker (61)
Add to stack: stormcat cast Boon of Emrakul (21) targeting Tireless Tracker (61) .
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby stormcat » 23 Jul 2016, 04:15

:r31650
In Draft Pick, Two commons of Double-faced cards were included in a pack.
Attachments
test.jpg
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby stormcat » 23 Jul 2016, 04:42

:r31650
Vildin-Pack Alpha has bug.
He transformed by cast a spell.
And he doesn't transformed by cast two spells.
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby Hanmac » 23 Jul 2016, 05:07

@stormcat: i think i did broke Tireless Tracker, while fixing my problem with the Zulaport Cutthroat.

@some of the other developers:
can someone else look at this too? because i totally not understand what is wrong for this cards and why they not trigger for the destruction effects.
viewtopic.php?f=52&t=6333&start=5310#p199331

@stormcat: yeah i think i did the wrong for WerewolfUntransformCondition, i will fix it later.
Edit: Agetian did it again and was faster than me XD
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 23 Jul 2016, 05:14

Hanmac wrote:@stormcat: yeah i think i did the wrong for WerewolfUntransformCondition, i will fix it later.
I fixed this is in r31654.

Hanmac wrote:@stormcat: i think i did broke Tireless Tracker, while fixing my problem with the Zulaport Cutthroat.
I also don't know what's wrong with this one, sadly... :(
As for Tireless Tracker, maybe the fix you committed earlier for Zulaport Cutthroat should be made to honor the TriggerZones restriction so that it doesn't fire for the zones it's not supposed to (e.g. graveyard)?

- Agetian
Agetian
Programmer
 
Posts: 3474
Joined: 14 Mar 2011, 05:58
Has thanked: 677 times
Been thanked: 563 times

Re: Bug Reports (snapshot builds)

Postby Hanmac » 23 Jul 2016, 05:25

@Agetian: It does honor the Trigger zones, but I changed it, that it uses game changesZoneLKI.

I was using it to make it work for that destroy all cards with extra effect.

That was probably the wrong way. I think the right way would be to fix the "destroy all" spells instead. (Because some does work and some does not)

@Some other developers an idea?

Edit: i reverted my change with changesZoneLKI in TriggerHandler it does breaks more than it fix.

now the problem is back again that some DestoryAllEffects does cause cards like Zulaport Cutthroat to trigger ... probably the GameState or something like that is wrong.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Bug Reports (snapshot builds)

Postby excessum » 23 Jul 2016, 13:22

When the AI casts charm spells (eg. Selesnya Charm, Dromoka's Command) without paying costs (eg. Bloodbraid Elf, Goblin Dark-Dwellers), no choices are made. It seems that playSaFromPlayEffect() is not constructing the CharmEffect correctly as chooseModeForAbility() is not being called for the AI to set its choices.

I only checked that this bug existed in r31649 and it may go back even further.
excessum
 
Posts: 177
Joined: 21 Oct 2013, 02:30
Has thanked: 0 time
Been thanked: 19 times

Re: Bug Reports (snapshot builds)

Postby friarsol » 23 Jul 2016, 15:09

stormcat wrote::r31650
In Draft Pick, Two commons of Double-faced cards were included in a pack.
Ah. I think this is because Midnight Scavengers isn't marked as a Meld card. Meld isn't 100% finished yet.
friarsol
Global Moderator
 
Posts: 7593
Joined: 15 May 2010, 04:20
Has thanked: 243 times
Been thanked: 965 times

Re: Bug Reports (snapshot builds)

Postby matrix4767 » 24 Jul 2016, 06:57

r31675:
Hanweir Garrison makes red Soldier tokens instead of Humans.
Ride Down doesn't give Trample to the blocked creature.
matrix4767
 
Posts: 125
Joined: 09 Sep 2014, 08:10
Has thanked: 5 times
Been thanked: 3 times

Re: Bug Reports (snapshot builds)

Postby Hanmac » 24 Jul 2016, 09:49

hm i added a bit of Features to make the Meld cards better working.
(ImageUtil now works without crashing)

while testing i did use Brisela with a Clone:
Brisela is coded as Melded Face of Gisela (visible when pressing the Transform swirl)
but when the Clone does enters the Battlefield, it does transform into Bruna ... from my current understanding that should not even possible! (because Bruna is inside of Brisela and should not be available for the Clone)

so there is something wrong with either CardFactory or Clone Effect.
(they may not know what to do with Meld yet)

but i still don't know what is going on XD

Edit: i fixed it, but i stil don't know where the Bruna did come from.
Last edited by Hanmac on 24 Jul 2016, 10:59, edited 2 times in total.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

Re: Bug Reports (snapshot builds)

Postby stormcat » 24 Jul 2016, 10:49

:r31679
When Copy of Permeating Mass dies, it is still copy in graveyard.
stormcat
 
Posts: 361
Joined: 17 Jun 2015, 05:32
Has thanked: 0 time
Been thanked: 6 times

Re: Bug Reports (snapshot builds)

Postby Agetian » 24 Jul 2016, 13:14

stormcat wrote::r31679
When Copy of Permeating Mass dies, it is still copy in graveyard.
I can confirm that this can happen if the creature that Permeating Mass damages dies at the same time as it gets damaged, in which case the AB Clone triggers in a delayed way when the card is already in the graveyard. A good example: Permeating Mass is blocked by Abattoir Ghoul, and then Permeating Mass gets Giant Growth'ed. The ghoul dies and turns into a Permeating Mass while already in the graveyard.

I'm thinking about adding a restriction to AB Clone which would make it impossible for cards to become clones when they're in certain zones, but I'm not sure which zones to limit this to. At first I thought that "battlefield only" would be a good and logical choice, but that makes cards such as Clone impossible to play because apparently they become clones while on the Stack. Would Battlefield + Stack be enough then (at the very least it fixes Permeating Mass and doesn't break Clone), or are there other caveats? Also, maybe there's a better way to fix this?..

- Agetian
Last edited by Agetian on 24 Jul 2016, 13:44, edited 1 time in total.
Agetian
Programmer
 
Posts: 3474
Joined: 14 Mar 2011, 05:58
Has thanked: 677 times
Been thanked: 563 times

Re: Bug Reports (snapshot builds)

Postby Hanmac » 24 Jul 2016, 13:32

@Agetian: that sounds like an good way to fix it.

My way would be to add an ConditionPresent to just Permeating Mass and leave Clone alone for now.
Hanmac
 
Posts: 954
Joined: 06 May 2013, 18:44
Has thanked: 229 times
Been thanked: 158 times

PreviousNext

Return to Developer's Corner

Who is online

Users browsing this forum: No registered users and 50 guests


Who is online

In total there are 50 users online :: 0 registered, 0 hidden and 50 guests (based on users active over the past 10 minutes)
Most users ever online was 4143 on 23 Jan 2024, 08:21

Users browsing this forum: No registered users and 50 guests

Login Form