General UI support

[Doublestrike]

Thanks. Basic functionality (background color only) returned in 14032 so at least you can work.

This is very frustrating, NONE of these errors are happening on my side.

[slapshot5]

Ok. I'm back to solid color backgrounds like a previous screenshot.

I still get the exception on startup. Probably because I have no Quest Data.

This is odd because people are reporting it on some versions of Windows as well, right?

-slapshot5

[Doublestrike]

Some people are (Sloth), some say it's fine (moomarc).

I'm pretty sure it has to do with the clip (setClip).

That QuestData thing is still a bug though. I'll try to repro and fix at some point.

[Doublestrike]

Now?

EDIT - @slapshot - Bazaar bug fixed.

[Hellfish]

At r14035, I'm seeing the background drawn on top of everything else if I open another window on top of the Forge window. I'm only seeing this on Windows XP 32-bit, *not* on Windows 7 32-bit.

Secondly, when Forge first starts the settings/avatar panel is a bit goofy. It opens on avatar selection first even if the preferences tab is shown active and stays on avatar selection even if I switch between the tabs. Also the scrollbar is missing. It all goes back to normal if I switch between the tabs and then go to another panel and back.

Lastly, since I don't want be *just* heaping annoying bug reports on you; On Windows 7 the UI is friggin sweet! Kudos!

EDIT: Whoa, inline skin switching also took a hit.The screenshot is after trying to switch to all the different skins.

[Doublestrike]

Thanks for the kudos Hellfish, it helps (really). :pant: There's actually a few of performance changes that have gone in, with more to come, so the thing should be speeding up within a few days/weeks.

I'll attack the inline switching and avatar thing soon.

But, the other repaint issues are gone?

[Hellfish]

Define "other repaint issues". I'm not sure I got in on this early enough to get anything other than what I described in the first paragraph.

Gonna test r14036 too, just because..

[Doublestrike]

(edited above post re: skins/avatar)

Other repaint issues = visual artifacts on resize, no panels being painted, hover repaint after deck editor, the problem from

I am seeing the same thing as Sloth.

EDIT - never mind, just re-read your post, turns out the problem isn't fixed yet. I've been at this too long, time for a break. Will be back later.

For now, putting up background-only version.

[Hellfish]

I'm seeing nothing wrong on resize (except a little lag, but that's prolly just on my part). It *looks like* no panels are painted after I've had a fullscreen window over the Forge window. Same thing if that window is the deck editor.

[Chris H.]

I updated to rev 14037 and see that we are now back to the background-only version.

It looks like the repaint issues are gone. That is, I can move the mouse pointer around and click on things without seeing the various components appear and then disappear during some sort of a repaint process.

[silly freak]

I'm pretty sure it has to do with the clip (setClip).

Without even looking at the code, my intuition says that a modification to a Graphics object breaks later painting done by swing. If that is so, do g = g.create() at the beginnign of your paintComponent() methods. That creates a delegate and will let the original Graphics unmodified.

If my wild speculation is spectacularly useless, I'm sorry...

[Doublestrike]

Thanks sillyfreak - actually that's already been done. But now the problem is I'm setting a clip on the newly created graphics object, which apparently is being taken by Swing and used as the main clip for the next panel drawn. So, the first one paints OK, but the next one paints in the old clip, and breaks down from there.

Right now trying to find an XP or OSX box to fix this problem on, but having trouble with Maven on the XP but we'll get there...

[Chris H.]

Updated to rev 14071 and now have an error:

The method repaintOnlyThisPanel() is undefined for the type new ActionListener(){}
ViewMessage.java
/ForgeSVN/src/main/java/forge/view/match
line 157
Java Problem

[Sloth]

Updated to rev 14071 and now have an error:

The method repaintOnlyThisPanel() is undefined for the type new ActionListener(){}
ViewMessage.java
/ForgeSVN/src/main/java/forge/view/match
line 157
Java Problem

I can't compile either.

[Doublestrike]

Hmm, not sure why, but I've committed my latest ViewMessage which is fine over here. Hopefully OK now?

I'm working on a composite graphics solution for the rounded panel functionality instead of clipped graphics, should be OK soon but it's taking a little bit long.