2000 cards limit

[gmzombie]

yea i found the menu.txt that re-enabled the unlimited, revised and 4th options in the deck builder. now is the button adding a job that could be setup on a macro to be used in future revision or is this process a bit of time. i have IDA and olly and Pe explorer and am willing to try anything with a bit of guidance of course if this is possible. if you seen my idea from a few pages back i took and edited size of buttons for sets and how many..now obviously that was just an example but i even think if need be we could change them to cycles instead of sets and have the sets check like with the original. im getting ahead of everything though and dont want to sway anybody off course. just thinking out loud.

[foolosopher]

well with the drawcard and cardart dlls recoded by snacko, we might be able to add buttons and filters the way we want. We might also recode deck.dll. He knows what he is doing moving one step at a time, I got to really help him this time though...

[Gargaroz]

Mok, here's the updated C DLL with all instancies of 2000 removed and the new global variable, "available_slots" set.
I only leaved one instancies of 2000 in draft.c, as I'd have to recode various thing. It should not bother you for testing, however.
I included the updated SRC folder too, just in case you want to look at the C code one more time.

[rast]

Ya'll really need to set up a repository for this.

[0rion79]

Well, I see there are so many good ieas here and that you are talking about empowering some other parts of this game, not only the number of cards.
So, here are some ideas: I don't know if they are doable but would at least be worthy to consider them.

1 - (already suggested by GMZombie): add more buttons to deckbuilder. If it is not possible to add as many as GMZombie is proposing, we can add expansions by blocks with a "right click" option. In short, we could introduce buttons only for stand-alone expansion sets, as Ice Age, Tempest, Legends (unofficially), Mirage and so on and then add the satellite expansions as Revised and 4th Edition were added to the basic set, with a "V".
2 - is it possible to enlarge the list of creature types?
3 - Is it possible to enlarge the list of creature abilityes? The one that we get clicking on the "eye" in the decbuilder. I would really like to have new IDs for Shroud, Cycling, Flanking and all those abilities that we have introduced in the game.
4 - May we add a new cart type, as for Planeswalker?
5 - May we add columns to the csv/dat file? It would be lovely to have 4 columns for creature types rather than 2 or new slots for reprinting if we are going to implement sealed decks too. EG, I would like to see Swords to Plowshares, Counterspell and Shatter implemented ito Ice Age set too
6 - Is it possible to add a Sideboard? Maybe like a sealed deck where the 15 chosen cards are seen by AI as a leftover from booster packs
7 - May we add tags to decks? The idea would be to revolutionize the duel, creatig a screen similar to the one used for on-line experience, where the player may select different kind of game: T1, T1.5, T2, blocks, tribe decks, mono-set, EDH ecc. In this way, we could create different kind of decks being sure to get a fair challenge by AI. It really sucks if I get a powerful vintage deck and AI got a lame (but very funny) B-class tribe deck as elephants deck or dwarves deck! Or to duel a 60 cards deck vs. an EDH one. Adding a tag to those decks, the AI would be forced to select only a certian kind of decks for itself, making things much better.
8 - Revise the list of banned/restricted list, setting each card that has been restricted at least once as restricted in our version too. Maybe we could add a separate text file where we list those cards accordingly to different Magic ages.
9 - May we empower the on-line gaming experience by enhancing the procedure to "connect" players to each other? That Hamachi stuff that we used is quite complicated for me.
10 - may we add new ability icons (eg, shroud, rampage, flanking), cards color for hybrid and hybrid mana symbols?

About point 6 & 7, I think that the game already has some potential, because I remember Microprose talking about implementing similar options. What do you think about? Maybe some of those ideas are doable and may be added as long-run projects.

[Snacko]

Mok, here's the updated C DLL with all instancies of 2000 removed and the new global variable, "available_slots" set.
I only leaved one instancies of 2000 in draft.c, as I'd have to recode various thing. It should not bother you for testing, however.
I included the updated SRC folder too, just in case you want to look at the C code one more time.

buffer overruns.. you declare int in_set[2000]; then loop available_slots and if available_slots>2000 then you overwrite memory you don't own

[foolosopher]

I was checking the Ex.dll with IDA and couldn't find many cards apart from the following strings
VOLTAIC_KEY , KAROO, ELECTROLYZE

a couple other that may be ability implementations

PUMP_KNIGHTS, MODULAR,

as far as function names there were some that were functional, some more that had numbers and symbols for names
and a some more with the below name forms

unknown_libname_XX
sub_xxxxxxx e.g. sub_1201E73

in the magic.exe the sub_something function names when referring to cards were usually sub_number_card_name so if these are cards someone has to check their code (asm ).
Anyway like I told you I'm in if we are to eliminate Ex.dll but someone who knows asm checks and tells me what we need to implement in c, unless we already have sources for it (checked a bit but couldn't find any), so it would be easier.
I'm in also to making the expansions (at least some) Orion proposes if they are doable.
Oh, I want to add that I 'd sure like trying to fix the on-line version.
Anyway you can check what I found in the uploaded files

[0rion79]

Thank you, foolosopher

[Gargaroz]

buffer overruns.. you declare int in_set[2000]; then loop available_slots and if available_slots>2000 then you overwrite memory you don't own

Ah, you're right, damn changes made on the fly.
I'll fix that and re-upload the DLL.

Edit : here it is (along with the SRC folder again), I've reverted to the original version of draft.c, so it will only consider the first 2000 cards of the CSV.
No big deal, and I doubt this will hinder Mok's tests, so I'll fix this after the final change is done, as it will require some recoding.

[gmzombie]

so on the expansion numbers is it only even numbers we can use? cause it seems to go like 1,2,4,8,10,20,40,80,100,200,400,800,1000 could we then go up like this 1200,1400,1800,2000,2200,2400,2600,2800 and so on?

[Gargaroz]

No, gmzombie, I think the progression should be something like this :
1000 - 2000 - 4000 - 8000
10000 - 20000 - 40000 - 80000
100000 - 200000 - 400000 - 800000
It should be a bitfield, I dont'know it it's 16bit or 32bit.

[gmzombie]

ok that is why i asked cause i didnt know and didnt want to start anything without knowing if it would work. Now here is what i promised i used the new program to create a new csv that should be the most complete and without dupe's i believe.i went through and did just like i put up on my list 2 at a time to make sure there wasent problems. and here it is

[0rion79]

At last we'll have Varchild's War-Riders 's Survivor tokens that do not look as a plant! lol

[foolosopher]

Do we have any news or plan on what are we going to do with the editor?

[Aswan jaguar]

Thanks,for your hard work gmzombie.I see you have there the cards Microprose had never coded,and we haven't also.
And a clarification when you entered the csv values which ones did you prefer the original ones by Microprose for those cards or what we have now?