Manalink update 2009-03-22

[LoneFox]

Download link. Hope it works, savefile.com is having problems (complains about invalid security code) so I had to use an alternative site.

No new cards this time, but a lot of bug fixes and new C API. Documentation is "coming soon"...

• Partially fixed the cancelling bug. FTK and Fire Imp appear to work correctly, but the AI still casts Man-o'-War to empty table without bouncing anything. I don't know why this happens, the targeting code is identical. Same fix is also applied to Ogre Arsonist, Uktabi Orangutan, and Viridian Shaman.
• Soraya the Falconer now works as it should.
• Goblin Warchief now works as it should and has correct text.
• Martial Coup now works as it should and has been enabled.
• Tahngarth, Talruum Hero now has correct activation cost and typo in his name has been fixed as well.
• Stone Giant now determines correctly if there are legal targets for its ability. It was using potential target's power instead of toughness. I believe this bug has been around since original release of the game.
• Removed flying from Nantuko Husk and Phyrexian Ghoul.
• Fixed power and toughness of Alabaster Wall to 0/4.
• Corrected mana symbols in Gruul Turf's text (had instead of ).

[HarryPitfall]

The source code can't be compiled anymore, i just unpack and do the make (everything is fine, since the other last update compiles correct):

cards/cards.c: In function `echo':
cards/cards.c:31: error: `step' undeclared (first use in this function)
cards/cards.c:31: error: (Each undeclared identifier is reported only once
cards/cards.c:31: error: for each function it appears in.)
cards/cards.c:31: error: `STEP_DRAW' undeclared (first use in this function)
cards/cards.c:35: error: `STEP_UPKEEP' undeclared (first use in this function)
cards/cards.c: In function `card_careful_consideration':
cards/cards.c:112: error: structure has no member named `target_player'
cards/cards.c:113: error: structure has no member named `target_player'
cards/cards.c:114: error: structure has no member named `target_player'
cards/cards.c:115: error: `step' undeclared (first use in this function)
cards/cards.c:115: error: `STEP_MAIN1' undeclared (first use in this function)
cards/cards.c:115: error: `STEP_MAIN2' undeclared (first use in this function)
cards/cards.c:116: error: structure has no member named `target_player'
cards/cards.c: In function `card_kobold_drill_sergeant':
cards/cards.c:170: error: `STATIC_TRAMPLE' undeclared (first use in this function)
cards/cards.c: In function `card_recoil':
cards/cards.c:236: error: structure has no member named `target_player'
cards/cards.c: In function `card_synchronous_sliver':
cards/cards.c:321: warning: implicit declaration of function `vigilence'
Mingw32-Make: *** [cards/cards.o] Error 1

[LoneFox]

The source code can't be compiled anymore, i just unpack and do the make (everything is fine, since the other last update compiles correct):

You have unpacked it on top of older version. I did the reorganization discussed in the targeting API thread, many files have been combined and/or renamed. I cleaned up some terminology as well (step -> phase, static_ability -> keyword), which causes this error. Without any old files around the source compiles fine, at least for me.

[jatill]

I was able to compile. Great work. I like what you did with the targeting. I'll put it through its paces by making Siege Gang Commander some time this week.

Would you be able to add some comments to the 2nd half of the Falconer? I don't really get what's going on there.

I've been thinking a lot about how nice it would be to have a add_keyword_until_eot(player, card, KEYWORD) and pump_until_eot(player, card, power, toughness). It seems like you've almost mastered this. I'll keep my fingers crossed that you add this next release.

Finally, I see that you are using 'spell_fizzled' in falconer. Note that I added a constant 'canceled' that points to the same address, but can be used in different spots for readibility. I'm probably going to add a nother kill type KILL_RESOLVE for spells, even though it's the same as destroy. Any objections? Do structs allow that?

[LoneFox]

Would you be able to add some comments to the 2nd half of the Falconer? I don't really get what's going on there.

I've been thinking a lot about how nice it would be to have a add_keyword_until_eot(player, card, KEYWORD) and pump_until_eot(player, card, power, toughness). It seems like you've almost mastered this. I'll keep my fingers crossed that you add this next release.

Next on my TODO-list are global pump effects (fixing Army of Allah, implementing Overrun and other similar cards). Until-EOT effects are needed for those. I know the basic idea how this works, but there are still many "magic numbers". I'll document it in the wiki when I have solved those, or at least most of them.

Finally, I see that you are using 'spell_fizzled' in falconer. Note that I added a constant 'canceled' that points to the same address, but can be used in different spots for readibility. I'm probably going to add a nother kill type KILL_RESOLVE for spells, even though it's the same as destroy. Any objections? Do structs allow that?

I believe you can't have two names for same value in an enum, but you can always #define it. Such design is considered somewhat ugly, because it has potential for causing confusion (two values that look different but are really the same).

That "spell_fizzled" is a bad name because it is used for abilities too. Maybe just rename it to "cancelled" or "effect_failed" or something similar...

[jatill]

One spall bug I noticed. You changed Goblin Warchief to...
event == EVENT_MODIFY_COST_GLOBAL && COST_COLORLESS > 0
The COST_COLORLESS > 0 had to be removed. Otherwise, the interaction with Sphere of resistance didn't work right.

I'll correct this in my small release tonight.

[jatill]

Ok, here's a release with some new cards (incorporating Lonefox's work, of course).
Probably all cards you've never heard of, though.

http://www.savefile.com/files/1997761

Add:
Survival of the Fittest
Sphere of Resistance
Thorn of Amethyst
Yawgmoth's Bargain
Necropotence* (an approximation in several ways, but all minor)
Master of Etherium
Academy Rector
Gamble
Temple of the False God

fix pearl dragon activation cost
new bugs: (sorry!!!)
-the interation between sphere and hybrid doesn't work
-I've seen random lands appear in my graveyard when tutoring off rector
-necropotence is an approximation

Note: this is just a few hours work. In the past, this much code would have taken an entire week.
All hail Lonefox and Snacko for getting the C-coding working!!!

[EviL_CLonE]

@Jatill: After applying your patch, Affinity ability has stopped working. Any idea about what could that be?

Thank you for Sphere of Resistance and Master of Etherium! Excellent job with Goblin Tutor!!!

[jatill]

@Jatill: After applying your patch, Affinity ability has stopped working. Any idea about what could that be?

Thank you for Sphere of Resistance and Master of Etherium! Excellent job with Goblin Tutor!!!

Oops, I totally lied about Goblin Tutor. I thought that was the name of Gamble. Once we get generic tutoring working, though, I'll make sure to add that.

Re affinity, it looks like someone monkied with the CC or cards in magic.exe, which affects cost reduction. I'll change those back next mod (Monday sometime, hopefully)

[mathusalem]

Ok I did this quick ! graphic update

http://rapidshare.com/files/212351084/CardArtNew_.rar

[Bog Wraith]

Although Mathy has posted some of this new art, I have had some trouble finding some of the other files that show up as missing when I load ManaLink from past updates. I included a few of the files that Mathy has posted before as I was too lazy to remove them from my rar file!

I just wasn't able to find allot of the files that I have included here anywhere in this forum, so forgive me if I am doubling up on any of this, but it is presented here for those that are missing any of these files.

They are listed below, so if you don't need any of them, you can check the list first and decide if you want to download it:


1699=Careful Consideration
1701=Deranged Hermit
1692=Goblin Warchief
1693=Heart Sliver
1696=Manamorphose
1694=Reflex Sliver
1697=Stitch Together
1695=Synchronous Sliver



1667=Ageless Sentinels
1671=Arc Lightning
1677=Arcbound Ravager
1676=Arcbound Worker
1669=Charging Troll
1686=Chromatic Sphere
1685=Chromatic Star
1682=Darksteel Citadel
1674=Exploration
1690=Fire Imp
1668=Fists of the Anvil
1689=Flametongue Kavu
1665=Frozen Aether
1672=Jhessian Infiltrator
1679=Nantuko husk
1683=Nimble Mongoose
1688=Ogre Arsonist
1670=Ohran Viper
1678=Pattern of Rebirth
1680=Phyrexian Ghoul
1675=Progenitus
1681=Rancor
1664=Somber Hoverguard
1673=Tahngarth, Talruum hero
1666=Thoughtcast
1684=Werebear


1707=Academy Rector
1708=Gamble
1706=Master of Etherium
1705=Necropotence
1702=Sphere of Resistance
1698=Survival of the Fittest
1709=Temple of the False God
1703=Thorn of Amethyst
1704=Yawgmoth's Bargain

* I couldn't find an entry for Goblin Tutor in the SkyMagic Editor so therefore no ID number for the card could be found. I have included the art for it in this file.

I will post this in the Graphics Update Sticky as well.


http://www.mediafire.com/?ilmgmzkngmz

BTW, Thank You jatill for Necropotence!

[EviL_CLonE]

The Affinity issue is only for Frogmite, since other spells with affinity work fine.

[jatill]

Really small update. Just throwing this out there so people can shake out any bugs with Equipment / Entwine.

http://www.savefile.com/files/1997761

Added:
Ancient Tomb
Reap and Sow
Bonesplitter**

Fixed:
Interaction btwn Mogg Fanatic and Goblin Caves
Frogmite

I added Helm of Awakening, but for some weird reason it makes Llanowar Elves free (but not Raging Goblin). I'm perplexed. So it's disabled.

**Here are the issues I already know about. If you see more, let me know.
1) Equip should happen at sorcery speed. Right now it's coded to only work during your main phase. I'd like if this can be fixed somehow.
2) If you move equipment, and the new target dies in response, the equipment briefly equips the dead creature. Not a big deal, since it fixes itself immediately.
3) The equipment doesn't look attached to the creature. Not going to address this one, since it's the same with Battlegear, etc.

[Bog Wraith]

Here is the art work for jatill's above release.
I've included Helm of Awakening for when it's enabled.

1710=Ancient Tomb
1713=Bonesplitter
1711=Helm of Awakening
1712=Reap and Sow

http://www.mediafire.com/?fmnet3imqzf