Page 1 of 2

Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 14:25
by jatill
http://www.savefile.com/files/1997761

Cards added:
1675 exploration
1676 progenitus* (2 issues- doesn't shuffle into deck except from play, and mana cost looks wrong. mana cost works right, though.)
1676 arcbound worker (see notes below for small bug)
1677 arcound ravager
1678 pattern of rebirth
1679 nantuko husk
1680 phyrexian ghoul
1681 rancor
1682 darksteel citadel (same bug as ingot, but I don't think you can animate this card)
733 nicol bolas

Bug Fixes:
-do not allow 'cancel' for karoos
-update mana cost for demon's horn, etc
-set number of arts to 1 for voltaic key

Art not included, as usual. Also, I was lazy about putting the cards in the
proper sets. Sorry, Orion. Maybe you can be official set manager :)

Notes:
Modular works except it lets you put the counters onto non-creature artifacts.
I added this code and thought it would fix the problem (and it did), but it caused weird errors.

//make sure the selected target artifact is a creature
01203650 8B46 6C MOV EAX,[DWORD DS:ESI+6C]
01203653 C1E0 03 SHL EAX,3
01203656 8A84C0 38707E00 MOV AL,[BYTE DS:EAX+EAX*8+7E7038]
0120365D A8 02 TEST AL,2
0120365F 74 1E JE SHORT Manalink.0120367F

I was planning on adding several more cards this weekend, but instead I'm going to
spend my time trying to learn the new C-coding technique. Wish me luck!
If I have early success, I'll post another update today. Otherwise, I'll remove myself as the active developer tonight.

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 14:31
by HarryPitfall
did you try:
0120365D A8 02 TEST AL,2 to
0120365D A8 02 TEST AL,42
I'm not sure, but I think that this is the same values of "Card Type" on "Magic.exe" tab of editor... 1 = land, 2 = creature, 4 = enchantment... 40 = artifact... 40+2 = artifact and creature...

Did you code something about AI of ravnica bouncelands? like if it's player 1 (computer), choose a land for computer that isn't the one that just comes into play (the bounceland itself...) if is possible, of course... computer normally will choose a tapped one...

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 14:36
by jatill
The code I had there does work. It only lets you target a creature. (previous code says only artifact). The problem is that when I add in the code I get trashed registers. I spent 2 hours trying to get rid of the error, and then got annoyed and gave up. If you think you can fix that error, please submit a patch, I'd be thankful!

I didn't do anything for the karoo AI on this release. I wrecked my car this weekend and didn't want to do anything else that would frustrate me :) Maybe next time.

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 15:24
by HarryPitfall
Well.. I can try to change the value to 42 and see if it works... but I'm not create patch's anymore, I can test and say the bugs that I found.
I'll not say much about why, but now I'll just sit and watch... and play... :)

Nice patch, I love to see Nicol Bolas and Rancor... I get a nice sealed pool with armadillo cloak, serra's embrace and rancor... keep the good work Jatill... You get very skilled!

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 15:40
by mathusalem
as expected an excellent update, thanks a lot Jatill !
here is the art update

http://rapidshare.com/files/209692760/CardArtNew_.rar
I'll add it to the graphic sticky as well

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 21:23
by jatill
Ok, I'm done for the day. Here's whats new:

1683 - nimble mongoose
1684 - werebear
1685 - chromatic star
1686 - chromatic sphere

New functions: (I'll update the wiki Monday)
has_threshold
affect_me
has_mana
charge_mana
tap_card
is_tapped
add_one_mana_any_color
draw_a_card


The artifacts are quirky when animated, but I'll fix that next version.

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 23:10
by mathusalem
Ok I reuploaded the arts with the new additions, including Darksteel citadel, which is flagged as coded; if it's not....well, we'll have the art for it anyway :P

By the way, I've started to collect the IDs of a few cards with alternate arts ( Order of leitbur, Ebon hand, Hymn to tourach....etc ) I'll correct the numpics on the CSV, and will upload a corrected CSV tomorrow with a refresh on the complete art archive.

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 23:30
by jatill
mathusalem wrote:Ok I reuploaded the arts with the new additions, including Darksteel citadel, which is flagged as coded; if it's not....well, we'll have the art for it anyway :P

By the way, I've started to collect the IDs of a few cards with alternate arts ( Order of leitbur, Ebon hand, Hymn to tourach....etc ) I'll correct the numpics on the CSV, and will upload a corrected CSV tomorrow with a refresh on the complete art archive.
The art link is broken. Also, careful not to step on LoneFox's toes, maybe you can put yourself in the queue on the wiki, and then update the csv after him?

And if I haven't said it before, thanks for the work you do with the art. The cards just don't feel real to me until the art is attached,

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 23:37
by mathusalem
jatill wrote:
mathusalem wrote:Ok I reuploaded the arts with the new additions, including Darksteel citadel, which is flagged as coded; if it's not....well, we'll have the art for it anyway :P

By the way, I've started to collect the IDs of a few cards with alternate arts ( Order of leitbur, Ebon hand, Hymn to tourach....etc ) I'll correct the numpics on the CSV, and will upload a corrected CSV tomorrow with a refresh on the complete art archive.
The art link is broken. Also, careful not to step on LoneFox's toes, maybe you can put yourself in the queue on the wiki, and then update the csv after him?

And if I haven't said it before, thanks for the work you do with the art. The cards just don't feel real to me until the art is attached,
That's because, silly me i forgot to refresh the link

http://rapidshare.com/files/209692760/CardArtNew_.rar
here is the real one
Ok I'm in the queue, I'll update Fox's CSV.

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 23:44
by jatill
still missing chromatic sphere :/

Re: Manalink Update Mar 15 2009

PostPosted: 15 Mar 2009, 23:53
by mathusalem
jatill wrote:still missing chromatic sphere :/
and I assure you I din't drink, sorry about that, here it is finally
http://rapidshare.com/files/209692760/CardArtNew_.rar
I will upload a complete archive refresh tomorrow so that should cover everything

Re: Manalink Update Mar 15 2009

PostPosted: 16 Mar 2009, 08:13
by stassy
Missing Ageless Sentinel, Arc Lightning, Tahngart, Thoughcast and Voltaic Key card art after mar 15 patch and last card art applied, which update did I miss?

Re: Manalink Update Mar 15 2009

PostPosted: 16 Mar 2009, 08:32
by mathusalem
stassy wrote:Missing Ageless Sentinel, Arc Lightning, Tahngart, Thoughcast and Voltaic Key card art after mar 15 patch and last card art applied, which update did I miss?
you missed evil clone and Orion's update.... I cdon't see where voltac key could go missing though.
I will upload a complete archive refresh latter today, stay tuned, that should cover any image problem that you may have.

The complete archive has been reloaded :)

Re: Manalink Update Mar 15 2009

PostPosted: 16 Mar 2009, 19:49
by aww1979
Where do I put this? It's a whole bunch of C code files and other files I don't recognize, like *.ao and *.asm

Re: Manalink Update Mar 15 2009

PostPosted: 16 Mar 2009, 20:08
by HarryPitfall
*.asm are source code in pure assembler, *.ao are the compiled version of these files... I believe that most of then can be just ported to C (will be easy, more readable, and better to fix bugs if they appear).