Manalink update 2009-03-17, codename "I'm seeing red"

[LoneFox]

Download link: http://www.savefile.com/files/2044566

New cards:

• Fire Imp
• Flametongue Kavu
• Goblin Lore
• Ogre Arsonist

The CIP abilities suffer from the same cancel problem as Man-o'-War does.

Fixed:

• Balduvian Horde (Converted to C, now dies if you don't discard.)
• Merrow Reejerey (Converted to C and added its second ability. For some reason the AI does not use it, so it may still need something...)
• Ohran Viper (Fixed copy-paste error in rules text)
• Sol'kanar the Swamp King (Triggered ability is now compulsory. Also, there were two ID's assigned to this card in the csv. I reused the inactive one for Goblin Lore to prevent it from causing confusion.)
• Vodalian Knights (Converted to C. Both islandhome and activated ability work)

Other:

• Lots of new C API, used by cards mentioned above.
• Flavor text script has been run again, and now it also fixes dash characters on card type to long ones like in real cards.
• Disciple of the Vault has been disabled. I didn't need to do anything to it, jatill had disabled it but forgot to run csv2dat before releasing.

[jatill]

Nice update, especially the fix to Reejery. One of my goals for the week is to add the extra ability onto cloudgoat ranger as well as fix lightning helix).
Would you do us one more favor, and list which functions you added, and then add them to the API on the wiki?
Much thanks.

Oh, and before I forget... how tough would it be to update your flavor text script to only append flavor text when it won't make the card type line unreadable? I'm all for flavor text, just not when it gets in the way of the functional text.

[LoneFox]

Would you do us one more favor, and list which functions you added, and then add them to the API on the wiki?
Much thanks.

I'll do that tomorrow. Now I'm too tired to do anything useful.

Oh, and before I forget... how tough would it be to update your flavor text script to only append flavor text when it won't make the card type line unreadable? I'm all for flavor text, just not when it gets in the way of the functional text.

"Expand text box" can be turned off from right-click menu...
Of course it could count the total length of rules text + flavor text and not add flavor if that total is longer than some limit. It wouldn't very accurate, because the font has variable width.
BTW, would it be a good idea to update rules text from oracle as well? It would clean up a lot of inconsistencies and typos, and save time when making new cards, but some oracle texts don't make sense at all when using these old rules...

[Snacko]

I included all my changes and the extra structures / enums.
I'm posting it in here as no cards were added just source changed and recoded ecoded has_creature_type.asm to C with the new structures
Will copy it to wiki later on.

Download Link: http://www.mediafire.com/download.php?zmnmmvlaz3j

[HarryPitfall]

Snacko, your version didn't compile anymore... the version on first post compiles normally...
I get errors about _packed_ and invalid tokens before a *

[Snacko]

Do you have a full gcc package with inttypes.h ? Most likely you should have a full gcc package as who knows if any other headers will come in handy (most likely not anymore). The header comes with mingwrt-3.15.2-mingw32-dev.tar.gz but depends on other headers from the package too.
It allows for a more fine grain of categorising integer types.

[jatill]

BTW, would it be a good idea to update rules text from oracle as well? It would clean up a lot of inconsistencies and typos, and save time when making new cards, but some oracle texts don't make sense at all when using these old rules...

I wouldn't do this quite yet. As you mention, a lot of cards don't actually behave according to their oracle text (especially concecrate land). Also, cards we add that aren't 100%, like Progenitus, need special text to explain how they actually work.

Now if the new core set changes terminology as much as it's rumored to, there's a whole other discussion to be had.

[HarryPitfall]

Even with the headers, I'm getting this error when compile:

functions/has_creature_type.o(.text+0x26):has_creature_type.c: undefined reference to `memcpy'
make: *** [manalink] Error 1

[Snacko]

Your version of gcc is assembling the byte moves to memcopys which is kind of bad performance wise but you can still link it just fine.
Add

Code: Select all

_memcpy = 0x4D5280;

to manalink.lds

[jatill]

Your version of gcc is assembling the byte moves to memcopys which is kind of bad performance wise but you can still link it just fine.
Add

Code: Select all

_memcpy= 004D5280;

to manalink.lds

Adding that gives me a syntax error on that line. I changed 00 to 0x and still there error.

[Snacko]

Yes it should be 0x instead of 00 copied the value without thinking.
It shouldn't give any errors. Post the actual error you're getting.

[jatill]

Yes it should be 0x instead of 00 copied the value without thinking.
It shouldn't give any errors. Post the actual error you're getting.

Wow, C is picky. Changing mem= to mem = fixed the error. Also, I had to delete has_creature_type.asm.
Can someone point me to math's update?

[Snacko]

There isn't has_creature_type.asm don't include old files.

[jatill]

I don't know if this would help anyone else, but I created build.pl that you can pass a card name into and it'll auto update manalink.asm, run make, and copy the dll. I'll include it in the next release unless someone wants it sooner.

[aww1979]

I'm not able to see the new cards. I unzipped to magic/program directory.

For Meerow Reejeray, perhaps the reason the AI won't use its twiddle ability has something to do with the Meerow text saying 'tap or untap target permanent when I put my cursor over the name in your post'. This cannot possibly be correct, since an enchantment has never been tapped in the history of magic, with the exception of Copy Artifact, and maybe some weird new ones I've never seen.