[still bugged]Snow Mana issues

[Aswan jaguar]

Describe the Bug:
Phyrexian Ironfoot ability to untap costs only (as it is set basic=snow)fixed

Which card did behave improperly ?
Phyrexian Ironfoot

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Jan 01, 2014 : Commanding the revision of Ice Age - DUEL

What exactly should be the correct behavior/interaction ?
Phyrexian Ironfoot

Are any other cards possibly affected by this bug ?
-

SAVEGAME Corrupted

[BAgate]

And additional oddity, after I activated the ability and paid the 1 mana it asked me to select a permanent and would only allow me to choose an untapped one. Once I chose an untapped land it did nothing to that land and untapped the Phyrexian Ironfoot.

[Gargaroz]

The whole "snow mana" system was bugged and is under recontruction. Consider this fixed.

[BAgate]

Snow mana appears bugged. Same behavior as http://www.slightlymagic.net/forum/viewtopic.php?f=110&t=13235.

[Korath]

Snow mana is still very broken. Working on it. Current known problems:

1. If you ask charge_snow_mana() to pay more than one snow mana, it only charges for one. Charging for one or more colorless alongside the snow mana works properly.
2. It lets you select a tapped snow mana source, or one that's a creature and summoning sick.
3. It first charges all the colorless mana it's asked for, then all the snow mana, without telling you how much snow mana you'll need while still paying colorless.
4. It won't let you cancel once you've finished paying colorless mana.
5. It prompts for "Select target creature."
6. It assumes that each mana source must tap to activate.
7. It assumes that each mana source produces exactly one mana.
8. has_snow_mana() - the function consulted to see whether you could pay a cost with in it, e.g. to tell whether to highlight a card's name as yellow, or to autosac a Glacial Plating when it decides you couldn't pay its upkeep - assumes that each mana source produces exactly one mana, and that it can do so exactly once each time snow mana is charged (whether it's tapped or not).
9. If you have mana already generated from a snow source before charge_snow_mana() or has_snow_mana() is called, it's not considered snow.

Thermopod seems unrelated (just from reading the bug, not investigating the source). Rime Transfusion bug reads like it's maybe trying to charge instead of just , or maybe like it's just a duplicate of the above.

Fix I have half done still won't be right, but it'll be closer. Looks like A, B, D, E, and F are fixable; C, G, and H will be partially fixed; and I isn't fixable.

Regarding C, current implementation will show the full amount being charged (both colorless and snow), but make you pay all the snow mana first. No technical reason it can't be fixed fully, but it'd be more work, and the AI would probably deal with it (even) worse.

G will be close, but charge_snow_mana() will assume all mana produced as a result of activating a snow card is snow. For example, if you have a Mana Flare and a Snow-Covered Forest and tap the forest, you'll get two green snow mana; if you have a snow Mana Flare (e.g. from Rimefeather Owl) and a Forest and tap the forest, you'll get two green non-snow mana; you should get one green and one snow green in both cases.

H will only be a little better than it is now - it'll be able to tell whether a mana source can activate or not, but will continue to assume that each can produce exactly one mana. That's not really fixable until we have an easy way to interpret the result of declare_mana_available() (easy) and declare_mana_available_hex() (hard), and a way to reverse them (hard for the first, very hard for the second). Even then, it won't be able to account for e.g. Mana Reflection or a snow Mana Flare.

[BAgate]

Thanks for the summary. I know we have a half dozen related reports on this issue. Would you prefer we leave them all open, or close the others and work off of this?

[Korath]

Only close them if you're positive that they're duplicates of something listed here, please.

New implementation's going to be a bit wonky with snow mana sources that have a required payment, too - they won't be recognized as having generated any mana unless it's a different color than what was paid to activate it. So if you have a snow Barbed Sextant, activate it for a cost by paying , and choose as what's generated, it'll think you made zero mana. (The old implementation would just tap it like it was a snow mox.)

[Korath]

Another example: you've got a Skycloud Expanse with an ice counter, a Tundra, and a Rimefeather Owl in play. Click the Rimefeather Owl, it prompts you "ACTIVATING Rimefeather Owl, Tap ". Click the Skycloud Expanse, it prompts you "ACTIVATING Skycloud Expanse, Tap ", click the Tundra (which should autochoose, but it doesn't matter which type is generated), and Rimefeather Owl thinks you've generated one snow white mana and one snow blue mana. All good. But if you first click Tundra to put into your mana pool, then Rimefeather Owl to charge snow mana, then Skycloud Expanse (activating with the already in pool), the owl thinks you've generated one blue snow mana and still have the original white (non-snow) mana in pool. Which is still enough to pay , I guess, but still wrong. If you paid with , , , or , then both mana would have been snow. And if you paid with from a Gilded Lotus, the extra black mana remaining in your pool would be incorrectly identified as snow, too.

And snow mana is charged in a very limited number of places and never with wonky stuff like hybrid or X mana, and folks still think shoehorning cards like Cavern of Souls and Food Chain into this engine should be easy. Sigh.

Anyway, committed this in d4e9cff. Better than it was.