[fixed/closed]face down cards and names

[BAgate]

Describe the Bug:
Face down cards apparently are named face down cards (or some such). So if you target one with a Maelstrom Pulse all other face down cards are destroyed too.

Which card did behave improperly ?
face down cards

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Manalink 2015/3/25: Fate Reforged,duel

What exactly should be the correct behavior/interaction ?
Ruling: 5/1/2009 A face-down creature has no name, so it doesn't have the same name as anything else.

So if you target a face down card with a Maelstrom Pulse or similar card it should be the only thing affected.

Are any other cards possibly affected by this bug ?
-

[Korath]

Many, many other cards are going to be affected by this. Everything in the Echoing Decay cycle, for example. And essentially none of the affected cards share implementations; they each individually compare csvids to simulate "has the same name". So they'll all need fixing individually.

[Gargaroz]

Fixed Echoing Ruin, Echoing Courage and Bile Blight (and everything in the future that will use the function "echoing_pump").

[Aswan jaguar]

Did you fix Maelstrom Pulse?

[Gargaroz]

I'll fix each card separately or in small groups. As Korath mentioned, it's more safe as most doesn't share the same implementation.

Detention Sphere fixed in a709e96

[Gargaroz]

Dichotomancy fixed in 995bc6f

[Gargaroz]

Doubling Chant fixed in 43ec32b

[Gargaroz]

Fixed Echoing Calm, Echoing Ruin and Echoing Decay in e95fe02

[Gargaroz]

Fixed Maelstrom Pulse in 0341274

[Gargaroz]

Fixed Dual Nature in c10589a

[Aswan jaguar]

All cards with "Same name" clause list (some nay not be the case of course or Wotc hasn't made that yet):

"same name" clause cards | Open

1- Aven Shrine
2- Bazaar of Wonders
3- Bifurcate
4- Bile Blight
5- Bloodbond March
6- Cabal Shrine
7- Candles of Leng
8- Cephalid Shrine
9- Circu, Dimir Lobotomist
10- Clarion Ultimatum
11- Counterbore
12- Crumble to Dust
13- Curse of Misfortunes
14- Cylian Sunsinger
15- Deicide
16- Detention Sphere
17- Dichotomancy
18- Doubling Chant
19- Dragonlord Kolaghan
20- Dual Nature
21- Dwarven Shrine
22- Echoing Calm
23- Echoing Courage
24- Echoing Decay
25- Echoing Ruin
26- Echoing Truth
27- Evil Twin
28- Exclusion Ritual
29- Extirpate
30- Eye of Singularity
31- Godsend
32- Haunting Echoes
33- Homing Lightning
34- Infernal Tutor
35- Invader Parasite
36- Izzet Staticaster
37- Jester's Scepter
38- Lobotomy
39- Locket of Yesterdays
40- Maelstrom Pulse
41- Mask of the Mimic
42- Mimeofacture
43- Mindreaver
44- Mishra, Artificer Prodigy
45- Mitotic Manipulation
46- Moratorium Stone
47- Nantuko Shrine
48- Pack Hunt
49- Pyromancer Ascension
50- Quash
51- Reap Intellect
52- Remembrance
53- Retraced Image
54- Sasaya, Orochi Ascendant // Sasaya's Essence
55- Scalpelexis
56- Scour
57- Search the City
58- Sever the Bloodline
59- Shimian Specter
60- Sowing Salt
61- Spellweaver Helix
62- Sphinx of the Chimes
63- Splinter
64- Strata Scythe
65- Surgical Extraction
66- Surging Æther
67- Surging Dementia
68- Surging Flame
69- Surging Might
70- Surging Sentinels
71- Tainted Pact
72- Thrumming Stone
73- Verdant Succession
74- Wake of Destruction

I have strike through the ones Gargaroz has fixed.
Also what about cards with clause "chosen Name" like
Immediate Action?
and other name cases "card named X" Avarax for example?

[Korath]

Choose-a-name effects are fine so long as you can't choose "face-down creature".

Avarax isn't currently a problem because of a much more difficult bug. If triggers worked like they were supposed to, you could put Avarax's trigger on the stack, some other effect could turn Avarax face-down, and then you'd have to search for a card with the same name as the face-down card. But even if you assume it's another trigger that turns Avarax face-down (so to avoid the "you can't play spells or activate effects in response to a trigger" bug), triggers won't resolve if the triggering card isn't on the battlefield or has been changed away from the card that had the trigger. Scratch that, once Avarax's trigger is on the stack, changing its name won't matter to that trigger.

On the other hand, a card like " : Search your library for a card named [this card's name]" would need to be fixed, since normal activations don't have that problem. So better to check every card in Manalink.csv marked "CODED CARD" that has "name" anywhere in its rules text. Depending on how much effort you want to put into fixing this bug, anyway. Plenty of activated abilities - and just about all the ones that create effect cards - currently break if their source changes to a different card between activation and resolution, so it's not that pointful to fix this specific case.

This would be a good time for a has_same_name(card_instance_t*, card_instance_t*) function, by the way, and to religiously use that everywhere an effect is looking specifically for whether two cards have the same name, instead of hacking get_id() to lie. Besides being far more future-proof, that would let you handle things like Sakashima the Impostor cleanly, let you do the neat Johnny Splintering Wind token/Pack Hunt trick to tutor Splinter into your hand, and might allow a short-term fix for manlands with spurious "Faerie Conclave Animated" names for their alternate forms. (You'd also need a has_same_name_iid(card_instance_t*, int), of course, and maybe a has_same_name_iid_iid(int, int), to compare a card on the battlefield with a card in a library/graveyard/exile or two cards in libraries/graveyard/exile, but they end up being simpler.)

[Aswan jaguar]

The list with clause ":named card":
1- Arachnus Spinner
2- Bogbrew Witch
3- Dark Supplicant
4- Deathpact Angel
5- Diligent Farmhand
6- Korlash, Heir to Blackblade
7- Linessa, Zephyr Mage
8- Mirror-Mad Phantasm
9- Nissa Revane
10- Oriss, Samite Guardian
11- Renowned Weaponsmith
12- Sengir Nosferatu

[Gargaroz]

The main problem right now are effects with deals with "cards with same name" already in play, since "face-down" mechanic only apply to cards in play.
This was recently (almost) all centered around 2 functions, "echoing_pump" and "echoing_effect" for easier handling. Anyway, I'm implementing the "get_card_name" and "has_same_name" functions.

[Gargaroz]

Fixed Evil Twin in e261b2d