Forge version 1.5.11

[Agetian]

@ drdev: In my opinion, it might be a good filter for the cases when you have lots of decks grouped in folders and subfolders by categories of some sort.

- Agetian

[drdev]

Here's a Planechase-related bug: clicking the "Planar Deck Editor" button on the new Planechase start screen fires up Planar Deck Editor in an interesting and, sadly, unusable mode: the subtitle indicates that you're adding cards into the main portion of the deck instead of the planar portion, and the added cards end up in the sideboard when the deck is saved. More importantly, they're not being added to the [Planes] section of the deck, so the resulting deck is not usable as a Planechase planar deck.

- Agetian

Fixed in r24472.

While I was fixing this, I noticed that you get an error if you try start a game with a planar deck containing multiple copies of any one plane/phenomenon. Should we be doing singleton restriction in the Planer Deck Editor like we do in the Commander deck editor? Or are there cases where multiple copies of a plane/phenomenon are allowed?

[moomarc]

Here's a Planechase-related bug: clicking the "Planar Deck Editor" button on the new Planechase start screen fires up Planar Deck Editor in an interesting and, sadly, unusable mode: the subtitle indicates that you're adding cards into the main portion of the deck instead of the planar portion, and the added cards end up in the sideboard when the deck is saved. More importantly, they're not being added to the [Planes] section of the deck, so the resulting deck is not usable as a Planechase planar deck.

- Agetian

I'm sure when I tested that button a few days ago it was adding to the right section. I was mainly testing deck conformity and also making sure that new planar decks were being added to the plane deck list chooser. I used the exact same call as was used before, so it's possible one if the other deck manager changes affected it. But I'll try find some time today to look at it.

Edit: okay, I'm not 100% sure it was adding the planes to the fright section as I didn't look, but matches started perfectly with planes, and it passes deck conformity when it should ( made some that should fail), so I assume it was working correctly at that time

[Agetian]

@ drdev: As far as I remember, according to the official rules you can have only one copy of a given plane or phenomenon. It's probably a good idea to add a singleton restriction by default.

- Agetian

[moomarc]

@ drdev: As far as I remember, according to the official rules you can have only one copy of a given plane or phenomenon. It's probably a good idea to add a singleton restriction by default.

- Agetian

That is in the deck conformity check if a player turns it on. I like being able to make no legal plane decks though. If we remove that option though, I understand

[drdev]

@ drdev: In my opinion, it might be a good filter for the cases when you have lots of decks grouped in folders and subfolders by categories of some sort.

- Agetian

Added "Folder" filter in r24473. For simplicity, I followed the style of Format, Set, and Quest World filters by using a submenu under Filter > Add > Folder which lists all folders containing decks and lets you pick one to pull into a filter.

Let me know what you think.

Thanks.
-Dan

[Agetian]

@ moomarc: Yeah, I agree that it's important to keep it as an option [if anything, it helps development and testing Planechase cards]. I guess the singleton restriction for planes and phenomena can then depend on whether the deck conformity option is turned on or off? For instance, if it's turned on, the deck editor will only let you put one plane or phenomenon into the deck, but if it's off, then it'll allow you to add as many cards as you want? What do you think?

P.S. Usability-wise, it might be a good idea to eventually implement a way to delete a planar deck or a scheme deck from the selection screen, much like standard Constructed decks can be deleted.

- Agetian

[Max mtg]

Folder column is not needed for Precons, they are not groupped by any property. Instead they have "set" property - I'll add that to DeckProxy

As a temporary solution I'll have getPath return precon's set

[squee1968]

A small request. As long as you're tinkering around with the deck manager, can we please make the "change section" button into a drop down that will let you choose which section you want, rather than cycling through them all? Main first choice, then sideboard, then the others.

[Chris H.]

Hmmm, got a build failure.

Code: Select all

Last login: Fri Jan 24 08:21:07 on console
CardForge:~ me$ /Users/me/\ My\ Desktop/By-Weekly\ Beta\ Temp\ no\ tests.command ; exit;
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: Working copy '/Users/me/Workspace_SVN/ForgeSVN' is too old (format 10, created by Subversion 1.6)

 
Today I was able to successfully do a snapshot build and deploy.

I still get the initial error at the start:

Code: Select all

Last login: Sat Jan 25 08:35:33 on console
CardForge:~ me$ /Users/me/\ My\ Desktop/Snapshot\ Temp\ no\ tests.command ; exit;
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: Working copy '/Users/me/Workspace_SVN/ForgeSVN' is too old (format 10, created by Subversion 1.6)
[INFO] Scanning for projects...

 
I hope to figure out what is wrong before we are ready for the next beta build and deploy.

[Agetian]

A little question for Sloth (as our AI expert) and anyone else who may be working on AI improvements and implementations: since the new implementation of Back from the Brink is not playable by the current AI, should we mark it as RemAIDeck:True for the time being or is the updated implementation viable/planned?

- Agetian

[Max mtg]

I have added a column to DeckManager - the earliest set when all cards were already printed. (there is also a function in CardEdition.Collection to calculate this value out from CardPool)
It can be useful to order decks chronologically.

Since gui is not my area of expertise, I leave up to drdev a decision whether to use and where to use that column, how to name it and etc...

@Agetian
I've changed a lot in CardDb internals, so if anything went wrong with sets assignment in decks being read or deck recognition, please let me know

[Agetian]

@ Max: kk, if I noticed anything out of ordinary I'll let you know. For now, tested some basic operations related to cards with random art (generation of random art cards in pools, recognition of cards with specific art in deck files), so far so good.

- Agetian

[Max mtg]

More news: I have written some code that automatically performs the task Xitax's deck convertor was used for (that is determines the earliest set when all cards from a given deck were already printed, and makes sure that all cards in deck use their newest printing, but at least as old as the found set)

Any decks where no card has an explicitly specified set will get autoconverted on start up (only in memory, no changes will be saved without prompt). I launched Forge with over 300 decks in constructed folder - With this option enabled didn't make any perceivable difference.

The method is called forge.deck.Deck.convertByXitaxMethod() - if anyone adds a button into UI to convert decks by demand, that could be useful too.

[Xitax]

Hey Max, does it include the option to exclude non-expansion sets like Duel Decks and FTV? I don't see these as being realistic depictions of a typical deck to have those sets assigned.

Just a question - thanks for doing this!