CSV errors & Legacy/Effect cards with no text

[Korath]

Fixed Sakashima the Impostor as part of 493aa94; I'll be back to edit this post later for the others, probably sometime tomorrow.

Edit: Alternately, I'll forget to get back to it before releasing the new version. Crud. Abbot of Keral Keep I'd already fixed while responding to an unrelated bug whose savegame happened to have one on the bf, so that's ok; but the two cards that say +0/+0 ideally need a programmatic update to fix, not just text editing.

[Aswan jaguar]

Warbringer legacy no title-no dash text.

Taigam's Strike has title & text but only the rebound text is not very helpful and I have to search in exile to see what the cards ability is before I decide to use it.not a csv problem.

Lavastep Raider no legacy title/text.It uses only one legacy for the pump [s]but I haven't tested if values in csv are added it adds pump effects correctly.
EDIT: I just tested and if values are added to effect slots and appear on Effect card still it doesn't calculate the +2 per activation on the effect card.[/s]

[Aswan jaguar]

Another creature card=Fleshbag Marauder and others like it or different but disabling creature/permanent(sacrifice opponent creature,destroy creature/permanent,exile creature/permanent,put on top of library creature/permanent,return to hand creature/permanent.....anything I forget that makes creature/permanent useless this turn or ever) that have to be put to be played by AI if not only before combat at least be played also before combat(now only played after combat-so making AI miss an attack at some scenarios)IMHO and in many tests I have run it is better to have both before combat and after combat values enabled for the vast majority of creatures.

Nissa, Sage Animist ( Nissa, Vastwood Seer//Nissa, Sage Animist )ultimate animation lands legacies are empty.

Forerunner of Slaughter empty legacy.

Scourge of the Throne empty legacy.(effect not working fully-extra attack phase not working still legacy could have it).

[Aswan jaguar]

I have checked all fixes & reports made in the last 2 updates.Edited them appropriately and here are the remaining/missed reports that need fixing/editing:
1- Aluren,Sealock Monster,Vesuvan Shapeshifter fixed,Quicksilver Gargantuan = not csv problem post with extra info here
2- Manifested card's legacy cards already known to devs:
viewtopic.php?p=176139#p176139
3- Maybe Grimoire Thief but can't check as he is bugged.Currently doesn't show the exiled cards on top of it(as it used to) which actually is an improvement-correct behaviour.viewtopic.php?f=86&t=7855&p=177490#p177490
4- Seismic Elemental still empty:
viewtopic.php?f=86&t=7855&start=465#p190510
5- And cards that need change for better AI behaviour which mainly have/grant haste but are set to be played in 2nd main:
viewtopic.php?f=86&t=7855&start=465#p188603

[Aswan jaguar]

Subterranean Scout emtpy legacy title & text.

[Korath]

Subterranean Scout already fixed in 4fddc18.

[Aswan jaguar]

Volrath's Shapeshifter has wrongly text/title in effect slots like Aluren,Sealock Monster,Vesuvan Shapeshifter mentioned above and so nothing is shown in it's legacy card and as a result not highlighted either.

[Aswan jaguar]

Garruk, the Veil-Cursed still doesn't show text in title and text for 3nd ability as the text needs to be put in legacy slots and not in effect slots where it is now.Like the cards in post above.

[Aswan jaguar]

Confusion in the Ranks legacy no title and text.doesn't use a legacy any more.

[BAgate]

Don't know which card's fault, but when using Splinter Twin results are uneven. On a Hypersonic Dragon you get an empty legacy and on a Shifty Doppelganger you get a legacy with the text related to the doppelganger.not a csv problem

[Aswan jaguar]

Sins of the Past is missing text/title,it needs the text to be moved from effect slots to legacy slots to work.

[Aswan jaguar]

Dream Halls legacy card that is put to opponent's side to be able to use it has no text/title so neither highlights as active-able.If text and title are added to legacy slots the card highlights,too.

[Aswan jaguar]

Lim-Dûl the Necromancer in Manalink.csv has value 37 = granting rampage instead of 38 = granting regeneration in DBA1.

[Aswan jaguar]

There are a lot of wrong entries in DB card type 10 in Manalink.csv (the value is only for mana producers direct or indirect,fetch or /and play land cards also,and cards that change mana from one colour to another).That results in many cards showing wrongly in right click menu of lands -mana only- in both old and new deckbuilder.Some examples are Delif's Cube and Didgeridoo,Dragonian Cylix with colours disabled.And with colour enabled you could also see for white Adarkar Valkyrie,Advance Scout,Arrow Volley Trap and many more.

Korath wrote:
...change the deckbuilder to instead look at whether the card has anything in Mana Source Colors, which'll be more accurate.

[Korath]

Ampryn Tactician, Consul's Lieutenant, and probably plenty of others with the same problem ("+0/+0" instead of the actual changes) fixed in 6202e68. Won't be quite comprehensive, since not all cards use the general-purpose effect function (e.g. I had to change the one used by Mobile Fort and Walking Wall separately), but most do.