[fixed/closed]Theros gods don't work as EDH Commanders

[Shantak]

Describe the Bug:
I tried creating Commander decks using Heliod and Thassa, but the game said I didn't have a proper commander in my deck when I tried using it.

Which card did behave improperly ?
Heliod, God of the Sun
Thassa, God of the Sea

Which update are you using?(date,name)Which type(Duel,Gauntlet,Sealed Deck)
Commanding the revision of Ice Age. V2

What exactly should be the correct behavior/interaction ?
Theros gods should be usable as Commanders as far as I know. However, I'm not sure if something in their Enchantment nature is preventing this in Manalink or if this is a simple matter.

Are any other cards possibly affected by this bug ?
Most likely also Erebos, Nylea and Purphoros (and the new gods in Born of the Gods and Journey into Nyx

[Korath]

Duplicate, but that thread's a mess, conflating multiple issues and getting off track in discussion; let's leave this open instead of reopening that one.

[BAgate]

Done, that thread is now closed with a link back to this one.

[Korath]

Gargaroz' fix looks like it should have worked: since the "actual" cards for the gods are the enchantment, not the enchantment creature versions, they're not detected normally as legendary creatures; so anything with subtype God is considered a potential general.

Problem is, they're not being detected as SUBTYPE_GOD either. Adaptive Automaton, for example, doesn't see it (even on the animated version). It's set properly in manalink.csv. (It overlaps SUBTYPE_CARRIER, but that shouldn't matter. What breaks if we add more "real" subtypes? The overlap between SUBTYPE_CAMARID and SUBTYPE_SLIVER seems especially unfortunate.)

So I don't know. The subtype code in has_creature_type.c is convoluted and due for a rewrite; there's at least three competing versions, none of which seem completely finished. I really don't want to be the one to fix it, though at least it's all confined to that one file instead of being spread out everywhere.

[Korath]

Still don't know why SUBTYPE_GOD doesn't work (and it wasn't that the enchantment versions didn't have it set, either), but I've hardcoded them to be legal in fca7ace.

[Nexhro]

THS Gods have worked as commanders since BotG v1.