It is currently 07 Jul 2021, 22:54
   
Text Size

Shandalar - Program Bugs

Jihad checks its sacrifice trigger both too often and not often enough; other minor problems (fix completed)

 

Jihad checks its sacrifice trigger ("When the chosen player controls no nontoken permanents of the chosen color, sacrifice Jihad.") continuously, instead of checking for an event; this is inefficient and (under admittedly contrived circumstances - animation via Opalescence, then something like Mirrorweave changing it into a different creature) incorrect.

Worse, there aren't necessarily any calls to the card function after first strike damage, nor (usually) at the end of combat, so it may not get buried until much later than it should. (Original report.) recalculate_all_cards_in_play() should be called in each case.

It also buries itself instead of sacrificing, and won't trigger if the chosen player controls only token permanents of the chosen color.

History

Changed ticket status from "Fix completed in VCS" to "Fix completed"
Action performed by Korath » 10 Jun 2015, 08:19
Changed ticket status from "Fix in progress" to "Fix completed in VCS"
Action performed by Korath » 07 Jun 2015, 01:21
Changed ticket status from "Reviewed" to "Fix in progress"
Action performed by Korath » 07 Jun 2015, 00:19
Assigned ticket to user "Korath"
Action performed by Korath » 07 Jun 2015, 00:19
Changed ticket status from "New" to "Reviewed"
Action performed by Korath » 25 May 2015, 23:44

Ticket details

  • Ticket ID: 537
  • Project: Shandalar
  • Status: Fix completed
  • Component: Individual Card
  • Project version: Ruined Tower 1
  • Priority: Normal
  • Severity: Normal
  • Assigned to: Korath
  • Reported by: Korath
  • Reporter's tickets: List all tickets
  • Reported on: 25 May 2015, 22:38
  • Last visited by Korath » 10 Jun 2015, 08:19.
 

Login Form