Shandalar - Program Bugs
Expendable Troops can only be activated at combat after blockers have been assigned. (fix completed in vcs)
Expendable Troops can only be activated at combat after blockers have been assigned.
You should be able to activate it as soon as attackers have been declared.(it may also have to block to activate it's ability but not certain for that).
About the first bug is it global because I have met it also with Inquisitor's Snare and Judge Unworthy? So, everything with clause "attacking or blocking"?
You should be able to activate it as soon as attackers have been declared.(it may also have to block to activate it's ability but not certain for that).
About the first bug is it global because I have met it also with Inquisitor's Snare and Judge Unworthy? So, everything with clause "attacking or blocking"?
Last edited by Korath on 22 Nov 2016, 21:35, edited 3 times in total.
Reason: component none->Duel Engine
Reason: component none->Duel Engine
Comments
Posted by Korath » 22 Nov 2016, 21:37
commit aea3ca212b4914cd398e71aad60ad8cf86433422
Author: Korath <dgk@Dirge.none>
Date: Tue Nov 22 16:36:15 2016 -0500
[HS] FIX #1284: TARGET_STATE_IN_COMBAT: >= PHASE_DECLARE_ATTACKERS
not PHASE_DECLARE_BLOCKERS.
Author: Korath <dgk@Dirge.none>
Date: Tue Nov 22 16:36:15 2016 -0500
[HS] FIX #1284: TARGET_STATE_IN_COMBAT: >= PHASE_DECLARE_ATTACKERS
not PHASE_DECLARE_BLOCKERS.
Posted by Aswan jaguar » 22 Nov 2016, 21:53
I don't know if I understand correctly your fix but if I do then let me say that Expendable Troops and similar should be playable both after attackers have been declared and also as it where after blockers are assigned for the attacking creatures that is of course.
Last edited by Aswan jaguar on 04 Dec 2016, 07:16, edited 2 times in total.
Reason: add last sentence for clarity.
Reason: add last sentence for clarity.
Posted by Korath » 10 Dec 2016, 13:11
git log messages are primarily aimed at developers. I mostly only paste them here because the bugtracker only has one field for version, instead of a reported-in-version field and a fixed-in-version field.
What was happening here is that the targeting modifier "TARGET_STATE_IN_COMBAT" (which means an attacking or blocking object - if you specify both TARGET_STATE_ATTACKING and TARGET_STATE_BLOCKING, that means an attacking and blocking object) was only checked during or after the declare blockers phase and before the second main phase, instead of only during or after the declare attackers phase and before the second main phase.
What was happening here is that the targeting modifier "TARGET_STATE_IN_COMBAT" (which means an attacking or blocking object - if you specify both TARGET_STATE_ATTACKING and TARGET_STATE_BLOCKING, that means an attacking and blocking object) was only checked during or after the declare blockers phase and before the second main phase, instead of only during or after the declare attackers phase and before the second main phase.
3 Posts
• Page 1 of 1
Ticket details
- Ticket ID: 1284
- Project: Shandalar
- Status: Fix completed in VCS
- Component: Duel Engine
- Project version: Hall of the Sultan 2
- Priority: Normal
- Severity: Normal
- Assigned to: Korath
- Reported by: Aswan jaguar
- Reporter's tickets: List all tickets
- Reported on: 18 Nov 2016, 13:54
- Last visited by Korath » 10 Dec 2016, 13:11.
