Shandalar - Program Bugs

[Korath]

Also affects dual lands, shocklands, etc. - anything whose mana abilities are all added by their basic land types, instead of their rules text. You'll observe these are drawn with the colorless frame, too.

These all deliberately have no bits set in their card_ptr_t::mana_source_colors, instead adding them according to their current land subtypes. This works correctly for cards backed by a full card_instance_t - that is, something in your hand, on the stack, or on the battlefield during a duel - both for display and mana generation. It's an absolute prerequisite to make abilities that add or remove basic land types (like Urborg, Tomb of Yawgmoth or Prismatic Omen), opposed to ones that replace them and remove all other abilities (like Tundra Kavu or Phantasmal Terrain), work right. But it made them show up with colorless frames in the deckbuilder, during adventure mode, in graveyards and libraries, etc.

I already caught the display problem and fixed it post-snapshot in d06ac46ef062a61b300b271e4e0dbdc88aa31c1d. The stats window, I hadn't thought of. It could be problematic too for card generation in adventure mode - free cards from lairs, cards offered in town, whether these lands are offered in a cardpicker restricted by color. Maybe remove their mana_source_colors at the start of every duel, and put them back at the end? Yuck. Might be cleaner to just special-case them all when calculating mana colors in-duel.