Shandalar - Program Bugs

What versions of those decks were you playing? Because in my deckpack overhaul, only Shapeshifter has Clone in the deck.

[Korath]

It's in all three in the "Microprose MTG Mok's Manalink 2.0 Version" that I used as a development base.

[Korath]

commit 910c127866daf18d3e52790f33942e3ccea1517d
Author: Korath <dgk@Dirge.none>
Date: Wed Oct 14 22:30:46 2015 -0400

[TH] FIX #538: partial backport 37b9ddb from NB: +clone-as-etb cards

(Omitting added/rewritten cards except for Clone, and recording cast_from.)

---

Any that manage to copy Auras (Copy Enchantment and Clever Impersonator in
particular, but also e.g. Copy Artifact on an Aura turned into an artifact by
Memnarch) will break horribly for now.

No Vesuvan Doppelganger yet; changing an existing card that doesn't expect it
into another is dangerous, due to the convention of having individual cards
store arbitrary data specific to that card name in card_instance_t::info_slot
and eot_toughness. If, for example, a card changes from a Gem Bazaar (an
animated one, in Vesuvan Doppelganger's case) to a Scavenging Ghoul, it won't
be able to regenerate - the Gem Bazaar stores its current color in the same
space that Scavenging Ghoul looks at to see if it's already regenerating.
(Apparently in the fifth-edition rules current as of MicroProse MTG, you could
only regenerate something that was already being destroyed, and only once per
destruction event. Or that's how it was deliberately programmed, and not just
as a hint to the AI.) The original MicroProse version tries to deal with the
issue by making a separate Data Card to try to keep track of previous card-
type-specific data, which isn't scalable; I'm pretty sure Manalink just ignores
the problem.

AI decks including the old, deliberately-poisoned csvid for clone (39) get
automatically translated into the new one (10399). This was why the card just
broke instead of using the original MicroProse version. All Manalink would
have had to do to reuse the original csv instead of permanently breaking the
slot and temporarily breaking Shandalar was return 1 from EVENT_CAST_SPELL,
sigh.

Cards added:
Body Double
Clever Impersonator
Copy Enchantment
Jwari Shapeshifter
Masterwork of Ingenuity
Quicksilver Gargantuan
Sculpting Steel
Vesuva

Rewritten:
Clone
Copy Artifact

Support:
read_deckfile_into_initial_library()
RECORD_CASTFROM_IN_EOT012_AND_MANA_COLORS_IN_EOT3()

enters_the_battlefield_tapped() (and its variants in card_checkland and
card_fastland), DISCOURAGE_REPEAT(), AI for ECHO(), types_etb_tapped(), and
AI-at-casting for a handful of specific cards like Time Vault acknowledge
cloning.

Kismet deliberately does not. A case where it's relevant: you cast a
Copy Enchantment and select an enchantment creature. I'm interpreting this as
you playing just an enchantment, so Kismet ("Artifacts, creatures, and lands
played by your opponents enter the battlefield tapped.") shouldn't affect it.
It's possible that it should be looking at the object as it enters the
battlefield, though.