Shandalar - Program Bugs

[Korath]

Happens with all of my nonpermanent spells.

Rather than, as in Manalink, individually making each spell remove itself from the battlefield when it's done resolving, I've made the engine do it if the card hasn't already moved itself somewhere else (as happens, for example, with Beacon of Immortality).

The problem is that the forked copy doesn't ever reach the battlefield like normally-cast spells - put_into_play() (which is what Fork uses to cast the copied spell) leaves STATE_INVISIBLE (which usually means the spell is still on the stack and hasn't begun to resolve) in place. A couple cards in Manalink exploit that to tell whether a card was cast normally, so it couldn't ever be fixed directly there; but I'll do so here.

(I note that Fork still has other problems; it has trouble keeping the copy red - not wholly unexpected - and it doesn't flag the copy as a token, so things like Beacon of Immortality and Time Spiral and so on that don't go to graveyard on resolution will put extra copies of themselves in your library/exile/etc. But those'll have to wait until a full rewrite.)

[Korath]

commit 3eb0b130be023513b606d6595547046179d15b96
Author: Korath <dgk@Dirge.none>
Date: Thu Jun 4 13:52:15 2015 -0400

[Shandalar] FIX #600: put_into_play(): rm STATE_INVISIBLE before RESOLVE_SPELL