Shandalar - Program Bugs

[Korath]

It correctly only moves Swamps if black is checked, though.

[Korath]

It also doesn't deal well at all with multicolor cards, and never moves non-basic lands or snow-covered lands.

[Korath]

commit 56670323f1228ec7b29b8c27d2c9184cb286b09a
Author: Korath <dgk@Dirge.none>
Date: Mon Sep 28 01:41:48 2015 -0400

[NB] FIX #609: replace deckbuilder move into/out-of deck semantics

Previously, this was based solely on the card color field of card_ptr_t (which
only one value for "multicolor", rather than being a bitfield, so they were
never matched) for detecting the five colors; on the card type field of
card_ptr_t for detecting artifacts; and the five original basic lands.
(Plus, the bug causing cards set to CP_COLOR_BLACK to always be matched).

Now, the basic test is against card_data_t::color, which normally contains all
of a card's colors. Lands and mana-producing artifacts instead store the
colors of mana they produce here, so Swamp, Bojuka Bog, and Mox Jet are all
considered black.

Cards with hybrid mana are matched if either of their colors are set. Other
multicolor cards must have all of their colors set to be moved in or out. (So
a Putrid Leech costing won't be moved if you select only black, only
green, or even only black then only green, but only if you select both black
and green at the same time.) Mixed hybrid cards like Thopter Foundry at
won't be moved unless you select both the non-hybrid color and at
least one of the hybrid colors at once.

This works less well, but defensibly, for mana producers. Tropical Island
won't be moved in or out of a deck unless you select both blue and green, for
example, which isn't so bad; but a City of Brass or Black Lotus or Mox Diamond,
which all produce any color of mana, won't move unless you select all five
colors. On the one hand, I'd want those to move into a deck if I selected any
of their colors, but not move out unless I selected all of them; on the other,
I'd expect the rules for moving a card into or out of a deck to be the same.
So I'm not handling them specially at all.

The "Artifact" button is replaced by "Colorless", so it'll also get non-mana-
producing lands and lands producing only colorless mana, as well as colorless
non-artifact cards like Ghostfire and the various Eldrazi. The text for the
dialog labels is now read from UIStrings.txt:@GROUPMOVE in Shandalar, rather
than from Menus.txt (which is shared with Manalink and the standalone
deckbuilder) to accommodate the change.