Shandalar - Program Bugs
Sphinx Summoner searches for artifacts or creatures, not artifact creatures (fix completed)
Sphinx Revelation fetches non creature artifacts,too.I fetched Disrupting Scepter and Tower's of Calamity.
Last edited by Korath on 06 Oct 2015, 03:49, edited 1 time in total.
Reason: Retitle from "Sphinx Revelation fetches non creature artifacts,too."
Reason: Retitle from "Sphinx Revelation fetches non creature artifacts,too."
Comments
Posted by Korath » 05 Oct 2015, 12:42
Sphinx's Revelation is "You gain X life and draw X cards." I assume you mean Sphinx Summoner ("When ~ enters the battlefield, you may search your library for an artifact creature card, reveal it, and put it into your hand. If you do, shuffle your library.").
Posted by Aswan jaguar » 05 Oct 2015, 13:29
Yes,Sphinx Summoner is the guilty one.The funny thing is that in the paper I temporarily wrote the bug,I wrote the correct card but the transition to keyboard was.... 

Posted by Korath » 06 Oct 2015, 03:49
It can find non-artifact creatures, too.
What's happening is that Target::real_validate_target(), which checks to see whether a given card on the battlefield, on the stack, or in a player's hand is a legal target, honors TARGET_SPECIAL_REQUIRE_ALL_TYPES (whose purpose is to distinguish between "target artifact or creature" and "target artifact creature"); but Target::card_not_in_play_valid(), which does the same thing for cards in libraries, graveyards, exile, or not-in-the-game, ignores it.
What's happening is that Target::real_validate_target(), which checks to see whether a given card on the battlefield, on the stack, or in a player's hand is a legal target, honors TARGET_SPECIAL_REQUIRE_ALL_TYPES (whose purpose is to distinguish between "target artifact or creature" and "target artifact creature"); but Target::card_not_in_play_valid(), which does the same thing for cards in libraries, graveyards, exile, or not-in-the-game, ignores it.
Posted by Korath » 06 Oct 2015, 04:02
commit ab59e0fc3c9a968586787114f2af9e76b35d77b9
Author: Korath <dgk@Dirge.none>
Date: Tue Oct 6 00:00:49 2015 -0400
[TH] FIX #767: card_not_in_play_valid honors TARGET_SPECIAL_REQUIRE_ALL_TYPES
Author: Korath <dgk@Dirge.none>
Date: Tue Oct 6 00:00:49 2015 -0400
[TH] FIX #767: card_not_in_play_valid honors TARGET_SPECIAL_REQUIRE_ALL_TYPES
4 Posts
• Page 1 of 1
Ticket details
- Ticket ID: 767
- Project: Shandalar
- Status: Fix completed
- Component: Individual Card
- Project version: Thieves Hideout 2
- Priority: Normal
- Severity: Normal
- Assigned to: Korath
- Reported by: Aswan jaguar
- Reporter's tickets: List all tickets
- Reported on: 05 Oct 2015, 08:32
- Last visited by Korath » 26 Oct 2015, 09:02.
