Shandalar - Program Bugs
Meekstone does not affect cards with power equal to (permanent type/cards in hand) count (fix completed)
Tested with Matca Rioters and Uktabi Wildcats
Last edited by Korath on 01 Nov 2015, 02:36, edited 1 time in total.
Reason: Retitle from "Meekstone does not affect cards with "power or toughness equal to the number of""; version NB1->TH1
Reason: Retitle from "Meekstone does not affect cards with "power or toughness equal to the number of""; version NB1->TH1
Comments
Posted by Korath » 01 Nov 2015, 02:41
Not all */* creatures, but a good chunk of them. Anything dependent on artifact_count[], creature_count[], enchantment_count[], land_count[], basiclandtypes_controlled[], or hand_count[] - those counting cards in the graveyard like Lord of Extinction, for example, are fine.
The problem is that those counts aren't updated until after cards' power, toughness, and abilities are; and the way Meekstone currently works is to add a "doesn't untap" flag during EVENT_ABILITIES. The icon shows up ok because, except for the first call to recalculate_all_cards_in_play() in a given turn, power/toughness computation uses the previous values of those counts. Meekstone breaks because recalculate_all_cards_in_play() has only been called once by the time untapping is checked.
The problem is that those counts aren't updated until after cards' power, toughness, and abilities are; and the way Meekstone currently works is to add a "doesn't untap" flag during EVENT_ABILITIES. The icon shows up ok because, except for the first call to recalculate_all_cards_in_play() in a given turn, power/toughness computation uses the previous values of those counts. Meekstone breaks because recalculate_all_cards_in_play() has only been called once by the time untapping is checked.
Last edited by Korath on 01 Nov 2015, 02:41, edited 1 time in total.
Reason: typo
Reason: typo
Posted by Korath » 01 Nov 2015, 02:52
commit 80ba28c61a1ffecd3c82f29f88de22d89d5f184a
Author: Korath <dgk@Dirge.none>
Date: Sat Oct 31 22:52:00 2015 -0400
[TH] FIX #825: count_colors_of_lands_in_play() just after EVENT_CHANGE_TYPE
Instead of waiting until after EVENT_SET_COLOR and EVENT_ABILTIIES as well.
Author: Korath <dgk@Dirge.none>
Date: Sat Oct 31 22:52:00 2015 -0400
[TH] FIX #825: count_colors_of_lands_in_play() just after EVENT_CHANGE_TYPE
Instead of waiting until after EVENT_SET_COLOR and EVENT_ABILTIIES as well.
2 Posts
• Page 1 of 1
Ticket details
- Ticket ID: 825
- Project: Shandalar
- Status: Fix completed
- Component: Duel Engine
- Project version: Thieves Hideout 1
- Priority: Normal
- Severity: Normal
- Assigned to: Korath
- Reported by: stassy
- Reporter's tickets: List all tickets
- Reported on: 28 Oct 2015, 06:03
- Last visited by Korath » 04 Mar 2016, 20:37.
Options
Main Menu
User Menu
Our Partners
