Shandalar - Program Bugs

[Korath]

Ashnod's Battle Gear. Had you included even the minimum common-sense requirements to repro this (the decks being played), I could've found and fixed it immediately instead of having to stumble across it myself.

[Korath]

commit 8a888a54bf368c44fc8cad56b91921eb5b3b0c3e
Author: Korath <dgk@Dirge.none>
Date: Wed Jan 27 06:53:01 2016 -0500

[AS] FIX #973: rewrite Ashnod's Battle Gear, Tawnos's Weaponry; +similar cards

The problem with Ashnod's Battle Gear (and, less easily triggered, with
Tawnos's Weaponry) is that it responded to any event that it didn't explicitly
handle by trying to destroy its effect card, provided that it was untapped and
hadn't marked itself as not having an effect card. It didn't, however, mark
itself like that until it being cast or otherwise put onto the battlefield; so
when it received an EVENT_BEGIN_GAME (which makes Leylines and Chancellors
possible), it sometimes destroyed a random card whose position happened to
match the artifact's uninitialized data.

The rewrite still uses the original logic for whether to untap these cards,
essentially untouched and not rewritten idiomatically yet. The only change is
that it'll now more reliably recognize other nonglobal does-not-untap effects
like from Paralyze, and it'll choose to untap if it's boosting its opponent's
creature.

Cards added:
Endoskeleton
Everglove Courier
Flamestick Courier
Flowstone Armor
Frightshroud Courier
Ghosthelm Courier
Hisoka's Guard
Pearlspear Courier
Spirit Shield
Zelyon Sword

Rewritten:
Ashnod's Battle Gear
Tawnos's Weaponry

Support:
find_matching_legacy()
powerup_legacy() overloads taking a Duration{}.
Duration::UNTIL_SOURCE_LEAVES_BF_OR_UNTAPS

Incidental:
find_or_make_matching_legacy() won't match an existing effect card if it was
created while the source was a different card (e.g. from a Vesuvan Doppelganger
while it was copying something else).