Collectible Card Game Headquarters

sadlyblue wrote:I have the same problem.
I think is a conflict with another pack.
For example: you use the uid 1005 in VALAKUT RAMPS, but its also used in Pestilence deck...
If you use another, there's no problem.

Oooohhhh. That makes sense. I just went with whatever J's deck editor assigned, assuming that the identifiers were hashed against the DLC or something to make them unique. Gosh, there's so much to learn! I'll prepend deck-names with 2868 in future releases. Thanks for helping me figure out what's going on, guys!

Eglin wrote:Adding this fix and changing the mountain count to six instead of five has done the trick! You're the man, thefiremind! Thank you so much for helping me out with this. There are a few oddities remaining - popping a khalni heart or a cultivate doesn't always trigger Valakut, and sometimes only some of the Valakuts in play will trigger. The game generally crashes at the end of each match, as well. However, it's certainly playable, and I'm thrilled to again be playing one of my favorite decks of all time. Thank you.

I wrote 5 because I tried to exclude the Mountain that triggers the ability:

Code: Select all

    filter:SetCardInstance( TriggerObject() )
    filter:AddExtra( FILTER_EXTRA_FLIP_CARD_INSTANCE )

If you need to write 6, then you can try to remove those conditions from the filter and see if some bugs disappear. To be precise, the count should exclude the Mountain that triggers the ability because if that Mountain leaves play, the count remains unchanged (I read it on Gatherer), but if this is the source of the problems, we can ignore this rule since it's a very particular case.

thefiremind wrote:I wrote 5 because I tried to exclude the Mountain that triggers the ability:

Code: Select all

    filter:SetCardInstance( TriggerObject() )
    filter:AddExtra( FILTER_EXTRA_FLIP_CARD_INSTANCE )

If you need to write 6, then you can try to remove those conditions from the filter and see if some bugs disappear. To be precise, the count should exclude the Mountain that triggers the ability because if that Mountain leaves play, the count remains unchanged (I read it on Gatherer), but if this is the source of the problems, we can ignore this rule since it's a very particular case.

Ah, this explains why changing the count to six didn't have the effect I'd hoped. It's kind of hard to tell exactly what's happening, because sometimes Valakut doesn't trigger at all. I just ran a game where I had four in play along with five mountains. I played two harrows and a cultivate, such that I had nine mountains at the end of the turn - Valakut didn't trigger once. I'm, unfortunately, terrified that I'm doing something wrong in some other place (like dereferencing a null pointer) that's potentially corrupting every other action at random - or it could just be that I still suck at coding cards!

At any rate, thanks for the continuing support. I feel like I am making progress.

Updated, March 7. Added a few new decks, tweaked a large number of things. Today's release seems to me to be of much higher quality, in general, than the original - please do give it a try.

CWheezy wrote:I don't see mono green ramp, pyromancy ascension, and valakut ramp.

Also I am getting an error message after every game "You do not have all available card, so your decks have been reset to the original"or something like that. Does that mean I have to delete my profile for them to work properly?

Sorry it took me a few days, but I think I've got the issue sorted out and I am hoping you'll be kind enough to try again.

I dunno what you are apologizing for, it isn't like this is a task I asked you to do or paid you dat paper for it

Also your new decks crash the game if you win

CWheezy wrote:Also your new decks crash the game if you win

Yeah. I'm having that trouble sometimes, too. For whatever reason it doesn't generally happen after archenemy format matches. I guess it's better than crashing in the middle of a match, but it is still driving me bonkers. I haven't yet been able to figure out what's causing it. Does the game produce a Mother.txt file for you? It gives me nothing, sadly.

I only get that if it doesn't crash, and only sometimes

Great news! I found that the ProduceMana function I was using on many of the cards (dual lands, mana elves, etc) requires that the cards register mana tokens (internally, not noticeable to the player). I wasn't doing this, and correcting the problem has solved many of the end-of-match crashes. I'll post a new release soon.

Cheers,
Eglin

I disseminated very much, нas forgotten to tell about this important point.
You can use any card as a token, but consider 2 rules:
1 The call of the token not registered by a current card will lead to error
2 The call of a card which uses tokens (registers them) leads to an instant error

nabeshin wrote:I disseminated very much, нas forgotten to tell about this important point.
You can use any card as a token, but consider 2 rules:
1 The call of the token not registered by a current card will lead to error
2 The call of a card which uses tokens (registers them) leads to an instant error

I'm afraid that I don't quite follow. Would you please give an example? Also, could you please help me to understand why the Eldrazi Spawn tokens that several cards in Kev's deck create don't register colorless mana tokens? They don't seem to crash the game in the way my cards that lacked the registration did.

Thanks!

It seems like the cards that are supposed to bestow "Hexproof" aren't really doing that. The token indicating "Hexproof" shows up, but the creatures are still able to be targeted.

I don't know if this problem is related to your code or not.

ptisan35700 wrote:It seems like the cards that are supposed to bestow "Hexproof" aren't really doing that. The token indicating "Hexproof" shows up, but the creatures are still able to be targeted.

I don't know if this problem is related to your code or not.

I can only think of two cards I've coded w/ hexproof at the moment - Asceticism and Vines of Vastwood. I haven't tested vines very much, but I am certain I've never seen AI cast against my critters while Asceticism was down. I guess I must not have tested vastwood beyond noting that the badge appeared. After reading your post, I went back and tried to get the AI to "counter" a spell w/ vastwood and it did indeed fail. Thank you for finding a bug. I will very much require help to find all of them.

I will have to give some though, and probably request some help, to figure this one out. It seems that the game checks to see if a card is valid (and fires the CARD_CONSIDERED_FOR_TARGETTING trigger) only at the time a spell is cast and that shrouding a card (as Vastwood seems to be properly doing) doesn't force the game to reevaluate targets. We could perhaps remove the target from play and return it, but that would trigger comes-into-play effects. We could check for damage and remove it, but that wouldn't prevent stuff like Act of Treason or the case where you cast vastwood on an opponent's creatures to prevent a Giant Growth or something. There may be facilities built into the game for manipulating spells on the stack (I know Precursor Golem waits until it gets hit w/ a spell to start copying it) I will have to do some studying to see if I can find a good solution.

Thanks again for bringing this to my attention - definitely on the TODO list, 'cause Vines of Vastwood is a great card.

update: I noticed today that there was, in fact, a slight error in Asceticism (missing ()). It doesn't seem to have any significant impact, as it was used in a redundant sanity check. As an experiment, I also tried using the Protection() function on Vines of Vastwood to give the target card protection from /everything/ belonging to an opponent until the end of turn. This allowed a 1/1 creature to block anything without damage, so the protection is working. Unfortunately, it still failed to protect from anything that was already on the stack at the time Vines was cast. The only thing I can think of to try at this point is to <filter> everything in ZONE_STACK and check to see if it targets the card that vines is targeting, countering it if so. This, coupled with protection from everything belonging to opponents until end of phase/step (to protect from activated abilities), might do the trick. This might have unintended consequences if vines is cast during a combat phase, though - I'm not sure if the protection would die before combat damage was resolved. Either way, I'll try it out soon and see what happens.

Eglin wrote:

nabeshin wrote:I disseminated very much, нas forgotten to tell about this important point.
You can use any card as a token, but consider 2 rules:
1 The call of the token not registered by a current card will lead to error
2 The call of a card which uses tokens (registers them) leads to an instant error

I'm afraid that I don't quite follow. Would you please give an example? Also, could you please help me to understand why the Eldrazi Spawn tokens that several cards in Kev's deck create don't register colorless mana tokens? They don't seem to crash the game in the way my cards that lacked the registration did.

Thanks!

It agree, I insufficiently well explain, as up to the end I do not know details, but there are things which I can to explain more in detail.

1 The error actually same in all cases - the program tries to use the out-of-date address which refers not to a normal code, and on garbage.
Tokens registered by cards are stored in special table and their life is tracked by the special subroutine.
in Kev's deck colorless mana tokens registered by another card.
2 Try to use mana token registration in "eldrazi spawn"
P.S. It works, as I tried that it worked.