It is currently 18 Nov 2018, 23:32
   
Text Size

DOTP2012 Bug fixes

Moderators: Xander9009, CCGHQ Admins

DOTP2012 Bug fixes

Postby pcastellazzi » 30 May 2012, 01:31

Here i will try to keep you updated of the bugs on DOTP2012 this community had fixed.

For those interested in colaborate the code repository is https://bitbucket.org/pcastellazzi/dotp-2012-fixes

The latest mod including all bug fixes described in the repo can be downloaded from: https://bitbucket.org/pcastellazzi/dotp ... LC_1000.7z

Also if you know of a new bug please post it here and we will try to fix it as soon as we can.
The lights then came up and the crowd erupted in applause, because that's what the crowd does after it watches destruction on a large screen.
— Ben Kuchera, Mordern Warfare 3 review.
User avatar
pcastellazzi
 
Posts: 184
Joined: 25 Apr 2012, 00:40
Location: Montevideo, Uruguay
Has thanked: 11 times
Been thanked: 30 times

Re: DOTP2012 Bug fixes

Postby Aarala » 31 May 2012, 13:06

Can you fix Grim Lavamancer not showing the target for it's activated ability? Whenever I play against it I don't know what it's going to hit.
Aarala
 
Posts: 15
Joined: 15 May 2012, 02:28
Has thanked: 1 time
Been thanked: 0 time

Re: DOTP2012 Bug fixes

Postby thefiremind » 31 May 2012, 14:51

Aarala wrote:Can you fix Grim Lavamancer not showing the target for it's activated ability? Whenever I play against it I don't know what it's going to hit.
The problem with Grim Lavamancer is that the game considers the cards you exile as the "primary" targets of the spell, so it doesn't bother pointing to the other target (which is the real one, but the game can't understand it).
The card should be completely rewritten, with the cards to exile stored in target data chest 1 and the real target stored in target data chest 0... but even with this, there's still a chance that the bug won't be fixed.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby Pesi » 31 May 2012, 15:53

Anyone who wants to fix Grim Lavamancer should also look at Into the Earthen Maw, which has shown 3, 2, 1, and 0 targeting lines at various times.
Pesi
 
Posts: 21
Joined: 03 May 2012, 15:19
Has thanked: 0 time
Been thanked: 0 time

Re: DOTP2012 Bug fixes

Postby thefiremind » 31 May 2012, 16:40

It all starts from bad coding inside the game anyway. I can't understand why the coders didn't use a simple rule like "every target that is marked as NotTargetted() doesn't produce a line, every other target produces it".
I coded some cards that required to select something as a cost using the method that you see in Into the Earthen Maw (Bone Splinters for example), but it doesn't feel like a cost anymore... for example, you can't cancel the play if you need to. I know it's not a big deal, but it's frustrating that we can't make something perfect because of bad coding on the base.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby pcastellazzi » 01 Jun 2012, 07:59

Aarala wrote:Can you fix Grim Lavamancer not showing the target for it's activated ability? Whenever I play against it I don't know what it's going to hit.
Thank you for pointing this out. I will look into it as soon as i am able.
The lights then came up and the crowd erupted in applause, because that's what the crowd does after it watches destruction on a large screen.
— Ben Kuchera, Mordern Warfare 3 review.
User avatar
pcastellazzi
 
Posts: 184
Joined: 25 Apr 2012, 00:40
Location: Montevideo, Uruguay
Has thanked: 11 times
Been thanked: 30 times

Re: DOTP2012 Bug fixes

Postby Aarala » 02 Jun 2012, 08:13

Pandemonium (and I presume Warstorm Surge by extension) doesn't resolve when the creature gets killed on the stack.
Aarala
 
Posts: 15
Joined: 15 May 2012, 02:28
Has thanked: 1 time
Been thanked: 0 time

Re: DOTP2012 Bug fixes

Postby thefiremind » 02 Jun 2012, 09:33

Aarala wrote:Pandemonium (and I presume Warstorm Surge by extension) doesn't resolve when the creature gets killed on the stack.
What do you mean by "killed on the stack"? If you kill it in response to Pandemonium's activation and the latter doesn't resolve, then yes, it's a bug. But the creature needs the time to make a brief trip to the battlefield.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby Aarala » 02 Jun 2012, 13:41

thefiremind wrote:What do you mean by "killed on the stack"? If you kill it in response to Pandemonium's activation and the latter doesn't resolve, then yes, it's a bug. But the creature needs the time to make a brief trip to the battlefield.
Yea sorry I should have said it tries to sort a nil value since the creature is destroyed before the effect resolves.
Aarala
 
Posts: 15
Joined: 15 May 2012, 02:28
Has thanked: 1 time
Been thanked: 0 time

Re: DOTP2012 Bug fixes

Postby thefiremind » 02 Jun 2012, 13:55

I understood the problem, it's on both Pandemonium and Warstorm Surge, while Electropotence has been coded in a simpler way (which could actually hide the same bug, but for a different reason: I'd suggest to test).

The fastest fix for Pandemonium and Warstorm Surge is to substitute all the "_CardPtr" with "_ProtectedCardPtr", which aren't deleted when the card they point changes zone.

Also be careful when evaluating cards that have "CH" instead of the usual Multiverse ID in the filename: they are cards made for the challenges and could contain code that makes them work as intended in the challenge but is completely out of place otherwise (many creatures made for challenges attack each turn if able, for example). I can't see anything out of place on Pandemonium, though, so it should be safe to use outside the challenges once the bug has been fixed.
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby thefiremind » 04 Jun 2012, 08:27

GamerXYZ0 found a bug in Iona's Judgment:
Code: Select all
    <RESOLUTION_TIME_ACTION>
    Object():GetTargetCard():RemoveFromGame()
    </RESOLUTION_TIME_ACTION>
It's missing the check for not being equal to nil. So it should be:
Code: Select all
    <RESOLUTION_TIME_ACTION>
    if Object():GetTargetCard() ~= nil then
      Object():GetTargetCard():RemoveFromGame()
    end
    </RESOLUTION_TIME_ACTION>
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby pcastellazzi » 04 Jun 2012, 20:43

thefiremind wrote:GamerXYZ0 found a bug in Iona's Judgment:
Code: Select all
    <RESOLUTION_TIME_ACTION>
    Object():GetTargetCard():RemoveFromGame()
    </RESOLUTION_TIME_ACTION>
It's missing the check for not being equal to nil. So it should be:
Code: Select all
    <RESOLUTION_TIME_ACTION>
    if Object():GetTargetCard() ~= nil then
      Object():GetTargetCard():RemoveFromGame()
    end
    </RESOLUTION_TIME_ACTION>
This one was already fixed. The current version of the DLC include the fixed version.
The lights then came up and the crowd erupted in applause, because that's what the crowd does after it watches destruction on a large screen.
— Ben Kuchera, Mordern Warfare 3 review.
User avatar
pcastellazzi
 
Posts: 184
Joined: 25 Apr 2012, 00:40
Location: Montevideo, Uruguay
Has thanked: 11 times
Been thanked: 30 times

Re: DOTP2012 Bug fixes

Postby pcastellazzi » 04 Jun 2012, 22:46

Aarala wrote:Pandemonium (and I presume Warstorm Surge by extension) doesn't resolve when the creature gets killed on the stack.
This two and Electropotence had been fixed. The repo is updated with the latest changes.

About Grim Lavamancer, as suggested by thefiremind the targeting issue is a problem with the engine. I can code the card in a way to workaround this, but exiling cards would be part of the ability and not its cost, which may trouble you later. i.e. if the card is countered cards are not going to be exiled as they should.

I do not think the trade-off is worth it. What do you think?
The lights then came up and the crowd erupted in applause, because that's what the crowd does after it watches destruction on a large screen.
— Ben Kuchera, Mordern Warfare 3 review.
User avatar
pcastellazzi
 
Posts: 184
Joined: 25 Apr 2012, 00:40
Location: Montevideo, Uruguay
Has thanked: 11 times
Been thanked: 30 times

Re: DOTP2012 Bug fixes

Postby thefiremind » 04 Jun 2012, 23:42

pcastellazzi wrote:About Grim Lavamancer, as suggested by thefiremind the targeting issue is a problem with the engine. I can code the card in a way to workaround this, but exiling cards would be part of the ability and not its cost, which may trouble you later. i.e. if the card is countered cards are not going to be exiled as they should.

I do not think the trade-off is worth it. What do you think?
If you pay the costs in PLAY_TIME_ACTIONs, you do it before any answer can be played, so that's not the problem. The problem is that it won't be treated as a cost. I was wrong when I wrote that this prevents you from cancelling the play while you are paying, because with Grim Lavamancer the cards are exiled right after being chosen, so the play can't be cancelled anyway. The difference is that the cards with properly coded costs ask for the target first, and for the costs after. I find confusing to choose the target first in some cards and the costs first in other cards (especially if one of the cards is Glare of Subdual which has very similar "card pools" for both cost and target). We could still choose the target first while using the PLAY_TIME_ACTIONs, by sorting them in a certain way, but would this prevent the bug from being fixed?
< Former DotP 2012/2013/2014 modder >
Currently busy with life...
User avatar
thefiremind
Programmer
 
Posts: 3514
Joined: 07 Nov 2011, 10:55
Has thanked: 117 times
Been thanked: 716 times

Re: DOTP2012 Bug fixes

Postby pcastellazzi » 05 Jun 2012, 00:11

thefiremind wrote:
pcastellazzi wrote:About Grim Lavamancer, as suggested by thefiremind the targeting issue is a problem with the engine. I can code the card in a way to workaround this, but exiling cards would be part of the ability and not its cost, which may trouble you later. i.e. if the card is countered cards are not going to be exiled as they should.

I do not think the trade-off is worth it. What do you think?
If you pay the costs in PLAY_TIME_ACTIONs, you do it before any answer can be played, so that's not the problem. The problem is that it won't be treated as a cost. I was wrong when I wrote that this prevents you from cancelling the play while you are paying, because with Grim Lavamancer the cards are exiled right after being chosen, so the play can't be cancelled anyway. The difference is that the cards with properly coded costs ask for the target first, and for the costs after. I find confusing to choose the target first in some cards and the costs first in other cards (especially if one of the cards is Glare of Subdual which has very similar "card pools" for both cost and target). We could still choose the target first while using the PLAY_TIME_ACTIONs, by sorting them in a certain way, but would this prevent the bug from being fixed?
The order of costs would be wrong, you will select a target, then the cards to discard and finally pay mana and tap the card. Still better than to not know where is going to hit you. I will give it a try.
The lights then came up and the crowd erupted in applause, because that's what the crowd does after it watches destruction on a large screen.
— Ben Kuchera, Mordern Warfare 3 review.
User avatar
pcastellazzi
 
Posts: 184
Joined: 25 Apr 2012, 00:40
Location: Montevideo, Uruguay
Has thanked: 11 times
Been thanked: 30 times

Next

Return to 2012

Who is online

Users browsing this forum: No registered users and 1 guest


Who is online

In total there is 1 user online :: 0 registered, 0 hidden and 1 guest (based on users active over the past 10 minutes)
Most users ever online was 279 on 11 Jul 2013, 22:03

Users browsing this forum: No registered users and 1 guest

Login Form