[REL] BlindWillow's DotP 2013 DLC v5b (30/10/2012)

[SoulStorm]

Blindwillow, I'm working on a new deck which uses your Drogskol Captain with Reveillark. The combination works fine until 2 or more copies of Drogskol Captain have been on the battlefield, thus becoming 3/3 or greater. Once a buffed Drogskol Captain dies, it seem to retain its modified power and toughness thus becoming an illegal target for Reveillark. Presuming I've diagnosed the problem correectly, is there a way to reset the power/toughness values for Drogskol Captain once it hits the graveyard?

Thanks!

[thefiremind]

Blindwillow, I'm working on a new deck which uses your Drogskol Captain with Reveillark. The combination works fine until 2 or more copies of Drogskol Captain have been on the battlefield, thus becoming 3/3 or greater. Once a buffed Drogskol Captain dies, it seem to retain its modified power and toughness thus becoming an illegal target for Reveillark. Presuming I've diagnosed the problem correectly, is there a way to reset the power/toughness values for Drogskol Captain once it hits the graveyard?

Thanks!

The problem isn't in Drogskol Captain, but in Reveillark:
viewtopic.php?f=62&t=8945
I'd suggest everyone to use the code from REVEILLARK_623556 (I think it's by kevlahnota).

[Aarala]

Thanks for the mod! Really appreciate not having unlocks, annoying having to edit a deck each time you start the game.

I noticed Noble Hierarch asked which colour of mana I want on ETB and also is giving an option to tap for mana despite summoning sickness (although it does nothing), and after that it does add mana but doesn't tap allowing you to use it again to 'replace' the mana you tapped for (It doesn't stack)

I'm guessing it's a mod conflict with thefiremind's Deck 1999 core as the only other one I'm using atm is his 1000 core fix.

edit - same thing with Birds of Paradise.

Nope, still doing it. Script Log spewing out alot of this = [lua] ?:0: attempt to index field '?' (a nil value)

[thefiremind]

Thanks for the mod! Really appreciate not having unlocks, annoying having to edit a deck each time you start the game.

I noticed Noble Hierarch asked which colour of mana I want on ETB and also is giving an option to tap for mana despite summoning sickness (although it does nothing), and after that it does add mana but doesn't tap allowing you to use it again to 'replace' the mana you tapped for (It doesn't stack)

I'm guessing it's a mod conflict with thefiremind's Deck 1999 core as the only other one I'm using atm is his 1000 core fix.

edit - same thing with Birds of Paradise.

There's no conflict and no bug, it's just an implementation choice: when you use that ability you choose which kind of mana should be produced by the card, so if you had no available and you choose white, any card that needs will be highlighted and playable, but that's because you can produce from that source, not because you have an additional mana source.

I don't use this kind of tricks exactly because they could be confusing (and because they could create unwanted interactions), but I think it's a nice idea for those who want multi-coloured mana sources at all costs.

[Aarala]

OK it's tapping for coloured mana 'correctly' now (odd), I guess with the scripting choice it won't tap until you cast something that uses mana from the birds of paradise type cards. Still, going to generate alot of script log errors.

[thefiremind]

OK I understand it's a scripting choice but there's still the issue of it not tapping (when you manually add mana)

But that's not an issue: when you use the ability you just choose which mana to produce, then the mana source taps automatically when you play a spell or ability, as the official lands do. The ability says so it might be confusing, but I guess BlindWillow didn't want to add more text for an additional ability to stick the mana choice on.

[Aarala]

Yea, thanks for the clarification. It makes Glare of Subdual a little awkward when you have no spells but oh well.

Oops meant Quest for Renewal (in the Defenders of the Realm deck)

[NEMESiS]

Long-Forgotten Gohei doesn't reduce the cost of with Rend Flesh.

[thefiremind]

Long-Forgotten Gohei doesn't reduce the cost of with Rend Flesh.

This has been already reported but I guess BlindWillow didn't have time to fix that. You can fix that on your own by just changing a value:

Aha. I've discovered, that the Arcane spell type is defined already in the Blindwillow's wad file in Functions folder. But it is defined to SPELL_TYPE_ARCANE = 3830. So I changed it to 3000 as to be the same as in your wad file and only then it works properly. Weird thing is, that I tried changing both lines in both yours and his file to the 3830 number and even then it didn't work. But the main thing is: when you change the line to 3000 in the Deck_1138_ST.wad file in the functions' LOL file, it works! Thanks anyway thefiremind.

This is probably because the SPECS files and the constants are somehow connected inside the executable, so the game expects the first sub-type in SPECS\SPELL_TYPES.TXT (which is Arcane) to have a constant value of 3000. I didn't think about it before.

Find

Code: Select all

SPELL_TYPE_ARCANE = 3830

in the FUNCTIONS folder of BlindWillow's mod and change it to

Code: Select all

SPELL_TYPE_ARCANE = 3000

that's all.

[NEMESiS]

Long-Forgotten Gohei doesn't reduce the cost of with Rend Flesh.

This has been already reported but I guess BlindWillow didn't have time to fix that. You can fix that on your own by just changing a value:

I just wanted to make sure that he was aware of the issue. Looks like its been reported then.

[Vasht]

Hi,

first of all thx for the mod and the tons of cards. i used the Skinshifter card from this mod for another deck and i think there might be an bug.

i had two combats,Skinshifter 4/4 rhino versus 1/3 and Skinshifter 2/2 bird versus 1/1 flyer each time my creature died.

Is this a bug or do i miss something in the ruling of this card ?

[thefiremind]

I think it's a bug, but I looked at the code and I didn't find anything surely wrong... one thing I would have done is to save the query choice aside, but I'm not sure if it could cause such a bug. Anyway, I checked BlindWillow's profile here and I saw that his last visit was in November 2012 so I guess it has more important things to do.

I tried to make a fix but I don't know if it will work.

EDIT: Fix updated with RiiakShiNal's suggestion.

[RiiakShiNal]

Actually, I think the main problem here is that you end the duration once it enters STEP_END_OF_TURN. This was a common problem in DotP 2010 where coders who did not use the function UntilEndOfTurn() for their durations and instead coded it themselves they would often mistakenly use STEP_END_OF_TURN which is the step where any damage dealt to a creature that didn't kill it is healed, but state based effects are checked first. So in that case it would check the state based effects first, see that it was in STEP_END_OF_TURN, remove the effect instead of allowing it to continue, the creature would revert to original stats, die, then the game would check and heal non-dead creatures. If you use STEP_CLEANUP (I use this when I need to cancel or reset something at end of turn and can't use simple_duration="UntilEOT") or you somehow wait until the end of STEP_END_OF_TURN then the creature will be healed before the effect ends.

For reference the DotP 2010 function UntilEndOfTurn():

Code: Select all

function UntilEndOfTurn()
   return (MTG():GetStep() == STEP_CLEANUP)
end

I do agree about saving the chosen option into the EffectDC() and using that to check instead of continually calling Object():GetMultipleChoiceResult().

[thefiremind]

That's the reason for sure, I didn't notice that.

[Vasht]

Hi,

thanks RiiakShiNal and thefiremind.

I changed STEP_END_OF_TURN to STEP_CLEANUP and it worked.