It is currently 12 Nov 2025, 16:59
   
Text Size

Community Wad

Moderator: CCGHQ Admins

Re: Community Wad

Postby MasterXploder7 » 23 Aug 2015, 22:17

[lua] [string "ALHAMMARRETS_ARCHIVE_CW_398564_TITLE (TRIGGER)~0x000004d0"]:2: attempt to index a nil value
Alhammarret's Archive still has the same issue. I am unaware if it will double the life gain.

Can you feel it Mr. Krabs. Can you feel it Mr. Krabs.
"Hate is an everlasting wellspring from which it is eternally sustained." - Nirkana Revenant
MasterXploder7
 
Posts: 293
Joined: 18 Jan 2014, 10:55
Has thanked: 28 times
Been thanked: 11 times

Re: Community Wad

Postby Xander9009 » 23 Aug 2015, 22:34

MasterXploder7 wrote:[lua] [string "ALHAMMARRETS_ARCHIVE_CW_398564_TITLE (TRIGGER)~0x000004d0"]:2: attempt to index a nil value
Alhammarret's Archive still has the same issue. I am unaware if it will double the life gain.

Can you feel it Mr. Krabs. Can you feel it Mr. Krabs.
Did you just update it? It just uploaded the changes I made yesterday and last night an hour ago. I didn't get any errors from it, but before I reinstalled Windows, my game stopped giving me any errors ever, so it may have done that again.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby MasterXploder7 » 23 Aug 2015, 23:57

Xander9009 wrote:
MasterXploder7 wrote:[lua] [string "ALHAMMARRETS_ARCHIVE_CW_398564_TITLE (TRIGGER)~0x000004d0"]:2: attempt to index a nil value
Alhammarret's Archive still has the same issue. I am unaware if it will double the life gain.

Can you feel it Mr. Krabs. Can you feel it Mr. Krabs.
Did you just update it? It just uploaded the changes I made yesterday and last night an hour ago. I didn't get any errors from it, but before I reinstalled Windows, my game stopped giving me any errors ever, so it may have done that again.
it works, however its doubling all the cards drawn. the first card that is drawn at the beginning at each turn shouldnt be doubled.
"Hate is an everlasting wellspring from which it is eternally sustained." - Nirkana Revenant
MasterXploder7
 
Posts: 293
Joined: 18 Jan 2014, 10:55
Has thanked: 28 times
Been thanked: 11 times

Re: Community Wad

Postby Xander9009 » 24 Aug 2015, 00:00

MasterXploder7 wrote:
Xander9009 wrote:
MasterXploder7 wrote:[lua] [string "ALHAMMARRETS_ARCHIVE_CW_398564_TITLE (TRIGGER)~0x000004d0"]:2: attempt to index a nil value
Alhammarret's Archive still has the same issue. I am unaware if it will double the life gain.

Can you feel it Mr. Krabs. Can you feel it Mr. Krabs.
Did you just update it? It just uploaded the changes I made yesterday and last night an hour ago. I didn't get any errors from it, but before I reinstalled Windows, my game stopped giving me any errors ever, so it may have done that again.
it works, however its doubling all the cards drawn. the first card that is drawn at the beginning at each turn shouldnt be doubled.
I know. It's one of the few bugs left that aren't fixed. I listed them all in the Origins Cards thread.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Chakan » 24 Aug 2015, 01:11

Xander, are you going completely solo with converting/testing? I mean, if you need a hand I'll gladly contribute. Even if you just need testing done or something, just let me know what you'd like me to do and I'll help out. If you even want me to convert a complete expansion or something I will.
User avatar
Chakan
 
Posts: 166
Joined: 07 Jun 2014, 23:08
Has thanked: 11 times
Been thanked: 10 times

Re: Community Wad

Postby fallenangle » 24 Aug 2015, 03:11

About the Archive, I coded it, and I did it like this (after advice from Riiak):

Code: Select all
<TRIGGERED_ABILITY replacement_effect="1">
 <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[If you would draw a card except the first one you draw in each of your draw steps, draw two cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Si vous deviez piocher une carte, excepté la première que vous piochez pendant chacune de vos étapes de pioche, piochez deux cartes à la place.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Si fueras a robar una carta, excepto la primera que robas en tus pasos de robar, en vez de eso, roba dos cartas.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Falls du eine Karte ziehen würdest, abgesehen von der ersten, die du in jedem deiner Ziehsegmente ziehst, ziehe stattdessen zwei Karten.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Se stai per pescare una carta, tranne la prima che peschi in ognuna delle tue sottofasi di acquisizione, pesca invece due carte.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[If you would draw a card except the first one you draw in each of your draw steps, draw two cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[If you would draw a card except the first one you draw in each of your draw steps, draw two cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[If you would draw a card except the first one you draw in each of your draw steps, draw two cards instead.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Se você for comprar um card além do primeiro que você compra em cada uma das suas etapas de compra, em vez disso, compre dois cards.]]></LOCALISED_TEXT>
<TRIGGER value="DREW_CARD" simple_qualifier="objectyoucontrol"  pre_trigger="1">
local interrogation = MTG():ClearInterrogationQuery()
         interrogation:SetPlayer( EffectController() )
         local num_drawn_this_turn = interrogation:Count( INTERROGATE_CARDS_DRAWN, INTERROGATE_THIS_TURN, 2 )
         if EffectController():MyTurn() and num_drawn_this_turn == 0 and MTG():GetStep() == STEP_DRAW then
            return false
         else
         MTG():OverrideEvent()
            return true
         end
</TRIGGER>
 <RESOLUTION_TIME_ACTION>
         EffectController():DrawCards(2)
      </RESOLUTION_TIME_ACTION>
   </TRIGGERED_ABILITY>
It was counterintuitive for me to check for cards drawn = 0, but since I used a pre-trigger, Riiak explained that that's what I needed to do. It worked for me without issue before it was officially added to the WAD. I don't know if the code has changed between then and now. For the double life gain, I just copied that from a white card that has the same effect, so it should work.
fallenangle
 
Posts: 319
Joined: 20 Jul 2013, 02:31
Has thanked: 73 times
Been thanked: 41 times

Re: Community Wad

Postby Xander9009 » 24 Aug 2015, 03:42

@Chakan: I'm done with everything in Origins except Pyromancer's Goggles, Alhammarret's Archive, and the planeswalkers. However, if you'd offered a couple of days ago, I would definitely have taken you up on it, though, so thanks. :)

@fallenangle: I caught (after a couple failed tests) that I needed to check for 0 instead of 1 because it was a pre_trigger (just ask my friend; I was pretty vocally annoyed such tiny things cause such big problems haha). Unfortunately, it still didn't work. I'm not sure why the one in the CW isn't from you. I thought I caught all of the cards that were already in the CW so I wouldn't code them again, but I missed a couple, and this must have been one of them. It's fixed now, though. The problem I had was that I accidentally had
Code: Select all
if MTG():GetStep() == STEP_DRAW and MTG():GetCurrentTeam() == EffectController() then
instead of
Code: Select all
if MTG():GetStep() == STEP_DRAW and EffectController():MyTurn() then
I missed the GetTeam() call on EffectController(), so it was comparing a player to a team and always returning false. Simply calling EffectController():MyTurn() works, though.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Chakan » 24 Aug 2015, 04:08

Xander9009 wrote:@Chakan: I'm done with everything in Origins except Pyromancer's Goggles, Alhammarret's Archive, and the planeswalkers. However, if you'd offered a couple of days ago, I would definitely have taken you up on it, though, so thanks. :)
My offer still stands though man. Hit me up if you ever need help with something.
User avatar
Chakan
 
Posts: 166
Joined: 07 Jun 2014, 23:08
Has thanked: 11 times
Been thanked: 10 times

Re: Community Wad

Postby MasterXploder7 » 24 Aug 2015, 04:22

If anyone would like too, Phyrexian Rebirth doesnt produce the X/X token.
"Hate is an everlasting wellspring from which it is eternally sustained." - Nirkana Revenant
MasterXploder7
 
Posts: 293
Joined: 18 Jan 2014, 10:55
Has thanked: 28 times
Been thanked: 11 times

Re: Community Wad

Postby Xander9009 » 24 Aug 2015, 04:55

Chakan wrote:
Xander9009 wrote:@Chakan: I'm done with everything in Origins except Pyromancer's Goggles, Alhammarret's Archive, and the planeswalkers. However, if you'd offered a couple of days ago, I would definitely have taken you up on it, though, so thanks. :)
My offer still stands though man. Hit me up if you ever need help with something.
Thanks. Also, just for the record, I didn't really intend to code all of the remaining Origins cards. I just intended to code some of them, and kind of ended up completing the set. But yeah, when Battle for Zendikar is released, I'll probably be at it again. :)

MasterXploder7 wrote:If anyone would like too, Phyrexian Rebirth doesnt produce the X/X token.
Thanks. I think I spotted the problem and it should be fixed. Also, I don't know if you caught it, but fallenangle helped me spot the problem with Alhammarret's Archive, so it should be working in the next repack, as well.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby MasterXploder7 » 24 Aug 2015, 20:09

Thank you Xander. I dont know if we give you, or the other modders for that matter, enough thanks. Thank you all, so very, very, much.
"Hate is an everlasting wellspring from which it is eternally sustained." - Nirkana Revenant
MasterXploder7
 
Posts: 293
Joined: 18 Jan 2014, 10:55
Has thanked: 28 times
Been thanked: 11 times

Re: Community Wad

Postby Borborigmos » 25 Aug 2015, 18:58

Zendikar's Roil works! Thank you!

I found the art for the tokens, although it's nowhere near good quality :(

http://i.tcgplayer.com/100287.jpg

B.
Borborigmos
 
Posts: 90
Joined: 13 Apr 2015, 16:24
Has thanked: 25 times
Been thanked: 4 times

Re: Community Wad

Postby Xander9009 » 25 Aug 2015, 19:08

Hahaha Nice timing. I'm literally working on all of the tokens right now. I've already gotten that one, and I'm about 90% done with getting all of the other tokens higher quality where I can and renaming the images properly (many got messed up and I'm fixing them).

I found the best quality image for that token I could here: http://www.mtgsalvation.com/forums/magi ... emed-cards

Also, related to my token image updating, I'm planning to write a function and change a few cards to use the function. The purpose of it will be to create a random token among those available. So, you tell it to create a 1/1 green saproling, and it'll do so, but it will not have a given image, it'll instead be one of the 7(?) possible 1/1 saprolings. They probably won't stack if they have different images, though. I'll have to test that. And if they don't, then I'm not sure I'd want to do that... But I play quite a few token decks and it'd be nice to make use of the alternate art.
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

Re: Community Wad

Postby Borborigmos » 26 Aug 2015, 16:02

Xander9009 wrote:Also, related to my token image updating, I'm planning to write a function and change a few cards to use the function. The purpose of it will be to create a random token among those available. So, you tell it to create a 1/1 green saproling, and it'll do so, but it will not have a given image, it'll instead be one of the 7(?) possible 1/1 saprolings. They probably won't stack if they have different images, though. I'll have to test that. And if they don't, then I'm not sure I'd want to do that... But I play quite a few token decks and it'd be nice to make use of the alternate art.
Oh that sounds awesome!! :)

Although for this particular green 2/2 elemental I think it might be unique? Stuff like 2/2 zombies are more diverse though hehe
Borborigmos
 
Posts: 90
Joined: 13 Apr 2015, 16:24
Has thanked: 25 times
Been thanked: 4 times

Re: Community Wad

Postby Xander9009 » 26 Aug 2015, 16:40

Correct, there is only one green 2/2 elemental. However, I might use the 3/3 green elemental token image from Evil Comes to Fruition. It's a scheme card used in 2012's Archenemy, so there's a HQ image available, and since that token is only ever used for a Scheme, it'll never be seen in the game otherwise. But yeah, there are certainly some with quite a few.
Zombies: 9
Goblins: 8
Saprolings: 8
Soldiers: 7
Angels: 7
Spirits: 6
Wolves: 6
Birds: 5
Beasts: 4
(There are multiple version of all of these, but these are the highest number of alternates for a single version, so only 1/1 white birds make up the 5 there and any blue or otherwise different birds were ignored.)

There is some overlap, but not much. Specifically, there's a goblin token with haste which I used as a goblin without haste, as well, because Stainless did the same thing with that image. There are also a couple that I was forced to reuse. There is no Goblin Shaman token with an ability, so the one without the ability was used.

Note that there will be many borders visible. However, I've gone through and used all of the base game's token images where possible. I even went back through 2013 and 2012 (and 2015 is still in progress) and got token images from there. When we're able to extract Origins zed files, I'll get those, too. I don't have the original (2010) and there's no demo for it, so I can't get those. If someone wants to send them to me, that'd be cool.

(That was a lot more typing that I expected out of a response to nothing more than "I think this one's unique"... Oops lol.)
_______________________________
Community Wad - Community Wad Website - How to Help and Report Bugs
Discord: discord.gg/4AXvHzW
User avatar
Xander9009
Programmer
 
Posts: 2905
Joined: 29 Jun 2013, 07:44
Location: Indiana, United States
Has thanked: 121 times
Been thanked: 445 times

PreviousNext

Return to 2014

Who is online

Users browsing this forum: No registered users and 7 guests

Main Menu

User Menu

Our Partners


Who is online

In total there are 7 users online :: 0 registered, 0 hidden and 7 guests (based on users active over the past 10 minutes)
Most users ever online was 9824 on 10 Nov 2025, 04:33

Users browsing this forum: No registered users and 7 guests

Login Form