Formal Request Thread

[thefiremind]

Hythonia the Cruel - This card is stuck in a never-ending loop trying to resolve itself whenever an ability is activated or a land is tapped for mana.

You forgot the resource_id="1" for the TRIGGERED_ABILITY (take another look at my Shipbreaker Kraken if you have doubts).

Keepsake Gorgon - This card is also stuck in a never-ending loop trying to resolve itself whenever an ability is activated or a land is tapped for mana.

You haven't posted the code, but I guess the problem is the same.

Killing Glare - The target isn't destroyed but I did manage to make the 'X' counter work.

Of course the target isn't destroyed... you save it on register 0 and read it on register 1...
I'm not using CODE in the following snippet because I need to use colors.

<TARGET tag="CARD_QUERY_CHOOSE_CREATURE_TO_DESTROY" definition="0" compartment="0" count="1" />
<TARGET_DEFINITION id="0">
local filter = ClearFilter()
filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
filter:Add( FE_POWER, OP_LESS_THAN_OR_EQUAL_TO, X )
</TARGET_DEFINITION>
<RESOLUTION_TIME_ACTION>
local target_creature = EffectDC():Get_Targets(0):Get_CardPtr(0)
if target_creature ~= nil then
target_creature:Destroy()
end
</RESOLUTION_TIME_ACTION>
<AI_SIMPLIFIED_TARGETING compartment="0" hint="HINT_ENEMY_ONLY" />

Same color means they refer to the same data, so they need to match.

Pharika's Mender - There is no option to retreive anything from the graveyard and accordingly nothing returns.

What you coded here is "you may return target creature card and target enchantment card from your graveyard to your hand", which can't trigger if you don't have both targets available. Actually, your code wouldn't work anyway because you used the same compartment and ID for both targets.
Look at Solemn Offering: it asks for target artifact or enchantment. Change CARD_TYPE_ARTIFACT to CARD_TYPE_CREATURE and you have the definition for that pairing. Don't delete your SetZone, that's correct as it is.

This is what i got for pharika mender

What you coded here is "you may return target creature enchantment card from your graveyard to your hand"... it would basically work only on the Gods and the bestow creatures.
The filters are set to "And" by default, which means that all the conditions you add must be true. If your situation requires any one of the conditions to be true (not necessarily all of them), you need to create a sub-filter set to "Or" with those conditions (or set the whole filter to "Or", but let's forget about that unless you need a complicated filter such as Death Baron).

Sisters of Stone Death - This one is impossible to implement. Although, I was looking @ Ashiok, Nightmare Weaver for ideas.

The problem is in the first ability, which has nothing to do with Ashiok.
EDIT: Before someone asks the same questions again, I'll explain it once more: "creature A blocks creature B if able" implies that if creature A can't block creature B (for example because creature B gained shadow), the effect must not hinder creature A's capability to block: creature A should be able to block normally in that case. While we can check for unblockable, flying, shadow, reach, fear and intimidate, we can't check for blocking exceptions that aren't characteristic-based, such as Hunted Ghoul.

[drleg3nd]

Ok TFM, if a card giving two choices has "OR" i need to add subfilter :local subfilter = filter:AddSubFilter_Or() otherwise it would be "AND" right ?

[jacque]

Hythonia the Cruel - This card is stuck in a never-ending loop trying to resolve itself whenever an ability is activated or a land is tapped for mana.
Keepsake Gorgon - This card is also stuck in a never-ending loop trying to resolve itself whenever an ability is activated or a land is tapped for mana.

>.< Kieran, I am quite sure the ones I posted worked =(

[RiiakShiNal]

if a card giving two choices has "OR" i need to add subfilter :local subfilter = filter:AddSubFilter_Or() otherwise it would be "AND" right ?

That's right, Filters are "And" by default (top level is always "And") on the sub-filters you can use "And" and/or "Or". Even still when you add an "Or" sub-filter you need to make sure to add the conditions to be "Or"'d to the sub-filter instead of to the main filter.

[Kieran]

@jacque: Be of good cheer! I'm confident they work properly but I wanted to try to code them for myself using your tutorial and then ask questions about where I messed up. Believe me, I've already grabbed your work and saved it. Thanks for the XMLs and the tutorial!

@TFM: Thanks for the insight! I'll post the results of the changes you've recommended.

[fallenangle]

I can confirm that Jacque's Hythonia and Keepsake Gorgon both work properly. However, it is a good idea to add a static block with the monstrous ability so that it shows up on the cards as readable. Thefiremind's Shipbreaker Kraken and his earlier post about monstrous in this thread are helpful for this.

[drleg3nd]

i don't know if someone made this already but i could use this..

Mind Grind | Open

Code: Select all

<SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Each opponent reveals cards from the top of his or her library until he or she reveals X land cards, then puts all cards revealed this way into his or her graveyard. X can’t be 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Chaque adversaire révèle les cartes du dessus de sa bibliothèque jusqu’à révéler X cartes de terrain, puis il met toutes les cartes révélées de cette manière dans son cimetière. X ne peut pas être 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cada oponente muestra cartas de la parte superior de su biblioteca hasta que muestre X cartas de tierra, luego pone en su cementerio todas las cartas mostradas de esta manera. X no puede ser 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Jeder Gegner deckt Karten oben von seiner Bibliothek auf, bis er X Land-Karten aufdeckt, dann legt er alle auf diese Weise aufgedeckten Karten auf seinen Friedhof. X kann nicht 0 sein.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Ogni avversario rivela carte dalla cima del proprio grimorio fino a che non rivela X carte terra, poi mette tutte le carte rivelate in questo modo nel proprio cimitero. X non può essere 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[各対戦相手はそれぞれ自分のライブラリーの一番上から、土地カードがＸ枚公開されるまでカードを公開し続ける。その後これにより公開されたすべてのカードを自分の墓地に置く。Ｘは０にできない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[각 상대는 대지 카드가 X장 나올 때까지 자신의 서고 맨 위에서부터 카드를 공개한 후, 공개된 카드들을 자신의 무덤에 넣는다. X는 0일 수 없다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Каждый оппонент показывает карты с верха своей библиотеки до тех пор, пока не покажет Х карт земель, затем кладет все показанные таким образом карты на свое кладбище. Х не может равняться 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Cada oponente revela cards do topo do próprio grimório até revelar X cards de terreno e, depois, coloca todos os cards revelados dessa maneira no próprio cemitério. X não pode ser 0.]]></LOCALISED_TEXT>
  </SPELL_ABILITY>


[Kieran]

Thanks for the other cards drleg3nd! Let's also request Tenacious Dead in addition to Mind Grind so we can go ahead and finish both deck request.

Edit: I just realized I didn't say thanks for your help fallenangle. Your reference was helpful. Thanks!

[SystemSCSnake]

I request Shard Volley, Ball Lightning, and Spark Elemental. Thanks in advance!

EDIT: Add Walking Archive, Kami of the Crescent Moon and Jace's Archivist to that. I should probably just learn to code myself

[jacque]

Thanks for the other cards drleg3nd! Let's also request Tenacious Dead in addition to Mind Grind so we can go ahead and finish both deck request.

Edit: I just realized I didn't say thanks for your help fallenangle. Your reference was helpful. Thanks!

Kieran!!!
- Tenacious Dead (Sorry I don't have M14 artwork =()

*more to come =)*

I request Shard Volley, Ball Lightning, and Spark Elemental. Thanks in advance!

EDIT: Add Walking Archive, Kami of the Crescent Moon and Jace's Archivist to that. I should probably just learn to code myself

Here you are... more to come too... *I hope* LOL
- Ball Lightning
- Spark Elemental
- Shard Volley

[Kieran]

Here is a HQ pic of Tenacious Dead.

@jacque: Thanks my friend! Also, I'm having trouble trying to make Crypt Incursion. I started by looking @ Rakdos Charm but the second part that causes life gain eludes me. Now I realize that 2013 spoiled me because there were so many cards already created it was simple to just refer to them for code structure. Again, thank you so much!

[jacque]

TD.jpg

@jacque: Thanks my friend! Also, I'm having trouble trying to make Crypt Incursion. I started by looking @ Rakdos Charm but the second part that causes life gain eludes me. Now I realize that 2013 spoiled me because there were so many cards already created it was simple to just refer to them for code structure. Again, thank you so much!

@Kieran: I'm currently testing Mind Grind... *almost done* xD

EDIT: Deviated from *almost done* to far from done >.<

[thefiremind]

The problem with Mind Grind is that we don't have a support for "X can't be 0". When I made Aeon Chronicler I modified its text changing all "X" with "X+1" and adding to the suspend cost. But that was an ability: I'd advise not to do the same with Mind Grind, otherwise its CMC would be different. If the card had at least 1 target you could make it depend on X and SetTargetCount(0) when X was 0... the only choice with Mind Grind is to make sure that it does absolutely nothing when X is 0.

Also, I'm having trouble trying to make Crypt Incursion.

You need filter evaluation for that.

Code: Select all

    <RESOLUTION_TIME_ACTION>
    local target_player = EffectDC():Get_Targets(0):Get_PlayerPtr(0)
    if target_player ~= nil then
       local filter = ClearFilter()
       filter:SetZone( ZONE_GRAVEYARD, target_player )
       filter:Add( FE_TYPE, OP_IS, CARD_TYPE_CREATURE )
       local count = filter:EvaluateObjects()
       if count &gt; 0 then
          for i=0,count-1 do
             filter:GetNthEvaluatedObject(i):Exile()
          end
          EffectController():GainLife(3*count)
       end
    end
    </RESOLUTION_TIME_ACTION>

------------------------

EDIT: This is my Mind Grind. If X is 0, the spell resolves, but does nothing. If someone has a better idea, please share it.

Mind Grind (tested but not 100% correct) | Open

Code: Select all

<?xml version='1.0' encoding='UTF-8'?>
<CARD_V2 ExportVersion="1">
  <FILENAME text="MIND_GRIND_366418" />
  <CARDNAME text="MIND_GRIND" />
  <TITLE>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Mind Grind]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Broyeur d’esprit]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Moler la mente]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Gedanken radieren]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Macina Mentale]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[精神削り]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[정신 갈아엎기]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Перемалывание Разума]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Trituração Mental]]></LOCALISED_TEXT>
  </TITLE>
  <MULTIVERSEID value="366418" />
  <ARTID value="366418" />
  <ARTIST name="Daarken" />
  <CASTING_COST cost="{X}{U}{B}" />
  <TYPE metaname="Sorcery" />
  <EXPANSION value="GTC" />
  <RARITY metaname="R" />
  <SPELL_ABILITY>
    <LOCALISED_TEXT LanguageCode="en-US"><![CDATA[Each opponent reveals cards from the top of his or her library until he or she reveals X land cards, then puts all cards revealed this way into his or her graveyard. X can’t be 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="fr-FR"><![CDATA[Chaque adversaire révèle les cartes du dessus de sa bibliothèque jusqu’à révéler X cartes de terrain, puis il met toutes les cartes révélées de cette manière dans son cimetière. X ne peut pas être 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="es-ES"><![CDATA[Cada oponente muestra cartas de la parte superior de su biblioteca hasta que muestre X cartas de tierra, luego pone en su cementerio todas las cartas mostradas de esta manera. X no puede ser 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="de-DE"><![CDATA[Jeder Gegner deckt Karten oben von seiner Bibliothek auf, bis er X Land-Karten aufdeckt, dann legt er alle auf diese Weise aufgedeckten Karten auf seinen Friedhof. X kann nicht 0 sein.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="it-IT"><![CDATA[Ogni avversario rivela carte dalla cima del proprio grimorio fino a che non rivela X carte terra, poi mette tutte le carte rivelate in questo modo nel proprio cimitero. X non può essere 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="jp-JA"><![CDATA[各対戦相手はそれぞれ自分のライブラリーの一番上から、土地カードがＸ枚公開されるまでカードを公開し続ける。その後これにより公開されたすべてのカードを自分の墓地に置く。Ｘは０にできない。]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ko-KR"><![CDATA[각 상대는 대지 카드가 X장 나올 때까지 자신의 서고 맨 위에서부터 카드를 공개한 후, 공개된 카드들을 자신의 무덤에 넣는다. X는 0일 수 없다.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="ru-RU"><![CDATA[Каждый оппонент показывает карты с верха своей библиотеки до тех пор, пока не покажет Х карт земель, затем кладет все показанные таким образом карты на свое кладбище. Х не может равняться 0.]]></LOCALISED_TEXT>
    <LOCALISED_TEXT LanguageCode="pt-BR"><![CDATA[Cada oponente revela cards do topo do próprio grimório até revelar X cards de terreno e, depois, coloca todos os cards revelados dessa maneira no próprio cemitério. X não pode ser 0.]]></LOCALISED_TEXT>
    <RESOLUTION_TIME_ACTION>
    local x = GetEffectX()
    if x &gt; 0 then
       -- If X is 0, the reveal count will be 0 for all players and nothing will happen. That's the best we can do for "X can't be 0", unfortunately.
       local myTeam = EffectController():GetTeam()
       for p=0,MTG():GetNumberOfPlayers()-1 do
          local nthPlayer = MTG():GetNthPlayer(p)
          if nthPlayer ~= nil and nthPlayer:GetTeam() ~= myTeam then
             local max_count = nthPlayer:Library_Count()
             local land_count = 0
             local reveal_count = max_count
             if max_count &gt; 0 then
                for i=0,max_count-1 do
                   local card = nthPlayer:Library_GetNth(i)
                   if card:GetCardType():Test(CARD_TYPE_LAND) then
                      land_count = land_count + 1
                      if land_count == x then
                         reveal_count = i+1
                         break
                      end
                   end
                end
             end
             EffectDC():Set_Int(p, reveal_count)
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION repeating="1">
    local n = MTG():GetActionRepCount()
    if n &lt; MTG():GetNumberOfPlayers() then
       local myTeam = EffectController():GetTeam()
       local nthPlayer = MTG():GetNthPlayer(n)
       if nthPlayer ~= nil and nthPlayer:GetTeam() ~= myTeam then
          local reveal_count = EffectDC():Get_Int(n)
          if reveal_count &gt; 0 then
             for i=0,reveal_count-1 do
                nthPlayer:Library_GetNth(i):Reveal()
             end
          end
       end
       return true
    end
    return false
    </RESOLUTION_TIME_ACTION>
    <RESOLUTION_TIME_ACTION>
    local myTeam = EffectController():GetTeam()
    for p=0,MTG():GetNumberOfPlayers()-1 do
       local nthPlayer = MTG():GetNthPlayer(p)
       if nthPlayer ~= nil and nthPlayer:GetTeam() ~= myTeam then
          local reveal_count = EffectDC():Get_Int(p)
          if reveal_count &gt; 0 then
             nthPlayer:MillCards(reveal_count)
          end
       end
    end
    </RESOLUTION_TIME_ACTION>
  </SPELL_ABILITY>
  <AI_BASE_SCORE score="750" zone="ZONE_HAND" />
</CARD_V2>

[SystemSCSnake]

I request Shard Volley, Ball Lightning, and Spark Elemental. Thanks in advance!

EDIT: Add Walking Archive, Kami of the Crescent Moon and Jace's Archivist to that. I should probably just learn to code myself

Here you are... more to come too... *I hope* LOL
- Ball Lightning
- Spark Elemental
- Shard Volley[/quote]

Thanks a ton! Way awesome man

[jacque]

Again, thank you so much!

Thanks to you as well my friend =)... Where did u find HQ pics for THS cards neways? You have a source or sumthing?

Thanks a ton! Way awesome man

NP =) Those are wayyyy easier to code than the rest... so yea... xD

@Kieran: I'm currently testing Mind Grind... *almost done* xD

Finally came out with another version of Mind Grind as well... working on the X=0 check... hmmm if there's another way around it... Hmmm